Skip to content

feat(overlay): add custom classes for backdrop - #1532

Merged
jelbourn merged 1 commit into
angular:masterfrom
kara:overlay
Oct 19, 2016
Merged

feat(overlay): add custom classes for backdrop#1532
jelbourn merged 1 commit into
angular:masterfrom
kara:overlay

Conversation

@kara

@karakara commented Oct 19, 2016

Copy link
Copy Markdown
Contributor

This PR allows components to add a custom class to the overlay backdrop. This will allow us to use the backdrop as a click catcher in components like the menu and the select.

r: @jelbourn

@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 19, 2016
@fxck

fxck commented Oct 19, 2016

Copy link
Copy Markdown
Contributor

#1438

@kara

kara commented Oct 19, 2016

Copy link
Copy Markdown
ContributorAuthor

@fxck Can you elaborate? Your PR appears to have to do with overlay panes, not overlay backdrops. I assume @jelbourn will want to weigh in on the design for that one separately.

@fxck

fxck commented Oct 19, 2016

Copy link
Copy Markdown
Contributor

Hm, thought the backdrop was a child of the pane and thus the custom class on it could be used, but it's a child of the overlay.. so yeah. Ignore my comment.

@jelbourn

Copy link
Copy Markdown
Contributor

LGTM

@karakara added the action: merge The PR is ready for merge by the caretaker label Oct 19, 2016
@jelbourn
jelbourn merged commit 0b54668 into angular:masterOct 19, 2016
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 6, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kara@fxck@jelbourn@googlebot