Skip to content

fix(badge): duplicate leftover badge after server-side render - #15417

Merged
josephperrott merged 1 commit into
angular:masterfrom
crisbeto:badge-ssr-duplicate
Mar 8, 2019
Merged

fix(badge): duplicate leftover badge after server-side render#15417
josephperrott merged 1 commit into
angular:masterfrom
crisbeto:badge-ssr-duplicate

Conversation

@crisbeto

@crisbetocrisbeto commented Mar 7, 2019

Copy link
Copy Markdown
Member

Fixes badges being left over if the current page was rendered via Angular Universal. This can cause issues, because the ids on the badges can clash.

@crisbeto
fix(badge): duplicate leftover badge after server-side render
e37a87f
Fixes badges being left over if the current page was rendered via Angular Universal. This can cause issues, because the ids on the badges can clash.
@crisbetocrisbeto added the target: patch This PR is targeted for the next patch release label Mar 7, 2019
@crisbeto
crisbeto requested a review from jelbourn as a code ownerMarch 7, 2019 22:29
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 7, 2019
josephperrott
josephperrott approved these changes Mar 8, 2019
View reviewed changes

@josephperrottjosephperrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrottjosephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 8, 2019
@ngbot

ngbotBot commented Mar 8, 2019

Copy link
Copy Markdown

I see that you just added the pr: merge ready label, but the following checks are still failing:
failure status "branch-manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@josephperrott
josephperrott merged commit c5a32c2 into angular:masterMar 8, 2019
josephperrott pushed a commit that referenced this pull request Mar 8, 2019
@crisbeto@josephperrott
fix(badge): duplicate leftover badge after server-side render (#15417)
815a729
Fixes badges being left over if the current page was rendered via Angular Universal. This can cause issues, because the ids on the badges can clash.
Suresh918 pushed a commit to Suresh918/material2 that referenced this pull request Apr 15, 2019
@crisbetosuputhul
fix(badge): duplicate leftover badge after server-side render (angula…
5bbbfe3
…r#15417)
Fixes badges being left over if the current page was rendered via Angular Universal. This can cause issues, because the ids on the badges can clash.
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 10, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrottjosephperrottjosephperrott approved these changes
@jelbournjelbournAwaiting requested review from jelbourn

Assignees

@josephperrottjosephperrott

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto@josephperrott@googlebot