Uh oh!
There was an error while loading. Please reload this page.
fix(material/radio): clear names from host nodes - #15422
Closed
crisbeto wants to merge 1 commit into
Closed
Conversation
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Mar 16, 2019
Along the same lines as angular#15422 and angular#15368. Clears the static `name` attribute from the slide toggle's host node in order to prevent both the underlying input and the host from showing up in `document.getElementsByName` or `By.name`.
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Mar 23, 2019
Along the same lines as angular#15422 and angular#15368. Clears the static `name` attribute from the slide toggle's host node in order to prevent both the underlying input and the host from showing up in `document.getElementsByName` or `By.name`.
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
May 4, 2019
Along the same lines as angular#15422 and angular#15368. Clears the static `name` attribute from the slide toggle's host node in order to prevent both the underlying input and the host from showing up in `document.getElementsByName` or `By.name`.
crisbetoforce-pushed
the
radio-host-node-names
branch
from
July 1, 2019 20:16
225cbc8 to
a6b2616Comparecrisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Jul 21, 2019
Along the same lines as angular#15422 and angular#15368. Clears the static `name` attribute from the slide toggle's host node in order to prevent both the underlying input and the host from showing up in `document.getElementsByName` or `By.name`.
crisbetoforce-pushed
the
radio-host-node-names
branch
from
October 1, 2019 19:32
a6b2616 to
5c2c31bComparecrisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Nov 29, 2019
Along the same lines as angular#15422 and angular#15368. Clears the static `name` attribute from the slide toggle's host node in order to prevent both the underlying input and the host from showing up in `document.getElementsByName` or `By.name`.
crisbetoforce-pushed
the
radio-host-node-names
branch
from
May 2, 2020 15:08
5c2c31b to
d298469Comparecrisbetoforce-pushed
the
radio-host-node-names
branch
from
June 7, 2020 09:12
d298469 to
f7e96d2Comparecrisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Jan 10, 2021
Along the same lines as angular#15422 and angular#15368. Clears the static `name` attribute from the slide toggle's host node in order to prevent both the underlying input and the host from showing up in `document.getElementsByName` or `By.name`.
devversion
removed their request for review
August 18, 2021 12:54
crisbeto added a commit
to crisbeto/material2
that referenced
this pull request
Mar 7, 2022
Along the same lines as angular#15422 and angular#15368. Clears the static `name` attribute from the slide toggle's host node in order to prevent both the underlying input and the host from showing up in `document.getElementsByName` or `By.name`.
crisbetoforce-pushed
the
radio-host-node-names
branch
from
March 7, 2022 08:45
f7e96d2 to
bbbc038Compareforsti0506 pushed a commit
to forsti0506/components
that referenced
this pull request
Apr 3, 2022
Along the same lines as angular#15422 and angular#15368. Clears the static `name` attribute from the slide toggle's host node in order to prevent both the underlying input and the host from showing up in `document.getElementsByName` or `By.name`.
amysorto
commented
May 11, 2022
Contributor
Shoud the name be assigned to the inner input? In a test within google3, the input within the radio had this name "mat-radio-group-0" instead of what was being passed in. |
andrewseguin
commented
Aug 15, 2022
Contributor
@crisbeto Heads up that Amy has a quick question about going forward on this change |
MemberAuthor
I think that we talked through this over DM at some point. The fix is correct, but it ended up breaking internally because apps were projecting all sorts of unrelated content into the radio buttons. |
andrewseguin
commented
Aug 15, 2022
Contributor
Gotcha thanks - @amysorto Do you have a good idea on how to get those tests passing with this change? Feel free to pair with myself or Kristiyan to get this in |
Along the same lines as angular#15368. Clears the `name` from the host node of the radio button and radio group, because they end up being forwarded to the underlying `input` and can cause double results when using something like `getElementsByName`.
crisbetoforce-pushed
the
radio-host-node-names
branch
from
August 23, 2022 16:21
bbbc038 to
fe0f0e8Comparecrisbeto
commented
Feb 28, 2024
MemberAuthor
Looks like this is really breaking internally. I'll close it for now since we haven't gotten any issue reports about it. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Along the same lines as #15368. Clears the
namefrom the host node of the radio button and radio group, because they end up being forwarded to the underlyinginputand can cause double results when using something likegetElementsByName.