Skip to content

test(chip-list): rework tests to work under Ivy - #15428

Merged
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:chip-list-tests-ivy
Mar 11, 2019
Merged

test(chip-list): rework tests to work under Ivy#15428
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:chip-list-tests-ivy

Conversation

@crisbeto

@crisbetocrisbeto commented Mar 10, 2019

Copy link
Copy Markdown
Member

Equivalent of #15427 for master. Fixes the chip list tests that are failing under Ivy due to a known breaking change.

@crisbeto
test(chip-list): rework tests to work under Ivy
73f23d9
Equivalent of angular#15427 for master. Fixes the chip list tests that are failing under Ivy due to a known breaking change.
@crisbetocrisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Mar 10, 2019
@crisbeto
crisbeto requested a review from jelbourn as a code ownerMarch 10, 2019 07:19
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 10, 2019
@josephperrottjosephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 11, 2019
josephperrott
josephperrott reviewed Mar 11, 2019
View reviewed changes

@josephperrottjosephperrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba
mmalerba merged commit ac7b3cd into angular:masterMar 11, 2019
mmalerba pushed a commit that referenced this pull request Mar 18, 2019
@crisbeto@mmalerba
test(chip-list): rework tests to work under Ivy (#15428)
f35ca66
Equivalent of #15427 for master. Fixes the chip list tests that are failing under Ivy due to a known breaking change.
Suresh918 pushed a commit to Suresh918/material2 that referenced this pull request Apr 15, 2019
@crisbetosuputhul
test(chip-list): rework tests to work under Ivy (angular#15428)
04cfbb1
Equivalent of angular#15427 for master. Fixes the chip list tests that are failing under Ivy due to a known breaking change.
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 10, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrottjosephperrottjosephperrott left review comments
@jelbournjelbournAwaiting requested review from jelbourn

Assignees

@josephperrottjosephperrott

@andrewseguinandrewseguin

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@crisbeto@josephperrott@googlebot@mmalerba@andrewseguin