Skip to content

refactor(datepicker): adapt custom header demo for Ivy - #15458

Merged
mmalerba merged 1 commit into
angular:masterfrom
marclaval:fixDatePickerDemo
Mar 14, 2019
Merged

refactor(datepicker): adapt custom header demo for Ivy#15458
mmalerba merged 1 commit into
angular:masterfrom
marclaval:fixDatePickerDemo

Conversation

@marclaval

Copy link
Copy Markdown
Contributor

In Ivy, @host() no longer looks in module injector. This breaks this demo.

@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 13, 2019
@marclaval
marclavalforce-pushed the fixDatePickerDemo branch 2 times, most recently from 538b259 to e18b1d2CompareMarch 13, 2019 15:50

@crisbetocrisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbetocrisbeto added P2 The issue is important to a large percentage of users, with a workaround pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 13, 2019
@mmalerba

Copy link
Copy Markdown
Contributor

I think there's an example with a similar failure that you might want to update as well: "Datepicker with custom calendar header"

@marclaval

Copy link
Copy Markdown
ContributorAuthor

I've updated the example, PTAL

@mmalerba
mmalerba merged commit db4e2e2 into angular:masterMar 14, 2019
Suresh918 pushed a commit to Suresh918/material2 that referenced this pull request Apr 15, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License AgreementP2The issue is important to a large percentage of users, with a workaroundtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@marclaval@mmalerba@crisbeto@googlebot