Skip to content

fix(stepper): avoid breaking change in stepControl type - #15464

Merged
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:15462/stepper-breaking-change
Mar 13, 2019
Merged

fix(stepper): avoid breaking change in stepControl type#15464
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:15462/stepper-breaking-change

Conversation

@crisbeto

Copy link
Copy Markdown
Member

In #15134 we reworked the stepper not to depend on @angular/forms under the assumption that our limited FormControl interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the stepControl type to avoid the breaking change.

Fixes#15462.

@crisbetocrisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Mar 13, 2019
@crisbeto
crisbeto requested a review from mmalerba as a code ownerMarch 13, 2019 18:13
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 13, 2019
@mmalerbammalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 13, 2019
@ngbot

ngbotBot commented Mar 13, 2019

Copy link
Copy Markdown

I see that you just added the pr: merge ready label, but the following checks are still failing:
failure status "ci/circleci: api_golden_checks" is failing
pending status "ci/circleci: tests_browserstack" is pending
pending status "ci/circleci: tests_local_browsers" is pending
pending status "ci/circleci: tests_saucelabs" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

In angular#15134 we reworked the stepper not to depend on `@angular/forms` under the assumption that our limited `FormControl` interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the `stepControl` type to avoid the breaking change.
Fixesangular#15462.
@crisbeto
crisbetoforce-pushed the 15462/stepper-breaking-change branch from ba77f73 to d16d8cfCompareMarch 13, 2019 18:19
@mmalerba
mmalerba merged commit a146499 into angular:masterMar 13, 2019
mmalerba pushed a commit that referenced this pull request Mar 18, 2019
In #15134 we reworked the stepper not to depend on `@angular/forms` under the assumption that our limited `FormControl` interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the `stepControl` type to avoid the breaking change.
Fixes#15462.
@biltongza

biltongza commented Apr 12, 2019

Copy link
Copy Markdown

This is still a breaking change for us since FormControlLike is not exported. We depended on this being AbstractControl in one of our methods to mark all child controls as touched, and now the only option we really have is to cast the FormControlLike to AbstractControl. Is that the recommended option?

Suresh918 pushed a commit to Suresh918/material2 that referenced this pull request Apr 15, 2019
In angular#15134 we reworked the stepper not to depend on `@angular/forms` under the assumption that our limited `FormControl` interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the `stepControl` type to avoid the breaking change.
Fixesangular#15462.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License AgreementP2The issue is important to a large percentage of users, with a workaroundtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7.3.4 is not a patch

4 participants

@crisbeto@biltongza@googlebot@mmalerba