Skip to content

fix(tooltip): render style values in ngOnInit instead of the constructor - #15469

Merged
mmalerba merged 1 commit into
angular:masterfrom
matsko:fix_tooltip_ve
Mar 14, 2019
Merged

fix(tooltip): render style values in ngOnInit instead of the constructor#15469
mmalerba merged 1 commit into
angular:masterfrom
matsko:fix_tooltip_ve

Conversation

@matsko

Copy link
Copy Markdown
Contributor

Due to changes in Angular it's not logical to change style values
directly within a constructor. This should be done instead within
the ngOnInit lifecycle hook.

This patch changes this behavior for the ToolTip component.

@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 13, 2019
@mmalerbammalerba added the P2 The issue is important to a large percentage of users, with a workaround label Mar 13, 2019

@crisbetocrisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the CI is sorted out.

Due to changes in Angular it's not logical to change style values
directly within a constructor. This should be done instead within
the ngOnInit lifecycle hook.
This patch changes this behavior for the `ToolTip` component.
@mmalerbammalerba added the action: merge The PR is ready for merge by the caretaker label Mar 13, 2019
@ngbot

ngbotBot commented Mar 13, 2019

Copy link
Copy Markdown

I see that you just added the pr: merge ready label, but the following checks are still failing:
failure status "ci/circleci: api_golden_checks" is failing
failure status "ci/circleci: bazel_build_test" is failing
pending missing required labels: target: *

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba
mmalerba merged commit 59818d1 into angular:masterMar 14, 2019
Suresh918 pushed a commit to Suresh918/material2 that referenced this pull request Apr 15, 2019
…tor (angular#15469)
Due to changes in Angular it's not logical to change style values
directly within a constructor. This should be done instead within
the ngOnInit lifecycle hook.
This patch changes this behavior for the `ToolTip` component.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License AgreementP2The issue is important to a large percentage of users, with a workaround

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@matsko@crisbeto@googlebot@mmalerba