Skip to content

fix(stepper): content not being rendered out initially with ivy - #15485

Merged
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:stepper-static-query
Mar 15, 2019
Merged

fix(stepper): content not being rendered out initially with ivy#15485
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:stepper-static-query

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Fixes the stepper's content not being shown on the first render with Ivy, because we assume that the template with be present on init.

Fixes the stepper's content not being shown on the first render with Ivy, because we assume that the template with be present on init.
@crisbetocrisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Mar 14, 2019
@crisbeto
crisbeto requested a review from mmalerba as a code ownerMarch 14, 2019 18:56
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 14, 2019
@mmalerbammalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 14, 2019
@ngbot

ngbotBot commented Mar 14, 2019

Copy link
Copy Markdown

I see that you just added the pr: merge ready label, but the following checks are still failing:
failure status "branch-manager" is failing
pending status "ci/circleci: tests_browserstack" is pending
pending status "ci/circleci: tests_local_browsers" is pending
pending status "ci/circleci: tests_saucelabs" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba
mmalerba merged commit 876727d into angular:masterMar 15, 2019
mmalerba pushed a commit that referenced this pull request Mar 18, 2019
Fixes the stepper's content not being shown on the first render with Ivy, because we assume that the template with be present on init.
@mmalerbammalerba added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Mar 18, 2019
Suresh918 pushed a commit to Suresh918/material2 that referenced this pull request Apr 15, 2019
…lar#15485)
Fixes the stepper's content not being shown on the first render with Ivy, because we assume that the template with be present on init.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License AgreementP2The issue is important to a large percentage of users, with a workaroundtarget: majorThis PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto@googlebot@mmalerba