Skip to content

fix(schematics): ensure project "style" and "skipTests" options are respected - #15513

Merged
andrewseguin merged 1 commit into
angular:masterfrom
devversion:fix/schematics-not-working-latest-cli
Mar 22, 2019
Merged

fix(schematics): ensure project "style" and "skipTests" options are respected#15513
andrewseguin merged 1 commit into
angular:masterfrom
devversion:fix/schematics-not-working-latest-cli

Conversation

@devversion

Copy link
Copy Markdown
Member

With angular/angular-cli@a12a4e0, the CLI made the option naming consistent. Since the
default schematic are therefore named differently, we need to update our logic to
work with the old option name and the new option name.

Fixes#15502

@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 17, 2019
@devversion
devversionforce-pushed the fix/schematics-not-working-latest-cli branch 3 times, most recently from 2c0c903 to 46863abCompareMarch 17, 2019 22:29
@devversiondevversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Mar 17, 2019
@devversion

Copy link
Copy Markdown
MemberAuthor

cc. @Splaktar

@devversion
devversion marked this pull request as ready for review March 18, 2019 16:23

@SplaktarSplaktar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbetocrisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbetocrisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 20, 2019
@ngbot

This comment has been minimized.

Comment threadsrc/lib/schematics/ng-generate/nav/schema.json Outdated
…espected
With angular/angular-cli@a12a4e0, the CLI made the
option naming consistent. Since the default schematic are therefore named differently, we need to update our logic
to work with the old option name and the new option name.
Fixesangular#15502
@devversion
devversionforce-pushed the fix/schematics-not-working-latest-cli branch from 46863ab to eff37feCompareMarch 20, 2019 11:48
@andrewseguin
andrewseguin merged commit fe6629a into angular:masterMar 22, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

schematics: CSS files generated in Angular CLI project using SCSS styles

7 participants

@devversion@Splaktar@crisbeto@alan-agius4@jelbourn@googlebot@andrewseguin