Uh oh!
There was an error while loading. Please reload this page.
fix(dialog): aria-label not being removed if text content changes after init - #15590
fix(dialog): aria-label not being removed if text content changes after init#15590crisbeto wants to merge 1 commit into
Conversation
…er init Currently we set an `aria-label` on the `mat-dialog-close` button if it's an icon button or it doesn't have text, however it wasn't accounting for the case where the text comes in at a later point. Fixesangular#15542.
90df4c6 to
de963ddCompare
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
It's almost hilarious how much code it takes to do this.
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
crisbeto
commented
Mar 27, 2019
While I was doing it I was thinking that it might be better if we removed the default |
crisbeto
commented
Mar 29, 2019
Closing in favor of #15654. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently we set an
aria-labelon themat-dialog-closebutton if it's an icon button or it doesn't have text, however it wasn't accounting for the case where the text comes in at a later point.Fixes#15542.