Uh oh!
There was an error while loading. Please reload this page.
fix(button-toggle): clear name from host node - #15668
Merged
Merged
Conversation
jelbourn
commented
May 13, 2019
Contributor
@crisbeto this passes presubmit, just needs a rebase |
Along the same lines as angular#15368. Since we forward the `name` to the underlying native inside a button toggle, otherwise the results from `document.getElementsByName` or Protractor's `By.name` might be thrown off.
crisbetoforce-pushed
the
button-toggle-host-name
branch
from
May 13, 2019 16:09
f09df73 to
b8735c0Comparecrisbeto
commented
May 13, 2019
MemberAuthor
Rebased. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Along the same lines as #15368. Since we forward the
nameto the underlying native inside a button toggle, otherwise the results fromdocument.getElementsByNameor Protractor'sBy.namemight be thrown off.