Skip to content

feat(material-experimental/checkbox): Add test harnesses for both versions of mat-checkbox - #16334

Merged
jelbourn merged 8 commits into
angular:masterfrom
mmalerba:harness-cb
Jun 21, 2019
Merged

feat(material-experimental/checkbox): Add test harnesses for both versions of mat-checkbox#16334
jelbourn merged 8 commits into
angular:masterfrom
mmalerba:harness-cb

Conversation

@mmalerba

@mmalerbammalerba commented Jun 19, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 19, 2019
crisbeto
crisbeto approved these changes Jun 20, 2019
View reviewed changes

@crisbetocrisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadsrc/cdk-experimental/testing/protractor/protractor-element.ts
jelbourn
jelbourn reviewed Jun 20, 2019
View reviewed changes
Comment threadsrc/material-experimental/mdc-checkbox/harness/checkbox-harness.spec.ts
Comment threadsrc/material-experimental/mdc-checkbox/harness/checkbox-harness.ts Outdated
Comment threadsrc/material-experimental/mdc-checkbox/harness/checkbox-harness.ts
Comment threadsrc/material-experimental/mdc-checkbox/harness/checkbox-harness.ts Outdated
Comment threadsrc/material-experimental/mdc-checkbox/harness/checkbox-harness.spec.ts
@mmalerbammalerba added pr: merge safe target: patch This PR is targeted for the next patch release labels Jun 20, 2019
jelbourn
jelbourn approved these changes Jun 21, 2019
View reviewed changes

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jun 21, 2019
@jelbourn
jelbourn merged commit 7398c9a into angular:masterJun 21, 2019
andrewseguin pushed a commit that referenced this pull request Jul 2, 2019
@mmalerba@andrewseguin
feat(material-experimental/checkbox): Add test harnesses for both ve…
1f303ab
…rsions of mat-checkbox (#16334)
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 11, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 11, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbetocrisbetocrisbeto approved these changes
@devversiondevversionAwaiting requested review from devversion
+1 more reviewer
@jelbournjelbournjelbourn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jelbournjelbourn

@crisbetocrisbeto

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreementtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmalerba@jelbourn@crisbeto@googlebot