Skip to content

fix(menu): restore focus immediately when menu is closed - #16960

Merged
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:16954/menu-focus-restoration
Sep 9, 2019
Merged

fix(menu): restore focus immediately when menu is closed#16960
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:16954/menu-focus-restoration

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Currently in some cases we restore focus immediately and in others we wait for the exit animation to finish (when using matMenuContent) because the focus restoration logic is coupled to the menu cleanup. This means that if multiple animations overlap, we could end up restoring focus to the wrong element. These changes switch to restoring focus immediately in all cases.

Fixes#16954.

@crisbetocrisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Sep 3, 2019
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 3, 2019
@Harpush

Copy link
Copy Markdown

@crisbeto is it related to #16502 (comment) by any chance?

@crisbeto

Copy link
Copy Markdown
MemberAuthor

@Harpush this is purely for when focus is restored when a menu is closed, it doesn't have anything to do with #16502.

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 3, 2019
@ngbot

ngbotBot commented Sep 3, 2019

Copy link
Copy Markdown

I see that you just added the pr: merge ready label, but the following checks are still failing:
failure status "ci/circleci: tests_browserstack" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Currently in some cases we restore focus immediately and in others we wait for the exit animation to finish (when using `matMenuContent`) because the focus restoration logic is coupled to the menu cleanup. This means that if multiple animations overlap, we could end up restoring focus to the wrong element. These changes switch to restoring focus immediately in all cases.
Fixesangular#16954.
@crisbeto
crisbetoforce-pushed the 16954/menu-focus-restoration branch from f9e875a to dc92e19CompareSeptember 7, 2019 14:31
@jelbourn
jelbourn merged commit bfa1853 into angular:masterSep 9, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Oct 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License AgreementP3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenttarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Menu with matMenuContent breaks hover behaviour

4 participants

@crisbeto@Harpush@jelbourn@googlebot