fix(material/select): disabled state out of sync when swapping form group with a disabled one by crisbeto · Pull Request #17872 · angular/components

crisbeto · 2019-12-04T12:40:00Z

Fixes the disabled state of a mat-select falling out of sync with its form control if the control's group is swapped out with one that is disabled on init.

Fixes#17860.

jelbourn

LGTM

…rm group with a disabled one Related to angular#17872. Ensures that the chip list's disabled state is in sync with its form control, if the control is swapped out with a disabled one.

…rm group with a disabled one (#17993) Related to #17872. Ensures that the chip list's disabled state is in sync with its form control, if the control is swapped out with a disabled one.

…rm group with a disabled one (#17993) Related to #17872. Ensures that the chip list's disabled state is in sync with its form control, if the control is swapped out with a disabled one. (cherry picked from commit c67337b)

…rm group with a disabled one (angular#17993) Related to angular#17872. Ensures that the chip list's disabled state is in sync with its form control, if the control is swapped out with a disabled one.

jraadt · 2021-10-02T16:31:28Z

Is there a reason this little PR hasn't been merged yet?

…roup with a disabled one Fixes the disabled state of a `mat-select` falling out of sync with its form control if the control's group is swapped out with one that is disabled on init. Fixesangular#17860.

…roup with a disabled one (#17872) Fixes the disabled state of a `mat-select` falling out of sync with its form control if the control's group is swapped out with one that is disabled on init. Fixes#17860. (cherry picked from commit 723a821)

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.2.5/13.2.6) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`13.2.5` -> `13.2.6`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.2.5/13.2.6) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v13.2.6`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#1326-suede-spaghetti-2022-03-09) [Compare Source](angular/components@13.2.5...13.2.6) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [39929a815d](angular/components@39929a8) | fix | **overlay:** backdrop timeouts not being cleared in some cases ([#23972](angular/components#23972)) | | [2f2b0c7cf4](angular/components@2f2b0c7) | fix | **testing:** dispatch mouseover and mouseout events in UnitTestElement ([#24490](angular/components#24490)) | | [edca54f2d0](angular/components@edca54f) | fix | **testing:** require at least one argument for locator functions ([#23619](angular/components#23619)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [c4993ac171](angular/components@c4993ac) | fix | **button:** avoid setting a tabindex on all link buttons ([#22901](angular/components#22901)) | | [c47d30e0e5](angular/components@c47d30e) | fix | **dialog:** don't wait for animation before moving focus ([#24121](angular/components#24121)) | | [70b8248568](angular/components@70b8248) | fix | **expansion:** able to tab into descendants with visibility while closed ([#24045](angular/components#24045)) | | [d22d73ab8d](angular/components@d22d73a) | fix | **select:** disabled state out of sync when swapping form group with a disabled one ([#17872](angular/components#17872)) | | [911d6b71d4](angular/components@911d6b7) | fix | **slide-toggle:** clear name from host node ([#15505](angular/components#15505)) | | [4b5363d160](angular/components@4b5363d) | fix | **tooltip:** decouple removal logic from change detection ([#19432](angular/components#19432)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [8414646d79](angular/components@8414646) | fix | **mdc-card:** remove extra margin if header doesn't have an avatar ([#19072](angular/components#19072)) | | [f66486dc5b](angular/components@f66486d) | fix | **mdc-slider:** fix a few null pointer exceptions ([#23659](angular/components#23659)) | ##### multiple | Commit | Type | Description | | -- | -- | -- | | [6ee0089ce6](angular/components@6ee0089) | fix | don't block child component animations on open ([#24529](angular/components#24529)) | #### Special Thanks Andrew Seguin, Jeri Peier, Kristiyan Kostadinov and Paul Gschwendtner  </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1214 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2022-04-03T00:03:58Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 4, 2019

crisbeto assigned jelbourn Dec 4, 2019

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 4, 2019

jelbourn approved these changes Dec 4, 2019
View reviewed changes

jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 4, 2019

crisbeto mentioned this pull request Dec 17, 2019
Disable state for ReactiveForms not working correctly #17985
Closed

crisbeto mentioned this pull request Dec 17, 2019
fix(chips): chip list disabled state out of sync when swapping out form group with a disabled one #17993
Merged

snyk-bot mentioned this pull request May 3, 2020
[Snyk] Upgrade: @angular/cdk, @angular/material, @angular/material-moment-adapter lingounet/testage#29
Merged

mmalerba removed the lgtm label Jul 31, 2020

andrewseguin added the needs rebase label Aug 14, 2020

crisbeto removed the needs rebase label Aug 21, 2020

crisbeto force-pushed the 17860/select-form-group-swap branch from 02e1c57 to cf377feCompare August 21, 2020 21:21

crisbeto changed the title ~~fix(select): disabled state out of sync when swapping form group with a disabled one~~fix(material/select): disabled state out of sync when swapping form group with a disabled oneNov 26, 2020

crisbeto force-pushed the 17860/select-form-group-swap branch from cf377fe to a1fffb5Compare November 26, 2020 17:47

crisbeto force-pushed the 17860/select-form-group-swap branch from a1fffb5 to 46a247dCompare December 6, 2020 16:00

crisbeto force-pushed the 17860/select-form-group-swap branch from 46a247d to ef20461Compare January 7, 2021 13:15

andrewseguin added needs rebase and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Dec 28, 2021

crisbeto removed the needs rebase label Mar 3, 2022

crisbeto force-pushed the 17860/select-form-group-swap branch from ef20461 to 7a9b1dcCompare March 3, 2022 07:49

fix(material/select): disabled state out of sync when swapping form g…
e921ebf
…roup with a disabled one Fixes the disabled state of a `mat-select` falling out of sync with its form control if the control's group is swapped out with one that is disabled on init. Fixesangular#17860.

crisbeto force-pushed the 17860/select-form-group-swap branch from 7a9b1dc to e921ebfCompare March 3, 2022 12:37

crisbeto merged commit 723a821 into angular:masterMar 3, 2022

sync-by-unitoBot mentioned this pull request Mar 14, 2022
build(deps): bump @angular/cdk from 12.2.4 to 13.2.6 numbersprotocol/capture-cam#1370
Closed

sync-by-unitoBot mentioned this pull request Mar 22, 2022
build(deps): bump @angular/cdk from 12.2.4 to 13.3.0 numbersprotocol/capture-cam#1403
Closed

angular-automatic-lock-botBot locked and limited conversation to collaborators Apr 3, 2022

Navigation Menu

Uh oh!

fix(material/select): disabled state out of sync when swapping form group with a disabled one - #17872

fix(material/select): disabled state out of sync when swapping form group with a disabled one#17872
crisbeto merged 1 commit into
angular:masterfrom
crisbeto:17860/select-form-group-swap

crisbeto commented Dec 4, 2019

Uh oh!

jelbourn left a comment

Uh oh!

jraadt commented Oct 2, 2021

Uh oh!

angular-automatic-lock-botBot commented Apr 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

crisbeto commented Dec 4, 2019

Uh oh!

jelbourn left a comment

Choose a reason for hiding this comment

Uh oh!

jraadt commented Oct 2, 2021

Uh oh!

angular-automatic-lock-botBot commented Apr 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants