Skip to content

fix(material/radio): incorrect text color when placed inside an overlay with a dark theme - #19113

Closed
crisbeto wants to merge 1 commit into
angular:masterfrom
crisbeto:radio-dark-theme-text-color
Closed

fix(material/radio): incorrect text color when placed inside an overlay with a dark theme#19113
crisbeto wants to merge 1 commit into
angular:masterfrom
crisbeto:radio-dark-theme-text-color

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Fixes a similar issue to #18742. The radio button inherits its text color from the closest parent which may not be correct once the element is moved out into an overlay.

@crisbetocrisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Apr 19, 2020
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 19, 2020
@devversiondevversion added lgtm action: merge The PR is ready for merge by the caretaker labels Apr 20, 2020

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerbammalerba removed the lgtm label Jul 31, 2020
@crisbetocrisbeto changed the title fix(radio): incorrect text color when placed inside an overlay with a dark themefix(material/radio): incorrect text color when placed inside an overlay with a dark themeJun 9, 2021
…ay with a dark theme
Fixes a similar issue to angular#18742. The radio button inherits its text color from the closest parent which may not be correct once the element is moved out into an overlay.
@crisbeto
crisbetoforce-pushed the radio-dark-theme-text-color branch from 25a6c9b to 47936ecCompareJune 9, 2021 18:57
@andrewseguinandrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@crisbeto

Copy link
Copy Markdown
MemberAuthor

Closing this, because similar fixes for the checkbox and slide toggle ended up being reverted, because they were problematic internally.

@crisbetocrisbeto closed this Mar 4, 2022
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Apr 4, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakerP3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenttarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@crisbeto@jelbourn@devversion@googlebot@mmalerba@andrewseguin