Skip to content

Test CLA webhook - #2

Closed
jelbourn wants to merge 2 commits into
angular:masterfrom
jelbourn:async-test-bug
Closed

Test CLA webhook#2
jelbourn wants to merge 2 commits into
angular:masterfrom
jelbourn:async-test-bug

Conversation

@jelbourn

@jelbournjelbourn commented Jan 8, 2016

Copy link
Copy Markdown
Contributor

Test CLA webhook

@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 8, 2016
@jelbournjelbourn closed this Jan 8, 2016
@hanslhansl mentioned this pull request Mar 23, 2016
Merged
@jelbourn
jelbourn deleted the async-test-bug branch May 19, 2016 16:56
This was referenced Sep 30, 2016
Closed
Closed
@mLairdmLaird mentioned this pull request Dec 22, 2016
Closed
@GanimGanim mentioned this pull request Jan 18, 2017
Closed
sllethe added a commit to sllethe/material2 that referenced this pull request Jul 25, 2017
@sllethe
# This is a combination of 7 commits.
524f1b1
# This is the 1st commit message:
# This is a combination of 3 commits.
# This is the 1st commit message:
# This is a combination of 6 commits.
# This is the 1st commit message:
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
fix
delete sticky-header demo part from this branch
# This is the commit message angular#2:
revert firebase file
# This is the commit message angular#3:
change code according to comments in PR
# This is the commit message angular#4:
revert firbaserc
# This is the commit message angular#5:
revert demo-app.ts
# This is the commit message angular#6:
revert routes.ts
# This is the commit message angular#2:
change
# This is the commit message angular#3:
fix the problem of : 'this.stickyParent' might be 'null'
# This is the commit message angular#2:
change doc
# This is the commit message angular#3:
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
# This is the commit message angular#4:
Added prefix 'mat-' for CSS class
# This is the commit message angular#5:
Delete 'public' before variables
# This is the commit message angular#6:
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
# This is the commit message angular#7:
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
sllethe added a commit to sllethe/material2 that referenced this pull request Jul 25, 2017
@sllethe
# This is a combination of 7 commits.
52c6bce
# This is the 1st commit message:
# This is a combination of 3 commits.
# This is the 1st commit message:
# This is a combination of 6 commits.
# This is the 1st commit message:
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
fix
delete sticky-header demo part from this branch
# This is the commit message angular#2:
revert firebase file
# This is the commit message angular#3:
change code according to comments in PR
# This is the commit message angular#4:
revert firbaserc
# This is the commit message angular#5:
revert demo-app.ts
# This is the commit message angular#6:
revert routes.ts
# This is the commit message angular#2:
change
# This is the commit message angular#3:
fix the problem of : 'this.stickyParent' might be 'null'
# This is the commit message angular#2:
change doc
# This is the commit message angular#3:
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
# This is the commit message angular#4:
Added prefix 'mat-' for CSS class
# This is the commit message angular#5:
Delete 'public' before variables
# This is the commit message angular#6:
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
# This is the commit message angular#7:
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
sllethe added a commit to sllethe/material2 that referenced this pull request Jul 26, 2017
@sllethe
# This is a combination of 9 commits.
ff4c1a4
# This is the 1st commit message:
# This is a combination of 11 commits.
# This is the 1st commit message:
add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
# This is the commit message angular#2:
fix
# This is the commit message angular#3:
delete sticky-header demo part from this branch
# This is the commit message angular#4:
revert firebase file
# This is the commit message angular#5:
change code according to comments in PR
# This is the commit message angular#6:
revert firbaserc
# This is the commit message angular#7:
revert demo-app.ts
# This is the commit message angular#8:
revert routes.ts
# This is the commit message angular#9:
revert demo-app-module.ts
# This is the commit message angular#10:
change
# This is the commit message angular#11:
fix the problem of : 'this.stickyParent' might be 'null'
# This is the commit message angular#2:
change doc
# This is the commit message angular#3:
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
# This is the commit message angular#4:
Added prefix 'mat-' for CSS class
# This is the commit message angular#5:
Delete 'public' before variables
# This is the commit message angular#6:
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
# This is the commit message angular#7:
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
# This is the commit message angular#8:
Added docs for all variables
# This is the commit message angular#9:
extract 'generate CSS style'
sllethe added a commit to sllethe/material2 that referenced this pull request Jul 26, 2017
@sllethe
# This is a combination of 5 commits.
096b553
# This is the 1st commit message:
add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
fix
delete sticky-header demo part from this branch
revert firebase file
change code according to comments in PR
revert firbaserc
revert demo-app.ts
revert routes.ts
revert demo-app-module.ts
change
fix the problem of : 'this.stickyParent' might be 'null'
change doc
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
Added prefix 'mat-' for CSS class
Delete 'public' before variables
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
Added docs for all variables
extract 'generate CSS style'
created a generateStyleCSS() function, let it be responsible for generating all those CSS styles.
reformat
add debounce to solve 'getBoundingClientRect() cause slow down' problem.
add position:sticky and check whether browser support it. If not , use the naive implementation
removed unused import
Removed unused 'scrollableRegion' and 'parentRegion'
removed commented lines
default public
Add comments about why setting style top and position for iPhone and not IE. And extract detectBrowser() as a new function
format
consider all circumstances of browser.
use "===" instead of '=='
make 'navigator.userAgent.toLocaleLowerCase()' a local variable
optimize
Added comments on const 'STICK_START_CLASS' and 'STICK_END_CLASS'.
change their content to cdk-sticky-header-start and cdk-sticky-header-end
Added comments for STICK_START_CLASS and STICK_END_CLASS.
Changed the format of one-line JsDoc
unsubscribe sbscriptions onDestory
Use what modernizr does on compatibility instead of get the browser version directly.
add 'padding' and 'stickyRegionHeight' variables to avoid calling 'getComputedStyle()' too many times (which is expensive).
move docs above @directive
removed the underscore in'_element: ElementRef',
expand 'reg' to 'region'
use 'if (this.isIE)' instead of 'if(this.isIE === true)'
added more newlines between params in 'generateCssStyle()' function to make it easier to understand.
Added reference link to Modernizer in docs of getSupportList()
Deleted "_supportList" variable
renamed 'isIE' to 'isStickyPositionSupported', and removed extra space before Observable
Set debounce time as a const variable
Added docs for 'const DEBOUNCE_TIME: number = 5;'
Changed ' if(this.stickyParent == null)' to ' if(!this.stickyParent)'
Removed the @PARAM and @returns and make sure the types are correct in the function signature in 'generateCssStyle(...)' function
Added docs for `isStickyPositionSupported` variable
changed '+=' to '=' of 'stickyText' in getSupportList() function
nit added " " between 'if' and '('
nit
Added comments
deleted unused import
change comments
optimize comments
deleted unnecessary global variables(padding and stickyRegionHeight)
Added check whether we are on browser
Array<string> to string[]
test?
try to reopen the old PR
fix after rebase
revert list.ts
test
test 222
revert demo
revert list.ts second time
Move code to 'src/cdk'
revert 'move code to 'src/cdk'' , it should be done in a new PR
revert
avoid calling 'getComputedStyle()' too many times.
rename as sticky-header.ts
# This is the commit message angular#2:
imported PlatformModule
# This is the commit message angular#3:
Add blank lines between these top-level symbol
# This is the commit message angular#4:
make '_isStickyPositionSupported' private
# This is the commit message angular#5:
Changed the originalCSS to private and use '{} as CSSStyleDeclaration' instead of ''any.
sllethe added a commit to sllethe/material2 that referenced this pull request Jul 26, 2017
@sllethe
# This is a combination of 16 commits.
2848f2c
# This is the 1st commit message:
# This is a combination of 10 commits.
# This is the 1st commit message:
add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
fix
delete sticky-header demo part from this branch
revert firebase file
change code according to comments in PR
revert firbaserc
revert demo-app.ts
revert routes.ts
revert demo-app-module.ts
change
fix the problem of : 'this.stickyParent' might be 'null'
change doc
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
Added prefix 'mat-' for CSS class
Delete 'public' before variables
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
Added docs for all variables
extract 'generate CSS style'
created a generateStyleCSS() function, let it be responsible for generating all those CSS styles.
reformat
add debounce to solve 'getBoundingClientRect() cause slow down' problem.
add position:sticky and check whether browser support it. If not , use the naive implementation
removed unused import
Removed unused 'scrollableRegion' and 'parentRegion'
removed commented lines
default public
Add comments about why setting style top and position for iPhone and not IE. And extract detectBrowser() as a new function
format
consider all circumstances of browser.
use "===" instead of '=='
make 'navigator.userAgent.toLocaleLowerCase()' a local variable
optimize
Added comments on const 'STICK_START_CLASS' and 'STICK_END_CLASS'.
change their content to cdk-sticky-header-start and cdk-sticky-header-end
Added comments for STICK_START_CLASS and STICK_END_CLASS.
Changed the format of one-line JsDoc
unsubscribe sbscriptions onDestory
Use what modernizr does on compatibility instead of get the browser version directly.
add 'padding' and 'stickyRegionHeight' variables to avoid calling 'getComputedStyle()' too many times (which is expensive).
move docs above @directive
removed the underscore in'_element: ElementRef',
expand 'reg' to 'region'
use 'if (this.isIE)' instead of 'if(this.isIE === true)'
added more newlines between params in 'generateCssStyle()' function to make it easier to understand.
Added reference link to Modernizer in docs of getSupportList()
Deleted "_supportList" variable
renamed 'isIE' to 'isStickyPositionSupported', and removed extra space before Observable
Set debounce time as a const variable
Added docs for 'const DEBOUNCE_TIME: number = 5;'
Changed ' if(this.stickyParent == null)' to ' if(!this.stickyParent)'
Removed the @PARAM and @returns and make sure the types are correct in the function signature in 'generateCssStyle(...)' function
Added docs for `isStickyPositionSupported` variable
changed '+=' to '=' of 'stickyText' in getSupportList() function
nit added " " between 'if' and '('
nit
Added comments
deleted unused import
change comments
optimize comments
deleted unnecessary global variables(padding and stickyRegionHeight)
Added check whether we are on browser
Array<string> to string[]
test?
try to reopen the old PR
fix after rebase
revert list.ts
test
test 222
revert demo
revert list.ts second time
Move code to 'src/cdk'
revert 'move code to 'src/cdk'' , it should be done in a new PR
revert
avoid calling 'getComputedStyle()' too many times.
rename as sticky-header.ts
imported PlatformModule
Add blank lines between these top-level symbol
make '_isStickyPositionSupported' private
Changed the originalCSS to private and use '{} as CSSStyleDeclaration' instead of ''any.
Rename '_containerStart' to '_stickyRegionTop'
# This is the commit message angular#2:
rename
# This is the commit message angular#3:
optimize discription for '_stickyRegionBottomThreshold'
# This is the commit message angular#4:
private _originalStyles = {
position: '',
top: '',
right: '',
left: '',
bottom: '',
width: '',
zIndex: ''};
# This is the commit message angular#5:
Deleted 'generateCssStyle()' and 'getCssNumber()' function
# This is the commit message angular#6:
Deleted 'getCssValue()' function
# This is the commit message angular#7:
fix CSSStyleDeclaration
# This is the commit message angular#8:
change sticky width to 'this.upperScrollableContainer.clientWidth'
# This is the commit message angular#9:
fix
# This is the commit message angular#10:
nit
# This is the commit message angular#2:
Added the 'isPositionStickySupported() ' function to src/cdk/platform/features.ts.
Consume that function in this component and just always use both the webkit and unprefixed styles.
# This is the commit message angular#3:
nit
# This is the commit message angular#4:
nit
# This is the commit message angular#5:
update doc 'Debounce time in milliseconds for events that affect the sticky positioning (e.g. scroll, resize, touch move). Set as 5 milliseconds which is the highest delay that doesn't drastically affect the positioning adversely.'
# This is the commit message angular#6:
changed the doc to '/** z-index to be applied to the sticky header (default is 10). */'
# This is the commit message angular#7:
fix tslint error
# This is the commit message angular#8:
for comment 'Can you evaluate each method to make sure their accessor privacy is right? E.g. see which functions need to be public, private, static, etc'
# This is the commit message angular#9:
Deleted variable 'elemHeight'
# This is the commit message angular#10:
Chaned to 'if (!this.stickyParent)'
# This is the commit message angular#11:
Simplified Docs for 'sticker()'.
# This is the commit message angular#12:
set 'defineRestriction()' function to private
# This is the commit message angular#13:
use 'RxChain'
# This is the commit message angular#14:
deleted unused 'tableModule' in modules.ts
# This is the commit message angular#15:
rename to '_isPositionStickySupported'
# This is the commit message angular#16:
Use // for comments, /* */ for docs
sllethe added a commit that referenced this pull request Aug 1, 2017
@sllethe
Sticky header demo code (#6033)
54b6c84
* add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
fix
delete sticky-header demo part from this branch
revert firebase file
change code according to comments in PR
revert firbaserc
revert demo-app.ts
revert routes.ts
revert demo-app-module.ts
change
fix the problem of : 'this.stickyParent' might be 'null'
change doc
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
Added prefix 'mat-' for CSS class
Delete 'public' before variables
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
Added docs for all variables
extract 'generate CSS style'
created a generateStyleCSS() function, let it be responsible for generating all those CSS styles.
reformat
add debounce to solve 'getBoundingClientRect() cause slow down' problem.
add position:sticky and check whether browser support it. If not , use the naive implementation
Removed unused 'scrollableRegion' and 'parentRegion'
removed commented lines
default public
Add comments about why setting style top and position for iPhone and not IE. And extract detectBrowser() as a new function
format
consider all circumstances of browser.
use "===" instead of '=='
make 'navigator.userAgent.toLocaleLowerCase()' a local variable
optimize
Added comments on const 'STICK_START_CLASS' and 'STICK_END_CLASS'.
change their content to cdk-sticky-header-start and cdk-sticky-header-end
Added comments for STICK_START_CLASS and STICK_END_CLASS.
Changed the format of one-line JsDoc
unsubscribe sbscriptions onDestory
Use what modernizr does on compatibility instead of get the browser version directly.
add 'padding' and 'stickyRegionHeight' variables to avoid calling 'getComputedStyle()' too many times (which is expensive).
move docs above @directive
removed the underscore in'_element: ElementRef',
expand 'reg' to 'region'
use 'if (this.isIE)' instead of 'if(this.isIE === true)'
added more newlines between params in 'generateCssStyle()' function to make it easier to understand.
Added reference link to Modernizer in docs of getSupportList()
Deleted "_supportList" variable
renamed 'isIE' to 'isStickyPositionSupported', and removed extra space before Observable
Set debounce time as a const variable
Added docs for 'const DEBOUNCE_TIME: number = 5;'
Changed ' if(this.stickyParent == null)' to ' if(!this.stickyParent)'
Removed the @PARAM and @returns and make sure the types are correct in the function signature in 'generateCssStyle(...)' function
Added docs for `isStickyPositionSupported` variable
changed '+=' to '=' of 'stickyText' in getSupportList() function
nit added " " between 'if' and '('
nit
Added comments
deleted unused import
change comments
optimize comments
deleted unnecessary global variables(padding and stickyRegionHeight)
Added check whether we are on browser
Array<string> to string[]
test?
try to reopen the old PR
fix after rebase
revert list.ts
test
test 222
revert demo
revert list.ts second time
Move code to 'src/cdk'
revert 'move code to 'src/cdk'' , it should be done in a new PR
revert
avoid calling 'getComputedStyle()' too many times.
rename as sticky-header.ts
Add blank lines between these top-level symbol
make '_isStickyPositionSupported' private
Changed the originalCSS to private and use '{} as CSSStyleDeclaration' instead of ''any.
Rename '_containerStart' to '_stickyRegionTop'
rename
optimize discription for '_stickyRegionBottomThreshold'
private _originalStyles = {
position: '',
top: '',
right: '',
left: '',
bottom: '',
width: '',
zIndex: ''};
Deleted 'generateCssStyle()' and 'getCssNumber()' function
Deleted 'getCssValue()' function
fix CSSStyleDeclaration
change sticky width to 'this.upperScrollableContainer.clientWidth'
fix
nit
Added the 'isPositionStickySupported() ' function to src/cdk/platform/features.ts.
Consume that function in this component and just always use both the webkit and unprefixed styles.
nit
update doc 'Debounce time in milliseconds for events that affect the sticky positioning (e.g. scroll, resize, touch move). Set as 5 milliseconds which is the highest delay that doesn't drastically affect the positioning adversely.'
changed the doc to '/** z-index to be applied to the sticky header (default is 10). */'
fix tslint error
for comment 'Can you evaluate each method to make sure their accessor privacy is right? E.g. see which functions need to be public, private, static, etc'
Deleted variable 'elemHeight'
Chaned to 'if (!this.stickyParent)'
Simplified Docs for 'sticker()'.
set 'defineRestriction()' function to private
use 'RxChain'
rename to '_isPositionStickySupported'
Use // for comments, /* */ for docs
@angular/cdk
rename : values -> headerStyles
Move closing brace to the next line
optimized: [this._onScrollSubscription, this._onScrollSubscription, this._onResizeSubscription]
.forEach(s => s && s.unsubscribe());
You should be able to do just '0' instead of '0px'
Format like TODO(sllethe): ...
private _attachEventListeners? Add a description like "Add listeners for events that affect sticky positioning."
optimize doc
Rename 'defineRestrictions' to '_measureStickyRegionBounds'
rename: private _resetElementStyles
let stuckRight: any = this.upperScrollableContainer.getBoundingClientRect().right;
chaned 'any' to 'number'
nit
change doc '/**
* Unsticks the header so that it goes back to scrolling normally.
*
* This should be called when the element reaches the bottom of its cdkStickyRegion so that it
* smoothly scrolls out of view as the next sticky-header moves in.
*/'
_unstuckElement -> _unstickElement
rename 'sticker()' to '_applyStickyPositionStyles()'
rename 'defineRestrictionsAndStick()' to '_updateStickyPositioning()'
Add demo to sticky-header
add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
* # This is a combination of 7 commits.
# This is the 1st commit message:
# This is a combination of 3 commits.
# This is the 1st commit message:
# This is a combination of 6 commits.
# This is the 1st commit message:
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
fix
delete sticky-header demo part from this branch
# This is the commit message #2:
revert firebase file
# This is the commit message #3:
change code according to comments in PR
# This is the commit message #4:
revert firbaserc
# This is the commit message #5:
revert demo-app.ts
# This is the commit message #6:
revert routes.ts
# This is the commit message #2:
change
# This is the commit message #3:
fix the problem of : 'this.stickyParent' might be 'null'
# This is the commit message #2:
change doc
# This is the commit message #3:
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
# This is the commit message #4:
Added prefix 'mat-' for CSS class
# This is the commit message #5:
Delete 'public' before variables
# This is the commit message #6:
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
# This is the commit message #7:
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
* refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
fix
delete sticky-header demo part from this branch
revert firebase file
change code according to comments in PR
revert firbaserc
revert demo-app.ts
revert routes.ts
change
fix the problem of : 'this.stickyParent' might be 'null'
change doc
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
Added prefix 'mat-' for CSS class
Delete 'public' before variables
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
Added docs for all variables
extract 'generate CSS style'
created a generateStyleCSS() function, let it be responsible for generating all those CSS styles.
reformat
add debounce to solve 'getBoundingClientRect() cause slow down' problem.
add position:sticky and check whether browser support it. If not , use the naive implementation
removed unused import
Removed unused 'scrollableRegion' and 'parentRegion'
removed commented lines
default public
Add comments about why setting style top and position for iPhone and not IE. And extract detectBrowser() as a new function
format
consider all circumstances of browser.
use "===" instead of '=='
make 'navigator.userAgent.toLocaleLowerCase()' a local variable
optimize
Added comments on const 'STICK_START_CLASS' and 'STICK_END_CLASS'.
change their content to cdk-sticky-header-start and cdk-sticky-header-end
Added comments for STICK_START_CLASS and STICK_END_CLASS.
Changed the format of one-line JsDoc
unsubscribe sbscriptions onDestory
Use what modernizr does on compatibility instead of get the browser version directly.
add 'padding' and 'stickyRegionHeight' variables to avoid calling 'getComputedStyle()' too many times (which is expensive).
move docs above @directive
removed the underscore in'_element: ElementRef',
expand 'reg' to 'region'
use 'if (this.isIE)' instead of 'if(this.isIE === true)'
added more newlines between params in 'generateCssStyle()' function to make it easier to understand.
Added reference link to Modernizer in docs of getSupportList()
Deleted "_supportList" variable
renamed 'isIE' to 'isStickyPositionSupported', and removed extra space before Observable
Set debounce time as a const variable
Added docs for 'const DEBOUNCE_TIME: number = 5;'
Changed ' if(this.stickyParent == null)' to ' if(!this.stickyParent)'
Removed the @PARAM and @returns and make sure the types are correct in the function signature in 'generateCssStyle(...)' function
Added docs for `isStickyPositionSupported` variable
changed '+=' to '=' of 'stickyText' in getSupportList() function
nit added " " between 'if' and '('
nit
Added comments
deleted unused import
change comments
optimize comments
deleted unnecessary global variables(padding and stickyRegionHeight)
Added check whether we are on browser
Array<string> to string[]
test?
try to reopen the old PR
fix after rebase
revert list.ts
test
test 222
revert demo
revert list.ts second time
Move code to 'src/cdk'
revert 'move code to 'src/cdk'' , it should be done in a new PR
revert
avoid calling 'getComputedStyle()' too many times.
rename as sticky-header.ts
imported PlatformModule
Add blank lines between these top-level symbol
make '_isStickyPositionSupported' private
Changed the originalCSS to private and use '{} as CSSStyleDeclaration' instead of ''any.
Rename '_containerStart' to '_stickyRegionTop'
rename
optimize discription for '_stickyRegionBottomThreshold'
private _originalStyles = {
position: '',
top: '',
right: '',
left: '',
bottom: '',
width: '',
zIndex: ''};
Deleted 'generateCssStyle()' and 'getCssNumber()' function
Deleted 'getCssValue()' function
fix CSSStyleDeclaration
change sticky width to 'this.upperScrollableContainer.clientWidth'
fix
nit
Added the 'isPositionStickySupported() ' function to src/cdk/platform/features.ts.
Consume that function in this component and just always use both the webkit and unprefixed styles.
nit
nit
update doc 'Debounce time in milliseconds for events that affect the sticky positioning (e.g. scroll, resize, touch move). Set as 5 milliseconds which is the highest delay that doesn't drastically affect the positioning adversely.'
changed the doc to '/** z-index to be applied to the sticky header (default is 10). */'
fix tslint error
for comment 'Can you evaluate each method to make sure their accessor privacy is right? E.g. see which functions need to be public, private, static, etc'
Deleted variable 'elemHeight'
Chaned to 'if (!this.stickyParent)'
Simplified Docs for 'sticker()'.
set 'defineRestriction()' function to private
use 'RxChain'
deleted unused 'tableModule' in modules.ts
rename to '_isPositionStickySupported'
Use // for comments, /* */ for docs
@angular/cdk
rename : values -> headerStyles
Move closing brace to the next line
optimized: [this._onScrollSubscription, this._onScrollSubscription, this._onResizeSubscription]
.forEach(s => s && s.unsubscribe());
You should be able to do just '0' instead of '0px'
Format like TODO(sllethe): ...
private _attachEventListeners? Add a description like "Add listeners for events that affect sticky positioning."
optimize doc
Rename 'defineRestrictions' to '_measureStickyRegionBounds'
rename: private _resetElementStyles
let stuckRight: any = this.upperScrollableContainer.getBoundingClientRect().right;
chaned 'any' to 'number'
nit
change doc '/**
* Unsticks the header so that it goes back to scrolling normally.
*
* This should be called when the element reaches the bottom of its cdkStickyRegion so that it
* smoothly scrolls out of view as the next sticky-header moves in.
*/'
_unstuckElement -> _unstickElement
rename 'sticker()' to '_applyStickyPositionStyles()'
rename 'defineRestrictionsAndStick()' to '_updateStickyPositioning()'
* Add demo to sticky-header
* revert
* deleted HEAD file
* removed unused 'id'
* changed class name to a more meaningful name
* removed unused CSS
* You have lots of duplicate of -webkit-appearance: none;padding: 20px;. Merge them into one
* nit
* nit: use header-style and header-color1
* very nit: add some different text so we can see the changes?
* fix according to comments in pr
* fix white space between different <div>s
* P -> p
sllethe added a commit to sllethe/material2 that referenced this pull request Aug 1, 2017
@sllethe
# This is a combination of 10 commits.
a33e343
# This is the 1st commit message:
# This is a combination of 15 commits.
# This is the 1st commit message:
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
fix
delete sticky-header demo part from this branch
revert firebase file
change code according to comments in PR
revert firbaserc
revert routes.ts
change
fix the problem of : 'this.stickyParent' might be 'null'
change doc
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
Added prefix 'mat-' for CSS class
Delete 'public' before variables
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
Added docs for all variables
extract 'generate CSS style'
created a generateStyleCSS() function, let it be responsible for generating all those CSS styles.
reformat
add debounce to solve 'getBoundingClientRect() cause slow down' problem.
add position:sticky and check whether browser support it. If not , use the naive implementation
removed unused import
Removed unused 'scrollableRegion' and 'parentRegion'
removed commented lines
default public
Add comments about why setting style top and position for iPhone and not IE. And extract detectBrowser() as a new function
format
consider all circumstances of browser.
use "===" instead of '=='
make 'navigator.userAgent.toLocaleLowerCase()' a local variable
optimize
Added comments on const 'STICK_START_CLASS' and 'STICK_END_CLASS'.
change their content to cdk-sticky-header-start and cdk-sticky-header-end
Added comments for STICK_START_CLASS and STICK_END_CLASS.
Changed the format of one-line JsDoc
unsubscribe sbscriptions onDestory
Use what modernizr does on compatibility instead of get the browser version directly.
add 'padding' and 'stickyRegionHeight' variables to avoid calling 'getComputedStyle()' too many times (which is expensive).
move docs above @directive
removed the underscore in'_element: ElementRef',
expand 'reg' to 'region'
use 'if (this.isIE)' instead of 'if(this.isIE === true)'
added more newlines between params in 'generateCssStyle()' function to make it easier to understand.
Added reference link to Modernizer in docs of getSupportList()
Deleted "_supportList" variable
renamed 'isIE' to 'isStickyPositionSupported', and removed extra space before Observable
Set debounce time as a const variable
Added docs for 'const DEBOUNCE_TIME: number = 5;'
Changed ' if(this.stickyParent == null)' to ' if(!this.stickyParent)'
Removed the @PARAM and @returns and make sure the types are correct in the function signature in 'generateCssStyle(...)' function
Added docs for `isStickyPositionSupported` variable
changed '+=' to '=' of 'stickyText' in getSupportList() function
nit added " " between 'if' and '('
nit
Added comments
deleted unused import
change comments
optimize comments
deleted unnecessary global variables(padding and stickyRegionHeight)
Added check whether we are on browser
Array<string> to string[]
test?
try to reopen the old PR
fix after rebase
revert list.ts
test
test 222
revert demo
revert list.ts second time
Move code to 'src/cdk'
revert 'move code to 'src/cdk'' , it should be done in a new PR
revert
avoid calling 'getComputedStyle()' too many times.
rename as sticky-header.ts
# This is the commit message angular#2:
imported PlatformModule
# This is the commit message angular#3:
Add blank lines between these top-level symbol
# This is the commit message angular#4:
make '_isStickyPositionSupported' private
# This is the commit message angular#5:
Changed the originalCSS to private and use '{} as CSSStyleDeclaration' instead of ''any.
# This is the commit message angular#6:
Rename '_containerStart' to '_stickyRegionTop'
# This is the commit message angular#7:
rename
# This is the commit message angular#8:
optimize discription for '_stickyRegionBottomThreshold'
# This is the commit message angular#9:
private _originalStyles = {
position: '',
top: '',
right: '',
left: '',
bottom: '',
width: '',
zIndex: ''};
# This is the commit message angular#10:
Deleted 'generateCssStyle()' and 'getCssNumber()' function
# This is the commit message angular#11:
Deleted 'getCssValue()' function
# This is the commit message angular#12:
fix CSSStyleDeclaration
# This is the commit message angular#13:
change sticky width to 'this.upperScrollableContainer.clientWidth'
# This is the commit message angular#14:
fix
# This is the commit message angular#15:
nit
# This is the commit message angular#2:
Added the 'isPositionStickySupported() ' function to src/cdk/platform/features.ts.
Consume that function in this component and just always use both the webkit and unprefixed styles.
# This is the commit message angular#3:
nit
# This is the commit message angular#4:
nit
# This is the commit message angular#5:
update doc 'Debounce time in milliseconds for events that affect the sticky positioning (e.g. scroll, resize, touch move). Set as 5 milliseconds which is the highest delay that doesn't drastically affect the positioning adversely.'
# This is the commit message angular#6:
changed the doc to '/** z-index to be applied to the sticky header (default is 10). */'
# This is the commit message angular#7:
fix tslint error
# This is the commit message angular#8:
for comment 'Can you evaluate each method to make sure their accessor privacy is right? E.g. see which functions need to be public, private, static, etc'
# This is the commit message angular#9:
Deleted variable 'elemHeight'
# This is the commit message angular#10:
Chaned to 'if (!this.stickyParent)'
sllethe added a commit that referenced this pull request Aug 4, 2017
@sllethe
Add tests for sticky-header (#6074)
c8185fb
* # This is a combination of 9 commits.
# This is the 1st commit message:
# This is a combination of 11 commits.
# This is the 1st commit message:
add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
# This is the commit message #2:
fix
# This is the commit message #3:
delete sticky-header demo part from this branch
# This is the commit message #4:
revert firebase file
# This is the commit message #5:
change code according to comments in PR
# This is the commit message #6:
revert firbaserc
# This is the commit message #7:
revert demo-app.ts
# This is the commit message #8:
revert routes.ts
# This is the commit message #9:
revert demo-app-module.ts
# This is the commit message #10:
change
# This is the commit message #11:
fix the problem of : 'this.stickyParent' might be 'null'
# This is the commit message #2:
change doc
# This is the commit message #3:
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
# This is the commit message #4:
Added prefix 'mat-' for CSS class
# This is the commit message #5:
Delete 'public' before variables
# This is the commit message #6:
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
# This is the commit message #7:
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
# This is the commit message #8:
Added docs for all variables
# This is the commit message #9:
extract 'generate CSS style'
* # This is a combination of 5 commits.
# This is the 1st commit message:
add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
fix
delete sticky-header demo part from this branch
revert firebase file
change code according to comments in PR
revert firbaserc
revert demo-app.ts
revert routes.ts
revert demo-app-module.ts
change
fix the problem of : 'this.stickyParent' might be 'null'
change doc
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
Added prefix 'mat-' for CSS class
Delete 'public' before variables
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
Added docs for all variables
extract 'generate CSS style'
created a generateStyleCSS() function, let it be responsible for generating all those CSS styles.
reformat
add debounce to solve 'getBoundingClientRect() cause slow down' problem.
add position:sticky and check whether browser support it. If not , use the naive implementation
removed unused import
Removed unused 'scrollableRegion' and 'parentRegion'
removed commented lines
default public
Add comments about why setting style top and position for iPhone and not IE. And extract detectBrowser() as a new function
format
consider all circumstances of browser.
use "===" instead of '=='
make 'navigator.userAgent.toLocaleLowerCase()' a local variable
optimize
Added comments on const 'STICK_START_CLASS' and 'STICK_END_CLASS'.
change their content to cdk-sticky-header-start and cdk-sticky-header-end
Added comments for STICK_START_CLASS and STICK_END_CLASS.
Changed the format of one-line JsDoc
unsubscribe sbscriptions onDestory
Use what modernizr does on compatibility instead of get the browser version directly.
add 'padding' and 'stickyRegionHeight' variables to avoid calling 'getComputedStyle()' too many times (which is expensive).
move docs above @directive
removed the underscore in'_element: ElementRef',
expand 'reg' to 'region'
use 'if (this.isIE)' instead of 'if(this.isIE === true)'
added more newlines between params in 'generateCssStyle()' function to make it easier to understand.
Added reference link to Modernizer in docs of getSupportList()
Deleted "_supportList" variable
renamed 'isIE' to 'isStickyPositionSupported', and removed extra space before Observable
Set debounce time as a const variable
Added docs for 'const DEBOUNCE_TIME: number = 5;'
Changed ' if(this.stickyParent == null)' to ' if(!this.stickyParent)'
Removed the @PARAM and @returns and make sure the types are correct in the function signature in 'generateCssStyle(...)' function
Added docs for `isStickyPositionSupported` variable
changed '+=' to '=' of 'stickyText' in getSupportList() function
nit added " " between 'if' and '('
nit
Added comments
deleted unused import
change comments
optimize comments
deleted unnecessary global variables(padding and stickyRegionHeight)
Added check whether we are on browser
Array<string> to string[]
test?
try to reopen the old PR
fix after rebase
revert list.ts
test
test 222
revert demo
revert list.ts second time
Move code to 'src/cdk'
revert 'move code to 'src/cdk'' , it should be done in a new PR
revert
avoid calling 'getComputedStyle()' too many times.
rename as sticky-header.ts
# This is the commit message #2:
imported PlatformModule
# This is the commit message #3:
Add blank lines between these top-level symbol
# This is the commit message #4:
make '_isStickyPositionSupported' private
# This is the commit message #5:
Changed the originalCSS to private and use '{} as CSSStyleDeclaration' instead of ''any.
* # This is a combination of 16 commits.
# This is the 1st commit message:
# This is a combination of 10 commits.
# This is the 1st commit message:
add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
fix
delete sticky-header demo part from this branch
revert firebase file
change code according to comments in PR
revert firbaserc
revert demo-app.ts
revert routes.ts
revert demo-app-module.ts
change
fix the problem of : 'this.stickyParent' might be 'null'
change doc
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
Added prefix 'mat-' for CSS class
Delete 'public' before variables
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
Added docs for all variables
extract 'generate CSS style'
created a generateStyleCSS() function, let it be responsible for generating all those CSS styles.
reformat
add debounce to solve 'getBoundingClientRect() cause slow down' problem.
add position:sticky and check whether browser support it. If not , use the naive implementation
removed unused import
Removed unused 'scrollableRegion' and 'parentRegion'
removed commented lines
default public
Add comments about why setting style top and position for iPhone and not IE. And extract detectBrowser() as a new function
format
consider all circumstances of browser.
use "===" instead of '=='
make 'navigator.userAgent.toLocaleLowerCase()' a local variable
optimize
Added comments on const 'STICK_START_CLASS' and 'STICK_END_CLASS'.
change their content to cdk-sticky-header-start and cdk-sticky-header-end
Added comments for STICK_START_CLASS and STICK_END_CLASS.
Changed the format of one-line JsDoc
unsubscribe sbscriptions onDestory
Use what modernizr does on compatibility instead of get the browser version directly.
add 'padding' and 'stickyRegionHeight' variables to avoid calling 'getComputedStyle()' too many times (which is expensive).
move docs above @directive
removed the underscore in'_element: ElementRef',
expand 'reg' to 'region'
use 'if (this.isIE)' instead of 'if(this.isIE === true)'
added more newlines between params in 'generateCssStyle()' function to make it easier to understand.
Added reference link to Modernizer in docs of getSupportList()
Deleted "_supportList" variable
renamed 'isIE' to 'isStickyPositionSupported', and removed extra space before Observable
Set debounce time as a const variable
Added docs for 'const DEBOUNCE_TIME: number = 5;'
Changed ' if(this.stickyParent == null)' to ' if(!this.stickyParent)'
Removed the @PARAM and @returns and make sure the types are correct in the function signature in 'generateCssStyle(...)' function
Added docs for `isStickyPositionSupported` variable
changed '+=' to '=' of 'stickyText' in getSupportList() function
nit added " " between 'if' and '('
nit
Added comments
deleted unused import
change comments
optimize comments
deleted unnecessary global variables(padding and stickyRegionHeight)
Added check whether we are on browser
Array<string> to string[]
test?
try to reopen the old PR
fix after rebase
revert list.ts
test
test 222
revert demo
revert list.ts second time
Move code to 'src/cdk'
revert 'move code to 'src/cdk'' , it should be done in a new PR
revert
avoid calling 'getComputedStyle()' too many times.
rename as sticky-header.ts
imported PlatformModule
Add blank lines between these top-level symbol
make '_isStickyPositionSupported' private
Changed the originalCSS to private and use '{} as CSSStyleDeclaration' instead of ''any.
Rename '_containerStart' to '_stickyRegionTop'
# This is the commit message #2:
rename
# This is the commit message #3:
optimize discription for '_stickyRegionBottomThreshold'
# This is the commit message #4:
private _originalStyles = {
position: '',
top: '',
right: '',
left: '',
bottom: '',
width: '',
zIndex: ''};
# This is the commit message #5:
Deleted 'generateCssStyle()' and 'getCssNumber()' function
# This is the commit message #6:
Deleted 'getCssValue()' function
# This is the commit message #7:
fix CSSStyleDeclaration
# This is the commit message #8:
change sticky width to 'this.upperScrollableContainer.clientWidth'
# This is the commit message #9:
fix
# This is the commit message #10:
nit
# This is the commit message #2:
Added the 'isPositionStickySupported() ' function to src/cdk/platform/features.ts.
Consume that function in this component and just always use both the webkit and unprefixed styles.
# This is the commit message #3:
nit
# This is the commit message #4:
nit
# This is the commit message #5:
update doc 'Debounce time in milliseconds for events that affect the sticky positioning (e.g. scroll, resize, touch move). Set as 5 milliseconds which is the highest delay that doesn't drastically affect the positioning adversely.'
# This is the commit message #6:
changed the doc to '/** z-index to be applied to the sticky header (default is 10). */'
# This is the commit message #7:
fix tslint error
# This is the commit message #8:
for comment 'Can you evaluate each method to make sure their accessor privacy is right? E.g. see which functions need to be public, private, static, etc'
# This is the commit message #9:
Deleted variable 'elemHeight'
# This is the commit message #10:
Chaned to 'if (!this.stickyParent)'
# This is the commit message #11:
Simplified Docs for 'sticker()'.
# This is the commit message #12:
set 'defineRestriction()' function to private
# This is the commit message #13:
use 'RxChain'
# This is the commit message #14:
deleted unused 'tableModule' in modules.ts
# This is the commit message #15:
rename to '_isPositionStickySupported'
# This is the commit message #16:
Use // for comments, /* */ for docs
* add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
fix
delete sticky-header demo part from this branch
revert firebase file
change code according to comments in PR
revert firbaserc
revert demo-app.ts
revert routes.ts
revert demo-app-module.ts
change
fix the problem of : 'this.stickyParent' might be 'null'
change doc
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
Added prefix 'mat-' for CSS class
Delete 'public' before variables
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
Added docs for all variables
extract 'generate CSS style'
created a generateStyleCSS() function, let it be responsible for generating all those CSS styles.
reformat
add debounce to solve 'getBoundingClientRect() cause slow down' problem.
add position:sticky and check whether browser support it. If not , use the naive implementation
removed unused import
Removed unused 'scrollableRegion' and 'parentRegion'
removed commented lines
default public
Add comments about why setting style top and position for iPhone and not IE. And extract detectBrowser() as a new function
format
consider all circumstances of browser.
use "===" instead of '=='
make 'navigator.userAgent.toLocaleLowerCase()' a local variable
optimize
Added comments on const 'STICK_START_CLASS' and 'STICK_END_CLASS'.
change their content to cdk-sticky-header-start and cdk-sticky-header-end
Added comments for STICK_START_CLASS and STICK_END_CLASS.
Changed the format of one-line JsDoc
unsubscribe sbscriptions onDestory
Use what modernizr does on compatibility instead of get the browser version directly.
add 'padding' and 'stickyRegionHeight' variables to avoid calling 'getComputedStyle()' too many times (which is expensive).
move docs above @directive
removed the underscore in'_element: ElementRef',
expand 'reg' to 'region'
use 'if (this.isIE)' instead of 'if(this.isIE === true)'
added more newlines between params in 'generateCssStyle()' function to make it easier to understand.
Added reference link to Modernizer in docs of getSupportList()
Deleted "_supportList" variable
renamed 'isIE' to 'isStickyPositionSupported', and removed extra space before Observable
Set debounce time as a const variable
Added docs for 'const DEBOUNCE_TIME: number = 5;'
Changed ' if(this.stickyParent == null)' to ' if(!this.stickyParent)'
Removed the @PARAM and @returns and make sure the types are correct in the function signature in 'generateCssStyle(...)' function
Added docs for `isStickyPositionSupported` variable
changed '+=' to '=' of 'stickyText' in getSupportList() function
nit added " " between 'if' and '('
nit
Added comments
deleted unused import
change comments
optimize comments
deleted unnecessary global variables(padding and stickyRegionHeight)
Added check whether we are on browser
Array<string> to string[]
test?
try to reopen the old PR
fix after rebase
revert list.ts
test
test 222
revert demo
revert list.ts second time
Move code to 'src/cdk'
revert 'move code to 'src/cdk'' , it should be done in a new PR
revert
avoid calling 'getComputedStyle()' too many times.
rename as sticky-header.ts
imported PlatformModule
Add blank lines between these top-level symbol
make '_isStickyPositionSupported' private
Changed the originalCSS to private and use '{} as CSSStyleDeclaration' instead of ''any.
Rename '_containerStart' to '_stickyRegionTop'
rename
optimize discription for '_stickyRegionBottomThreshold'
private _originalStyles = {
position: '',
top: '',
right: '',
left: '',
bottom: '',
width: '',
zIndex: ''};
Deleted 'generateCssStyle()' and 'getCssNumber()' function
Deleted 'getCssValue()' function
fix CSSStyleDeclaration
change sticky width to 'this.upperScrollableContainer.clientWidth'
fix
nit
Added the 'isPositionStickySupported() ' function to src/cdk/platform/features.ts.
Consume that function in this component and just always use both the webkit and unprefixed styles.
nit
nit
update doc 'Debounce time in milliseconds for events that affect the sticky positioning (e.g. scroll, resize, touch move). Set as 5 milliseconds which is the highest delay that doesn't drastically affect the positioning adversely.'
changed the doc to '/** z-index to be applied to the sticky header (default is 10). */'
fix tslint error
for comment 'Can you evaluate each method to make sure their accessor privacy is right? E.g. see which functions need to be public, private, static, etc'
Deleted variable 'elemHeight'
Chaned to 'if (!this.stickyParent)'
Simplified Docs for 'sticker()'.
set 'defineRestriction()' function to private
use 'RxChain'
deleted unused 'tableModule' in modules.ts
rename to '_isPositionStickySupported'
Use // for comments, /* */ for docs
@angular/cdk
rename : values -> headerStyles
Move closing brace to the next line
optimized: [this._onScrollSubscription, this._onScrollSubscription, this._onResizeSubscription]
.forEach(s => s && s.unsubscribe());
You should be able to do just '0' instead of '0px'
Format like TODO(sllethe): ...
private _attachEventListeners? Add a description like "Add listeners for events that affect sticky positioning."
optimize doc
Rename 'defineRestrictions' to '_measureStickyRegionBounds'
rename: private _resetElementStyles
let stuckRight: any = this.upperScrollableContainer.getBoundingClientRect().right;
chaned 'any' to 'number'
nit
change doc '/**
* Unsticks the header so that it goes back to scrolling normally.
*
* This should be called when the element reaches the bottom of its cdkStickyRegion so that it
* smoothly scrolls out of view as the next sticky-header moves in.
*/'
_unstuckElement -> _unstickElement
rename 'sticker()' to '_applyStickyPositionStyles()'
rename 'defineRestrictionsAndStick()' to '_updateStickyPositioning()'
* added tests for sticky-header
* deleted
* removed 'deps' in providers
* put provider in index
* optimize provider
* Removed unused 'fixture.detectChanges()' in test
* fix
* You can remove when sticky positioning is not supported since it's in describe
* stickyHeaderDir.stickyParent
* remove commented code
* rename stickyHeaderDir to stickyHeader
* Changed to use 'ngFor' to expand content instead of typing tons of '<p></p>'
* Add a comment that explains what these inline styles are for? Any reason you can't set them via the styles configuration for the component?
* Added explainations on styles
* Added /** @docs-private */
* Added comments to explaining why tick(100) is needed. Changed 'tick(0)' to 'tick()'
* nit
* explained why need 'tick(100)'
* expect(/sticky/i.test(position!)).toBe(true);
* change CSS indent to +2
* nit
* Added test for sticky-header without StickyRegion
* change 'toBe(null)' to 'toBeNull()'
* Cool ! tick(debounce time)
sllethe added a commit to sllethe/material2 that referenced this pull request Aug 10, 2017
@sllethe
Add tests for sticky-header (angular#6074)
2d84882
* # This is a combination of 9 commits.
# This is the 1st commit message:
# This is a combination of 11 commits.
# This is the 1st commit message:
add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
# This is the commit message angular#2:
fix
# This is the commit message angular#3:
delete sticky-header demo part from this branch
# This is the commit message angular#4:
revert firebase file
# This is the commit message angular#5:
change code according to comments in PR
# This is the commit message angular#6:
revert firbaserc
# This is the commit message angular#7:
revert demo-app.ts
# This is the commit message angular#8:
revert routes.ts
# This is the commit message angular#9:
revert demo-app-module.ts
# This is the commit message angular#10:
change
# This is the commit message angular#11:
fix the problem of : 'this.stickyParent' might be 'null'
# This is the commit message angular#2:
change doc
# This is the commit message angular#3:
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
# This is the commit message angular#4:
Added prefix 'mat-' for CSS class
# This is the commit message angular#5:
Delete 'public' before variables
# This is the commit message angular#6:
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
# This is the commit message angular#7:
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
# This is the commit message angular#8:
Added docs for all variables
# This is the commit message angular#9:
extract 'generate CSS style'
* # This is a combination of 5 commits.
# This is the 1st commit message:
add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
fix
delete sticky-header demo part from this branch
revert firebase file
change code according to comments in PR
revert firbaserc
revert demo-app.ts
revert routes.ts
revert demo-app-module.ts
change
fix the problem of : 'this.stickyParent' might be 'null'
change doc
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
Added prefix 'mat-' for CSS class
Delete 'public' before variables
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
Added docs for all variables
extract 'generate CSS style'
created a generateStyleCSS() function, let it be responsible for generating all those CSS styles.
reformat
add debounce to solve 'getBoundingClientRect() cause slow down' problem.
add position:sticky and check whether browser support it. If not , use the naive implementation
removed unused import
Removed unused 'scrollableRegion' and 'parentRegion'
removed commented lines
default public
Add comments about why setting style top and position for iPhone and not IE. And extract detectBrowser() as a new function
format
consider all circumstances of browser.
use "===" instead of '=='
make 'navigator.userAgent.toLocaleLowerCase()' a local variable
optimize
Added comments on const 'STICK_START_CLASS' and 'STICK_END_CLASS'.
change their content to cdk-sticky-header-start and cdk-sticky-header-end
Added comments for STICK_START_CLASS and STICK_END_CLASS.
Changed the format of one-line JsDoc
unsubscribe sbscriptions onDestory
Use what modernizr does on compatibility instead of get the browser version directly.
add 'padding' and 'stickyRegionHeight' variables to avoid calling 'getComputedStyle()' too many times (which is expensive).
move docs above @directive
removed the underscore in'_element: ElementRef',
expand 'reg' to 'region'
use 'if (this.isIE)' instead of 'if(this.isIE === true)'
added more newlines between params in 'generateCssStyle()' function to make it easier to understand.
Added reference link to Modernizer in docs of getSupportList()
Deleted "_supportList" variable
renamed 'isIE' to 'isStickyPositionSupported', and removed extra space before Observable
Set debounce time as a const variable
Added docs for 'const DEBOUNCE_TIME: number = 5;'
Changed ' if(this.stickyParent == null)' to ' if(!this.stickyParent)'
Removed the @PARAM and @returns and make sure the types are correct in the function signature in 'generateCssStyle(...)' function
Added docs for `isStickyPositionSupported` variable
changed '+=' to '=' of 'stickyText' in getSupportList() function
nit added " " between 'if' and '('
nit
Added comments
deleted unused import
change comments
optimize comments
deleted unnecessary global variables(padding and stickyRegionHeight)
Added check whether we are on browser
Array<string> to string[]
test?
try to reopen the old PR
fix after rebase
revert list.ts
test
test 222
revert demo
revert list.ts second time
Move code to 'src/cdk'
revert 'move code to 'src/cdk'' , it should be done in a new PR
revert
avoid calling 'getComputedStyle()' too many times.
rename as sticky-header.ts
# This is the commit message angular#2:
imported PlatformModule
# This is the commit message angular#3:
Add blank lines between these top-level symbol
# This is the commit message angular#4:
make '_isStickyPositionSupported' private
# This is the commit message angular#5:
Changed the originalCSS to private and use '{} as CSSStyleDeclaration' instead of ''any.
* # This is a combination of 16 commits.
# This is the 1st commit message:
# This is a combination of 10 commits.
# This is the 1st commit message:
add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
fix
delete sticky-header demo part from this branch
revert firebase file
change code according to comments in PR
revert firbaserc
revert demo-app.ts
revert routes.ts
revert demo-app-module.ts
change
fix the problem of : 'this.stickyParent' might be 'null'
change doc
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
Added prefix 'mat-' for CSS class
Delete 'public' before variables
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
Added docs for all variables
extract 'generate CSS style'
created a generateStyleCSS() function, let it be responsible for generating all those CSS styles.
reformat
add debounce to solve 'getBoundingClientRect() cause slow down' problem.
add position:sticky and check whether browser support it. If not , use the naive implementation
removed unused import
Removed unused 'scrollableRegion' and 'parentRegion'
removed commented lines
default public
Add comments about why setting style top and position for iPhone and not IE. And extract detectBrowser() as a new function
format
consider all circumstances of browser.
use "===" instead of '=='
make 'navigator.userAgent.toLocaleLowerCase()' a local variable
optimize
Added comments on const 'STICK_START_CLASS' and 'STICK_END_CLASS'.
change their content to cdk-sticky-header-start and cdk-sticky-header-end
Added comments for STICK_START_CLASS and STICK_END_CLASS.
Changed the format of one-line JsDoc
unsubscribe sbscriptions onDestory
Use what modernizr does on compatibility instead of get the browser version directly.
add 'padding' and 'stickyRegionHeight' variables to avoid calling 'getComputedStyle()' too many times (which is expensive).
move docs above @directive
removed the underscore in'_element: ElementRef',
expand 'reg' to 'region'
use 'if (this.isIE)' instead of 'if(this.isIE === true)'
added more newlines between params in 'generateCssStyle()' function to make it easier to understand.
Added reference link to Modernizer in docs of getSupportList()
Deleted "_supportList" variable
renamed 'isIE' to 'isStickyPositionSupported', and removed extra space before Observable
Set debounce time as a const variable
Added docs for 'const DEBOUNCE_TIME: number = 5;'
Changed ' if(this.stickyParent == null)' to ' if(!this.stickyParent)'
Removed the @PARAM and @returns and make sure the types are correct in the function signature in 'generateCssStyle(...)' function
Added docs for `isStickyPositionSupported` variable
changed '+=' to '=' of 'stickyText' in getSupportList() function
nit added " " between 'if' and '('
nit
Added comments
deleted unused import
change comments
optimize comments
deleted unnecessary global variables(padding and stickyRegionHeight)
Added check whether we are on browser
Array<string> to string[]
test?
try to reopen the old PR
fix after rebase
revert list.ts
test
test 222
revert demo
revert list.ts second time
Move code to 'src/cdk'
revert 'move code to 'src/cdk'' , it should be done in a new PR
revert
avoid calling 'getComputedStyle()' too many times.
rename as sticky-header.ts
imported PlatformModule
Add blank lines between these top-level symbol
make '_isStickyPositionSupported' private
Changed the originalCSS to private and use '{} as CSSStyleDeclaration' instead of ''any.
Rename '_containerStart' to '_stickyRegionTop'
# This is the commit message angular#2:
rename
# This is the commit message angular#3:
optimize discription for '_stickyRegionBottomThreshold'
# This is the commit message angular#4:
private _originalStyles = {
position: '',
top: '',
right: '',
left: '',
bottom: '',
width: '',
zIndex: ''};
# This is the commit message angular#5:
Deleted 'generateCssStyle()' and 'getCssNumber()' function
# This is the commit message angular#6:
Deleted 'getCssValue()' function
# This is the commit message angular#7:
fix CSSStyleDeclaration
# This is the commit message angular#8:
change sticky width to 'this.upperScrollableContainer.clientWidth'
# This is the commit message angular#9:
fix
# This is the commit message angular#10:
nit
# This is the commit message angular#2:
Added the 'isPositionStickySupported() ' function to src/cdk/platform/features.ts.
Consume that function in this component and just always use both the webkit and unprefixed styles.
# This is the commit message angular#3:
nit
# This is the commit message angular#4:
nit
# This is the commit message angular#5:
update doc 'Debounce time in milliseconds for events that affect the sticky positioning (e.g. scroll, resize, touch move). Set as 5 milliseconds which is the highest delay that doesn't drastically affect the positioning adversely.'
# This is the commit message angular#6:
changed the doc to '/** z-index to be applied to the sticky header (default is 10). */'
# This is the commit message angular#7:
fix tslint error
# This is the commit message angular#8:
for comment 'Can you evaluate each method to make sure their accessor privacy is right? E.g. see which functions need to be public, private, static, etc'
# This is the commit message angular#9:
Deleted variable 'elemHeight'
# This is the commit message angular#10:
Chaned to 'if (!this.stickyParent)'
# This is the commit message angular#11:
Simplified Docs for 'sticker()'.
# This is the commit message angular#12:
set 'defineRestriction()' function to private
# This is the commit message angular#13:
use 'RxChain'
# This is the commit message angular#14:
deleted unused 'tableModule' in modules.ts
# This is the commit message angular#15:
rename to '_isPositionStickySupported'
# This is the commit message angular#16:
Use // for comments, /* */ for docs
* add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
fix
delete sticky-header demo part from this branch
revert firebase file
change code according to comments in PR
revert firbaserc
revert demo-app.ts
revert routes.ts
revert demo-app-module.ts
change
fix the problem of : 'this.stickyParent' might be 'null'
change doc
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
Added prefix 'mat-' for CSS class
Delete 'public' before variables
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
Added docs for all variables
extract 'generate CSS style'
created a generateStyleCSS() function, let it be responsible for generating all those CSS styles.
reformat
add debounce to solve 'getBoundingClientRect() cause slow down' problem.
add position:sticky and check whether browser support it. If not , use the naive implementation
removed unused import
Removed unused 'scrollableRegion' and 'parentRegion'
removed commented lines
default public
Add comments about why setting style top and position for iPhone and not IE. And extract detectBrowser() as a new function
format
consider all circumstances of browser.
use "===" instead of '=='
make 'navigator.userAgent.toLocaleLowerCase()' a local variable
optimize
Added comments on const 'STICK_START_CLASS' and 'STICK_END_CLASS'.
change their content to cdk-sticky-header-start and cdk-sticky-header-end
Added comments for STICK_START_CLASS and STICK_END_CLASS.
Changed the format of one-line JsDoc
unsubscribe sbscriptions onDestory
Use what modernizr does on compatibility instead of get the browser version directly.
add 'padding' and 'stickyRegionHeight' variables to avoid calling 'getComputedStyle()' too many times (which is expensive).
move docs above @directive
removed the underscore in'_element: ElementRef',
expand 'reg' to 'region'
use 'if (this.isIE)' instead of 'if(this.isIE === true)'
added more newlines between params in 'generateCssStyle()' function to make it easier to understand.
Added reference link to Modernizer in docs of getSupportList()
Deleted "_supportList" variable
renamed 'isIE' to 'isStickyPositionSupported', and removed extra space before Observable
Set debounce time as a const variable
Added docs for 'const DEBOUNCE_TIME: number = 5;'
Changed ' if(this.stickyParent == null)' to ' if(!this.stickyParent)'
Removed the @PARAM and @returns and make sure the types are correct in the function signature in 'generateCssStyle(...)' function
Added docs for `isStickyPositionSupported` variable
changed '+=' to '=' of 'stickyText' in getSupportList() function
nit added " " between 'if' and '('
nit
Added comments
deleted unused import
change comments
optimize comments
deleted unnecessary global variables(padding and stickyRegionHeight)
Added check whether we are on browser
Array<string> to string[]
test?
try to reopen the old PR
fix after rebase
revert list.ts
test
test 222
revert demo
revert list.ts second time
Move code to 'src/cdk'
revert 'move code to 'src/cdk'' , it should be done in a new PR
revert
avoid calling 'getComputedStyle()' too many times.
rename as sticky-header.ts
imported PlatformModule
Add blank lines between these top-level symbol
make '_isStickyPositionSupported' private
Changed the originalCSS to private and use '{} as CSSStyleDeclaration' instead of ''any.
Rename '_containerStart' to '_stickyRegionTop'
rename
optimize discription for '_stickyRegionBottomThreshold'
private _originalStyles = {
position: '',
top: '',
right: '',
left: '',
bottom: '',
width: '',
zIndex: ''};
Deleted 'generateCssStyle()' and 'getCssNumber()' function
Deleted 'getCssValue()' function
fix CSSStyleDeclaration
change sticky width to 'this.upperScrollableContainer.clientWidth'
fix
nit
Added the 'isPositionStickySupported() ' function to src/cdk/platform/features.ts.
Consume that function in this component and just always use both the webkit and unprefixed styles.
nit
nit
update doc 'Debounce time in milliseconds for events that affect the sticky positioning (e.g. scroll, resize, touch move). Set as 5 milliseconds which is the highest delay that doesn't drastically affect the positioning adversely.'
changed the doc to '/** z-index to be applied to the sticky header (default is 10). */'
fix tslint error
for comment 'Can you evaluate each method to make sure their accessor privacy is right? E.g. see which functions need to be public, private, static, etc'
Deleted variable 'elemHeight'
Chaned to 'if (!this.stickyParent)'
Simplified Docs for 'sticker()'.
set 'defineRestriction()' function to private
use 'RxChain'
deleted unused 'tableModule' in modules.ts
rename to '_isPositionStickySupported'
Use // for comments, /* */ for docs
@angular/cdk
rename : values -> headerStyles
Move closing brace to the next line
optimized: [this._onScrollSubscription, this._onScrollSubscription, this._onResizeSubscription]
.forEach(s => s && s.unsubscribe());
You should be able to do just '0' instead of '0px'
Format like TODO(sllethe): ...
private _attachEventListeners? Add a description like "Add listeners for events that affect sticky positioning."
optimize doc
Rename 'defineRestrictions' to '_measureStickyRegionBounds'
rename: private _resetElementStyles
let stuckRight: any = this.upperScrollableContainer.getBoundingClientRect().right;
chaned 'any' to 'number'
nit
change doc '/**
* Unsticks the header so that it goes back to scrolling normally.
*
* This should be called when the element reaches the bottom of its cdkStickyRegion so that it
* smoothly scrolls out of view as the next sticky-header moves in.
*/'
_unstuckElement -> _unstickElement
rename 'sticker()' to '_applyStickyPositionStyles()'
rename 'defineRestrictionsAndStick()' to '_updateStickyPositioning()'
* added tests for sticky-header
* deleted
* removed 'deps' in providers
* put provider in index
* optimize provider
* Removed unused 'fixture.detectChanges()' in test
* fix
* You can remove when sticky positioning is not supported since it's in describe
* stickyHeaderDir.stickyParent
* remove commented code
* rename stickyHeaderDir to stickyHeader
* Changed to use 'ngFor' to expand content instead of typing tons of '<p></p>'
* Add a comment that explains what these inline styles are for? Any reason you can't set them via the styles configuration for the component?
* Added explainations on styles
* Added /** @docs-private */
* Added comments to explaining why tick(100) is needed. Changed 'tick(0)' to 'tick()'
* nit
* explained why need 'tick(100)'
* expect(/sticky/i.test(position!)).toBe(true);
* change CSS indent to +2
* nit
* Added test for sticky-header without StickyRegion
* change 'toBe(null)' to 'toBeNull()'
* Cool ! tick(debounce time)
sllethe added a commit to sllethe/material2 that referenced this pull request Aug 10, 2017
@sllethe
Add tests for sticky-header (angular#6074)
eab3f90
* # This is a combination of 9 commits.
# This is the 1st commit message:
# This is a combination of 11 commits.
# This is the 1st commit message:
add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
# This is the commit message angular#2:
fix
# This is the commit message angular#3:
delete sticky-header demo part from this branch
# This is the commit message angular#4:
revert firebase file
# This is the commit message angular#5:
change code according to comments in PR
# This is the commit message angular#6:
revert firbaserc
# This is the commit message angular#7:
revert demo-app.ts
# This is the commit message angular#8:
revert routes.ts
# This is the commit message angular#9:
revert demo-app-module.ts
# This is the commit message angular#10:
change
# This is the commit message angular#11:
fix the problem of : 'this.stickyParent' might be 'null'
# This is the commit message angular#2:
change doc
# This is the commit message angular#3:
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
# This is the commit message angular#4:
Added prefix 'mat-' for CSS class
# This is the commit message angular#5:
Delete 'public' before variables
# This is the commit message angular#6:
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
# This is the commit message angular#7:
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
# This is the commit message angular#8:
Added docs for all variables
# This is the commit message angular#9:
extract 'generate CSS style'
* # This is a combination of 5 commits.
# This is the 1st commit message:
add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
fix
delete sticky-header demo part from this branch
revert firebase file
change code according to comments in PR
revert firbaserc
revert demo-app.ts
revert routes.ts
revert demo-app-module.ts
change
fix the problem of : 'this.stickyParent' might be 'null'
change doc
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
Added prefix 'mat-' for CSS class
Delete 'public' before variables
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
Added docs for all variables
extract 'generate CSS style'
created a generateStyleCSS() function, let it be responsible for generating all those CSS styles.
reformat
add debounce to solve 'getBoundingClientRect() cause slow down' problem.
add position:sticky and check whether browser support it. If not , use the naive implementation
removed unused import
Removed unused 'scrollableRegion' and 'parentRegion'
removed commented lines
default public
Add comments about why setting style top and position for iPhone and not IE. And extract detectBrowser() as a new function
format
consider all circumstances of browser.
use "===" instead of '=='
make 'navigator.userAgent.toLocaleLowerCase()' a local variable
optimize
Added comments on const 'STICK_START_CLASS' and 'STICK_END_CLASS'.
change their content to cdk-sticky-header-start and cdk-sticky-header-end
Added comments for STICK_START_CLASS and STICK_END_CLASS.
Changed the format of one-line JsDoc
unsubscribe sbscriptions onDestory
Use what modernizr does on compatibility instead of get the browser version directly.
add 'padding' and 'stickyRegionHeight' variables to avoid calling 'getComputedStyle()' too many times (which is expensive).
move docs above @directive
removed the underscore in'_element: ElementRef',
expand 'reg' to 'region'
use 'if (this.isIE)' instead of 'if(this.isIE === true)'
added more newlines between params in 'generateCssStyle()' function to make it easier to understand.
Added reference link to Modernizer in docs of getSupportList()
Deleted "_supportList" variable
renamed 'isIE' to 'isStickyPositionSupported', and removed extra space before Observable
Set debounce time as a const variable
Added docs for 'const DEBOUNCE_TIME: number = 5;'
Changed ' if(this.stickyParent == null)' to ' if(!this.stickyParent)'
Removed the @PARAM and @returns and make sure the types are correct in the function signature in 'generateCssStyle(...)' function
Added docs for `isStickyPositionSupported` variable
changed '+=' to '=' of 'stickyText' in getSupportList() function
nit added " " between 'if' and '('
nit
Added comments
deleted unused import
change comments
optimize comments
deleted unnecessary global variables(padding and stickyRegionHeight)
Added check whether we are on browser
Array<string> to string[]
test?
try to reopen the old PR
fix after rebase
revert list.ts
test
test 222
revert demo
revert list.ts second time
Move code to 'src/cdk'
revert 'move code to 'src/cdk'' , it should be done in a new PR
revert
avoid calling 'getComputedStyle()' too many times.
rename as sticky-header.ts
# This is the commit message angular#2:
imported PlatformModule
# This is the commit message angular#3:
Add blank lines between these top-level symbol
# This is the commit message angular#4:
make '_isStickyPositionSupported' private
# This is the commit message angular#5:
Changed the originalCSS to private and use '{} as CSSStyleDeclaration' instead of ''any.
* # This is a combination of 16 commits.
# This is the 1st commit message:
# This is a combination of 10 commits.
# This is the 1st commit message:
add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
fix
delete sticky-header demo part from this branch
revert firebase file
change code according to comments in PR
revert firbaserc
revert demo-app.ts
revert routes.ts
revert demo-app-module.ts
change
fix the problem of : 'this.stickyParent' might be 'null'
change doc
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
Added prefix 'mat-' for CSS class
Delete 'public' before variables
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
Added docs for all variables
extract 'generate CSS style'
created a generateStyleCSS() function, let it be responsible for generating all those CSS styles.
reformat
add debounce to solve 'getBoundingClientRect() cause slow down' problem.
add position:sticky and check whether browser support it. If not , use the naive implementation
removed unused import
Removed unused 'scrollableRegion' and 'parentRegion'
removed commented lines
default public
Add comments about why setting style top and position for iPhone and not IE. And extract detectBrowser() as a new function
format
consider all circumstances of browser.
use "===" instead of '=='
make 'navigator.userAgent.toLocaleLowerCase()' a local variable
optimize
Added comments on const 'STICK_START_CLASS' and 'STICK_END_CLASS'.
change their content to cdk-sticky-header-start and cdk-sticky-header-end
Added comments for STICK_START_CLASS and STICK_END_CLASS.
Changed the format of one-line JsDoc
unsubscribe sbscriptions onDestory
Use what modernizr does on compatibility instead of get the browser version directly.
add 'padding' and 'stickyRegionHeight' variables to avoid calling 'getComputedStyle()' too many times (which is expensive).
move docs above @directive
removed the underscore in'_element: ElementRef',
expand 'reg' to 'region'
use 'if (this.isIE)' instead of 'if(this.isIE === true)'
added more newlines between params in 'generateCssStyle()' function to make it easier to understand.
Added reference link to Modernizer in docs of getSupportList()
Deleted "_supportList" variable
renamed 'isIE' to 'isStickyPositionSupported', and removed extra space before Observable
Set debounce time as a const variable
Added docs for 'const DEBOUNCE_TIME: number = 5;'
Changed ' if(this.stickyParent == null)' to ' if(!this.stickyParent)'
Removed the @PARAM and @returns and make sure the types are correct in the function signature in 'generateCssStyle(...)' function
Added docs for `isStickyPositionSupported` variable
changed '+=' to '=' of 'stickyText' in getSupportList() function
nit added " " between 'if' and '('
nit
Added comments
deleted unused import
change comments
optimize comments
deleted unnecessary global variables(padding and stickyRegionHeight)
Added check whether we are on browser
Array<string> to string[]
test?
try to reopen the old PR
fix after rebase
revert list.ts
test
test 222
revert demo
revert list.ts second time
Move code to 'src/cdk'
revert 'move code to 'src/cdk'' , it should be done in a new PR
revert
avoid calling 'getComputedStyle()' too many times.
rename as sticky-header.ts
imported PlatformModule
Add blank lines between these top-level symbol
make '_isStickyPositionSupported' private
Changed the originalCSS to private and use '{} as CSSStyleDeclaration' instead of ''any.
Rename '_containerStart' to '_stickyRegionTop'
# This is the commit message angular#2:
rename
# This is the commit message angular#3:
optimize discription for '_stickyRegionBottomThreshold'
# This is the commit message angular#4:
private _originalStyles = {
position: '',
top: '',
right: '',
left: '',
bottom: '',
width: '',
zIndex: ''};
# This is the commit message angular#5:
Deleted 'generateCssStyle()' and 'getCssNumber()' function
# This is the commit message angular#6:
Deleted 'getCssValue()' function
# This is the commit message angular#7:
fix CSSStyleDeclaration
# This is the commit message angular#8:
change sticky width to 'this.upperScrollableContainer.clientWidth'
# This is the commit message angular#9:
fix
# This is the commit message angular#10:
nit
# This is the commit message angular#2:
Added the 'isPositionStickySupported() ' function to src/cdk/platform/features.ts.
Consume that function in this component and just always use both the webkit and unprefixed styles.
# This is the commit message angular#3:
nit
# This is the commit message angular#4:
nit
# This is the commit message angular#5:
update doc 'Debounce time in milliseconds for events that affect the sticky positioning (e.g. scroll, resize, touch move). Set as 5 milliseconds which is the highest delay that doesn't drastically affect the positioning adversely.'
# This is the commit message angular#6:
changed the doc to '/** z-index to be applied to the sticky header (default is 10). */'
# This is the commit message angular#7:
fix tslint error
# This is the commit message angular#8:
for comment 'Can you evaluate each method to make sure their accessor privacy is right? E.g. see which functions need to be public, private, static, etc'
# This is the commit message angular#9:
Deleted variable 'elemHeight'
# This is the commit message angular#10:
Chaned to 'if (!this.stickyParent)'
# This is the commit message angular#11:
Simplified Docs for 'sticker()'.
# This is the commit message angular#12:
set 'defineRestriction()' function to private
# This is the commit message angular#13:
use 'RxChain'
# This is the commit message angular#14:
deleted unused 'tableModule' in modules.ts
# This is the commit message angular#15:
rename to '_isPositionStickySupported'
# This is the commit message angular#16:
Use // for comments, /* */ for docs
* add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
fix
delete sticky-header demo part from this branch
revert firebase file
change code according to comments in PR
revert firbaserc
revert demo-app.ts
revert routes.ts
revert demo-app-module.ts
change
fix the problem of : 'this.stickyParent' might be 'null'
change doc
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
Added prefix 'mat-' for CSS class
Delete 'public' before variables
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
Added docs for all variables
extract 'generate CSS style'
created a generateStyleCSS() function, let it be responsible for generating all those CSS styles.
reformat
add debounce to solve 'getBoundingClientRect() cause slow down' problem.
add position:sticky and check whether browser support it. If not , use the naive implementation
removed unused import
Removed unused 'scrollableRegion' and 'parentRegion'
removed commented lines
default public
Add comments about why setting style top and position for iPhone and not IE. And extract detectBrowser() as a new function
format
consider all circumstances of browser.
use "===" instead of '=='
make 'navigator.userAgent.toLocaleLowerCase()' a local variable
optimize
Added comments on const 'STICK_START_CLASS' and 'STICK_END_CLASS'.
change their content to cdk-sticky-header-start and cdk-sticky-header-end
Added comments for STICK_START_CLASS and STICK_END_CLASS.
Changed the format of one-line JsDoc
unsubscribe sbscriptions onDestory
Use what modernizr does on compatibility instead of get the browser version directly.
add 'padding' and 'stickyRegionHeight' variables to avoid calling 'getComputedStyle()' too many times (which is expensive).
move docs above @directive
removed the underscore in'_element: ElementRef',
expand 'reg' to 'region'
use 'if (this.isIE)' instead of 'if(this.isIE === true)'
added more newlines between params in 'generateCssStyle()' function to make it easier to understand.
Added reference link to Modernizer in docs of getSupportList()
Deleted "_supportList" variable
renamed 'isIE' to 'isStickyPositionSupported', and removed extra space before Observable
Set debounce time as a const variable
Added docs for 'const DEBOUNCE_TIME: number = 5;'
Changed ' if(this.stickyParent == null)' to ' if(!this.stickyParent)'
Removed the @PARAM and @returns and make sure the types are correct in the function signature in 'generateCssStyle(...)' function
Added docs for `isStickyPositionSupported` variable
changed '+=' to '=' of 'stickyText' in getSupportList() function
nit added " " between 'if' and '('
nit
Added comments
deleted unused import
change comments
optimize comments
deleted unnecessary global variables(padding and stickyRegionHeight)
Added check whether we are on browser
Array<string> to string[]
test?
try to reopen the old PR
fix after rebase
revert list.ts
test
test 222
revert demo
revert list.ts second time
Move code to 'src/cdk'
revert 'move code to 'src/cdk'' , it should be done in a new PR
revert
avoid calling 'getComputedStyle()' too many times.
rename as sticky-header.ts
imported PlatformModule
Add blank lines between these top-level symbol
make '_isStickyPositionSupported' private
Changed the originalCSS to private and use '{} as CSSStyleDeclaration' instead of ''any.
Rename '_containerStart' to '_stickyRegionTop'
rename
optimize discription for '_stickyRegionBottomThreshold'
private _originalStyles = {
position: '',
top: '',
right: '',
left: '',
bottom: '',
width: '',
zIndex: ''};
Deleted 'generateCssStyle()' and 'getCssNumber()' function
Deleted 'getCssValue()' function
fix CSSStyleDeclaration
change sticky width to 'this.upperScrollableContainer.clientWidth'
fix
nit
Added the 'isPositionStickySupported() ' function to src/cdk/platform/features.ts.
Consume that function in this component and just always use both the webkit and unprefixed styles.
nit
nit
update doc 'Debounce time in milliseconds for events that affect the sticky positioning (e.g. scroll, resize, touch move). Set as 5 milliseconds which is the highest delay that doesn't drastically affect the positioning adversely.'
changed the doc to '/** z-index to be applied to the sticky header (default is 10). */'
fix tslint error
for comment 'Can you evaluate each method to make sure their accessor privacy is right? E.g. see which functions need to be public, private, static, etc'
Deleted variable 'elemHeight'
Chaned to 'if (!this.stickyParent)'
Simplified Docs for 'sticker()'.
set 'defineRestriction()' function to private
use 'RxChain'
deleted unused 'tableModule' in modules.ts
rename to '_isPositionStickySupported'
Use // for comments, /* */ for docs
@angular/cdk
rename : values -> headerStyles
Move closing brace to the next line
optimized: [this._onScrollSubscription, this._onScrollSubscription, this._onResizeSubscription]
.forEach(s => s && s.unsubscribe());
You should be able to do just '0' instead of '0px'
Format like TODO(sllethe): ...
private _attachEventListeners? Add a description like "Add listeners for events that affect sticky positioning."
optimize doc
Rename 'defineRestrictions' to '_measureStickyRegionBounds'
rename: private _resetElementStyles
let stuckRight: any = this.upperScrollableContainer.getBoundingClientRect().right;
chaned 'any' to 'number'
nit
change doc '/**
* Unsticks the header so that it goes back to scrolling normally.
*
* This should be called when the element reaches the bottom of its cdkStickyRegion so that it
* smoothly scrolls out of view as the next sticky-header moves in.
*/'
_unstuckElement -> _unstickElement
rename 'sticker()' to '_applyStickyPositionStyles()'
rename 'defineRestrictionsAndStick()' to '_updateStickyPositioning()'
* added tests for sticky-header
* deleted
* removed 'deps' in providers
* put provider in index
* optimize provider
* Removed unused 'fixture.detectChanges()' in test
* fix
* You can remove when sticky positioning is not supported since it's in describe
* stickyHeaderDir.stickyParent
* remove commented code
* rename stickyHeaderDir to stickyHeader
* Changed to use 'ngFor' to expand content instead of typing tons of '<p></p>'
* Add a comment that explains what these inline styles are for? Any reason you can't set them via the styles configuration for the component?
* Added explainations on styles
* Added /** @docs-private */
* Added comments to explaining why tick(100) is needed. Changed 'tick(0)' to 'tick()'
* nit
* explained why need 'tick(100)'
* expect(/sticky/i.test(position!)).toBe(true);
* change CSS indent to +2
* nit
* Added test for sticky-header without StickyRegion
* change 'toBe(null)' to 'toBeNull()'
* Cool ! tick(debounce time)
sllethe added a commit to sllethe/material2 that referenced this pull request Aug 10, 2017
@sllethe
# This is a combination of 4 commits.
114cbd9
# This is the 1st commit message:
add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
sticky-header-rebased
add one test &&
fixed bug 'sticky-header not working on iPhone', and bug 'reshape too obviously when being sticked'. &&
made some change according to the design doc('md-stick --> cdkSticky')
make the sticky element being scrolled up smoothly when being unsticked
Add code to support optional parentRegion input
add
add unit test for sticky-header
add e2e/sticky-header files
e2e test
clear code
master
sticky-header-rebased
Add code to support optional parentRegion input
add e2e/sticky-header files
e2e test
clear code
fix
encapsulate reset css style operation for sticky header.
sticky-header-rebased
Add code to support optional parentRegion input
add e2e/sticky-header files
e2e test
clear code
master
sticky-header-rebased
Add code to support optional parentRegion input
add e2e/sticky-header files
e2e test
clear code
fix
delete unused files
encapsulate reset css style operation for sticky header.
sticky-header-rebased
Add code to support optional parentRegion input
add unit test for sticky-header
add e2e/sticky-header files
e2e test
clear code
master
sticky-header-rebased
Add code to support optional parentRegion input
add e2e/sticky-header files
e2e test
clear code
fix
encapsulate reset css style operation for sticky header.
sticky-header-rebased
Add code to support optional parentRegion input
add e2e/sticky-header files
e2e test
clear code
master
sticky-header-rebased
Add code to support optional parentRegion input
add e2e/sticky-header files
e2e test
clear code
fix
clean unused files
delete sticky-header
delete styicky-heade demo
delete sticky-header lib
revert public_api
delete sticky-header e2e files
delete.firebasesrc
revert
revert
revert
revert
add css styles for selection-list
add selection-list structures in list.ts
initial version of selection-list all src/lib code
fix tslint error
fix tslint error
applied '[class.mat-list-item-content-reverse]="checkboxPosition == 'after'"', deleted comments in code
Deleted 'MdSelectionListCssMatStyler' class
Added doc for 'md-selection-option'
Added binding expression for 'attr.aria-selected' and 'attr.aria-disabled'
Added a value and a disabled @input() property
Changed 'isSelected' to 'selected'. And added '@input(selected)' for it.(Using 'coerceBooleanProperty')
changed '_slist' to 'selectionList' and deleted 'MdSelectionListCheckboxer' class
Deleted navList in selection-list-option
changed 'onchange()' to toggle(). And added doc for it
checkedItems -> selectedOptions
deleted 'pCheckbox' and store 'this' instead of HTMLelement in 'optionlist'
optimized toggle() with 'this._selected = !this._selected'
Added 'Tab' moves focus on selection-list, 'UP_ARROW' and 'DOWN_ARROW' moves focus within selection-list. And use 'SPACE' to select checkbox
Added another empty line at the end of each file
remove comment line in CSS file
Deleted 'webkit-justify-content' in CSS file
Deleted 'mat-list-item-content-reverse' to these existing styles; the 'mat-list-item-content-reverse' class should only have the extra styles you need to reverse the display
Deleted 'mat-list-item-content' and 'mat-list-item-content-reverse' and '<a>' styles in '.mat-selection-list'
Deleted unused 'mat-checkbox' class
add ".mat-list-option" class in css file
added 'mat-list-option' class
fix toggle() disabled
Deleted empty class
Deleted unused import
Removed 'if (this.selectable)' check
moved styles in '.mat-selection-list .mat-list-item' to '.mat-list-option'.
Deleted position, box-sizing, and height in '.mat-list-item-content-reverse' in list.scss file
put md-selection-list and md-list-option in separate files(selection-list.ts and list-option.ts)
# This is the commit message angular#2:
nit
# This is the commit message angular#3:
correct imports in index.ts
# This is the commit message angular#4:
use ' @ContentChildren(MdListOption) options;' instead of QueryList
mmalerba pushed a commit that referenced this pull request Aug 12, 2017
@sllethe@mmalerba
feat(selection-list): Selection-list initial version all code(without…
dccce1c
… demo) (#5562)
* # This is a combination of 4 commits.
# This is the 1st commit message:
add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
sticky-header-rebased
add one test &&
fixed bug 'sticky-header not working on iPhone', and bug 'reshape too obviously when being sticked'. &&
made some change according to the design doc('md-stick --> cdkSticky')
make the sticky element being scrolled up smoothly when being unsticked
Add code to support optional parentRegion input
add
add unit test for sticky-header
add e2e/sticky-header files
e2e test
clear code
master
sticky-header-rebased
Add code to support optional parentRegion input
add e2e/sticky-header files
e2e test
clear code
fix
encapsulate reset css style operation for sticky header.
sticky-header-rebased
Add code to support optional parentRegion input
add e2e/sticky-header files
e2e test
clear code
master
sticky-header-rebased
Add code to support optional parentRegion input
add e2e/sticky-header files
e2e test
clear code
fix
delete unused files
encapsulate reset css style operation for sticky header.
sticky-header-rebased
Add code to support optional parentRegion input
add unit test for sticky-header
add e2e/sticky-header files
e2e test
clear code
master
sticky-header-rebased
Add code to support optional parentRegion input
add e2e/sticky-header files
e2e test
clear code
fix
encapsulate reset css style operation for sticky header.
sticky-header-rebased
Add code to support optional parentRegion input
add e2e/sticky-header files
e2e test
clear code
master
sticky-header-rebased
Add code to support optional parentRegion input
add e2e/sticky-header files
e2e test
clear code
fix
clean unused files
delete sticky-header
delete styicky-heade demo
delete sticky-header lib
revert public_api
delete sticky-header e2e files
delete.firebasesrc
revert
revert
revert
revert
add css styles for selection-list
add selection-list structures in list.ts
initial version of selection-list all src/lib code
fix tslint error
fix tslint error
applied '[class.mat-list-item-content-reverse]="checkboxPosition == 'after'"', deleted comments in code
Deleted 'MdSelectionListCssMatStyler' class
Added doc for 'md-selection-option'
Added binding expression for 'attr.aria-selected' and 'attr.aria-disabled'
Added a value and a disabled @input() property
Changed 'isSelected' to 'selected'. And added '@input(selected)' for it.(Using 'coerceBooleanProperty')
changed '_slist' to 'selectionList' and deleted 'MdSelectionListCheckboxer' class
Deleted navList in selection-list-option
changed 'onchange()' to toggle(). And added doc for it
checkedItems -> selectedOptions
deleted 'pCheckbox' and store 'this' instead of HTMLelement in 'optionlist'
optimized toggle() with 'this._selected = !this._selected'
Added 'Tab' moves focus on selection-list, 'UP_ARROW' and 'DOWN_ARROW' moves focus within selection-list. And use 'SPACE' to select checkbox
Added another empty line at the end of each file
remove comment line in CSS file
Deleted 'webkit-justify-content' in CSS file
Deleted 'mat-list-item-content-reverse' to these existing styles; the 'mat-list-item-content-reverse' class should only have the extra styles you need to reverse the display
Deleted 'mat-list-item-content' and 'mat-list-item-content-reverse' and '<a>' styles in '.mat-selection-list'
Deleted unused 'mat-checkbox' class
add ".mat-list-option" class in css file
added 'mat-list-option' class
fix toggle() disabled
Deleted empty class
Deleted unused import
Removed 'if (this.selectable)' check
moved styles in '.mat-selection-list .mat-list-item' to '.mat-list-option'.
Deleted position, box-sizing, and height in '.mat-list-item-content-reverse' in list.scss file
put md-selection-list and md-list-option in separate files(selection-list.ts and list-option.ts)
# This is the commit message #2:
nit
# This is the commit message #3:
correct imports in index.ts
# This is the commit message #4:
use ' @ContentChildren(MdListOption) options;' instead of QueryList
* add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
sticky-header-rebased
add one test &&
fixed bug 'sticky-header not working on iPhone', and bug 'reshape too obviously when being sticked'. &&
made some change according to the design doc('md-stick --> cdkSticky')
make the sticky element being scrolled up smoothly when being unsticked
Add code to support optional parentRegion input
add
add unit test for sticky-header
add e2e/sticky-header files
e2e test
clear code
master
sticky-header-rebased
Add code to support optional parentRegion input
add e2e/sticky-header files
e2e test
clear code
fix
encapsulate reset css style operation for sticky header.
sticky-header-rebased
Add code to support optional parentRegion input
add e2e/sticky-header files
e2e test
clear code
master
sticky-header-rebased
Add code to support optional parentRegion input
add e2e/sticky-header files
e2e test
clear code
fix
delete unused files
encapsulate reset css style operation for sticky header.
sticky-header-rebased
Add code to support optional parentRegion input
add unit test for sticky-header
add e2e/sticky-header files
e2e test
clear code
master
sticky-header-rebased
Add code to support optional parentRegion input
add e2e/sticky-header files
e2e test
clear code
fix
encapsulate reset css style operation for sticky header.
sticky-header-rebased
Add code to support optional parentRegion input
add e2e/sticky-header files
e2e test
clear code
master
sticky-header-rebased
Add code to support optional parentRegion input
add e2e/sticky-header files
e2e test
clear code
fix
clean unused files
delete sticky-header
delete styicky-heade demo
delete sticky-header lib
revert public_api
delete sticky-header e2e files
delete.firebasesrc
revert
revert
revert
revert
add css styles for selection-list
add selection-list structures in list.ts
initial version of selection-list all src/lib code
fix tslint error
fix tslint error
applied '[class.mat-list-item-content-reverse]="checkboxPosition == 'after'"', deleted comments in code
Deleted 'MdSelectionListCssMatStyler' class
Added doc for 'md-selection-option'
Added binding expression for 'attr.aria-selected' and 'attr.aria-disabled'
Added a value and a disabled @input() property
Changed 'isSelected' to 'selected'. And added '@input(selected)' for it.(Using 'coerceBooleanProperty')
changed '_slist' to 'selectionList' and deleted 'MdSelectionListCheckboxer' class
Deleted navList in selection-list-option
changed 'onchange()' to toggle(). And added doc for it
checkedItems -> selectedOptions
deleted 'pCheckbox' and store 'this' instead of HTMLelement in 'optionlist'
optimized toggle() with 'this._selected = !this._selected'
Added 'Tab' moves focus on selection-list, 'UP_ARROW' and 'DOWN_ARROW' moves focus within selection-list. And use 'SPACE' to select checkbox
Added another empty line at the end of each file
remove comment line in CSS file
Deleted 'webkit-justify-content' in CSS file
Deleted 'mat-list-item-content-reverse' to these existing styles; the 'mat-list-item-content-reverse' class should only have the extra styles you need to reverse the display
Deleted 'mat-list-item-content' and 'mat-list-item-content-reverse' and '<a>' styles in '.mat-selection-list'
Deleted unused 'mat-checkbox' class
add ".mat-list-option" class in css file
added 'mat-list-option' class
fix toggle() disabled
Deleted empty class
Deleted unused import
Removed 'if (this.selectable)' check
moved styles in '.mat-selection-list .mat-list-item' to '.mat-list-option'.
Deleted position, box-sizing, and height in '.mat-list-item-content-reverse' in list.scss file
put md-selection-list and md-list-option in separate files(selection-list.ts and list-option.ts)
nit
correct imports in index.ts
use ' @ContentChildren(MdListOption) options;' instead of QueryList
change to check 'focusedIndex != null'.
Set The tabindex of list option as -1 when the selection-list is disabled
change ['class': 'mat-list-item, mat-list-option',] to ['class': 'mat-list-item mat-list-option',];
Don't want a comma between class names.
fix typo in comments
fix
Binded 'aria-disabled' for selection-list.ts
rename to '_optionsChangeSubscription'
typo
Instead of defining the disabled getter/setter yourself, you can include it via mixin.
Removed ' selectable' property
Deleted unnecessary 'this._isValidIndex(optionIndex)' check
import switchMap
Added SwitchMerge
nit
revert
revert
revert2
revert3
r4
r5
r2
r3
r4
r5
revert
fix rxjs import
Changed to use 'RxChain' instead of directly importing 'observer/add/'
delete unusd import
Added exports for selectionlist
fix tslint check
fix tslint check
fix tslint check
Add tests for selection-list and list-option
fix typo in test
Added new test on native element's focus & blur
Added check expect(selectList.selected.length).toBe(0);before the toggle
nit
Added test on desecting an option
fix tslink check
fix typo in doc
refine docs
fix 'What happens if the selection list is disabled later? Would the list option become disabled?'
Changed all the test name to the format of 'should ...'
rename
Deleted unused '_tabOutSubscription'
return RxChain.from(this.options.changes)...
fix tsLint check
fix tslint
fix tslint error
test can not pass on travel CI
fix travelCI check
try to fix nativeElement focus test
revert
fix test
fix travis CI error
fixing travis
fixed~!
update fix
fix
fix
fix2
fix
added test check on 'aria-selected'
Added test checkou on 'aria-disabled'
reformat structure
changed to 'if (!fixture.componentInstance.isIE) { ... }'
Change 'platform.SAFARI || platform.EDGE || platform.FIREFOX' to '!platform.IS_TRIDENT'
fix travis check
Added aris-disabled test
fix travis test
put disabled style in theme.scss
use background color for disabled items
deselect --> deselected
destory -> destoryed
optimize
changed to "if (!this.disabled) { ... }"
restructured test cases
change function to private
_keydown
protected -> private
indent
change 'select' to 'selectChange'
Better to delete if (this.selectionList.disabled) {...} part
Use this.disabled to consider the case when parent selectionList is disabled?
Deleted emty lines
It would be better not to mutate the option disabled state based on the parent state; this can be error prone, as it's easy to miss updating one when the other changes. It's better to rely on the disabled getter for the option to account for the parent state.
* fix after rebase
* fix
* change 'grey, 1000' to 'black'
* remove unused import
* fix test
* put selection-list.ts and list-option.ts into one file~ and fix the test
* fix google3
* fix
* Add imports
* fix
* Deleted unused import
g1shin pushed a commit that referenced this pull request Aug 16, 2017
@jwshinjwshin
feat(stepper): Add support for linear stepper#2- each step as its o…
6ce8b9f
…wn form. (#6117)
* Add form control - consider each step as its own form group
* Comment edits
* Add 'valid' to MdStep for form validation
* Add [stepControl] to each step based on merging
* Changes based on review
g1shin pushed a commit that referenced this pull request Aug 16, 2017
@jwshinjwshin
feat(stepper): Add support for linear stepper#2- each step as its o…
90babef
…wn form. (#6117)
* Add form control - consider each step as its own form group
* Comment edits
* Add 'valid' to MdStep for form validation
* Add [stepControl] to each step based on merging
* Changes based on review
g1shin pushed a commit to g1shin/material2 that referenced this pull request Aug 22, 2017
@jwshinjwshin
feat(stepper): Add support for linear stepperangular#2- each step a…
a03b718
…s its own form. (angular#6117)
* Add form control - consider each step as its own form group
* Comment edits
* Add 'valid' to MdStep for form validation
* Add [stepControl] to each step based on merging
* Changes based on review
g1shin pushed a commit to g1shin/material2 that referenced this pull request Aug 22, 2017
@jwshinjwshin
feat(stepper): Add support for linear stepperangular#2- each step a…
5208aae
…s its own form. (angular#6117)
* Add form control - consider each step as its own form group
* Comment edits
* Add 'valid' to MdStep for form validation
* Add [stepControl] to each step based on merging
* Changes based on review
g1shin pushed a commit to g1shin/material2 that referenced this pull request Aug 22, 2017
@jwshinjwshin
feat(stepper): Add support for linear stepperangular#2- each step a…
4ce47b1
…s its own form. (angular#6117)
* Add form control - consider each step as its own form group
* Comment edits
* Add 'valid' to MdStep for form validation
* Add [stepControl] to each step based on merging
* Changes based on review
g1shin pushed a commit that referenced this pull request Aug 23, 2017
@jwshinjwshin
feat(stepper): Add support for linear stepper#2- each step as its o…
2a7e729
…wn form. (#6117)
* Add form control - consider each step as its own form group
* Comment edits
* Add 'valid' to MdStep for form validation
* Add [stepControl] to each step based on merging
* Changes based on review
mmalerba pushed a commit that referenced this pull request Aug 23, 2017
@jwshinjwshin@mmalerba
feat(stepper): Merge initial prototype of stepper into the upstream s…
1e51fae
…tepper branch. (#5742)
* Prototyping
* Further work
* Further prototyping
* Further prototyping
* Further work
* Adding event emitters
* Adding "selectedIndex" attribute to stepper and working on TemplateOulet.
* Prototyping
* Further work
* Further prototyping
* Further prototyping
* Further work
* Adding event emitters
* Template rendering and selectIndex control done.
* Work in progress for accessibility
* Added functionalities based on the tentative API doc.
* Refactor code for cdk-stepper and cdk-step
* Add support for templated label
* Added support for keyboard events and focus changes for accessibility.
* Updated vertical stepper + added comments
* Fix package-lock.json
* Fix indention
* Changes made based on the review
* Changes based on review - event properties, selectors, SPACE support, etc. + demo
* Add select() for step component + refactor to avoid circular dependency + support cycling using arrow keys
* API change based on review
* Minor code clean up based on review.
* Several name changes, etc based on review
* Add to compatibility mode list and refactor to avoid circular dependency
feat(stepper): Create stepper button directives to enable adding buttons to stepper (#5951)
* Create stepper button directives to enable adding buttons to stepper
* Changes made based on review
* Minor changes with click handlers
Build changes
feat(stepper): Add initial styles to stepper based on Material guidelines (#6242)
* Add initial styles to stepper based on Material guidelines
* Fix flex-shrink and min-width
* Changes made based on review
* Fix alignment
* Margin modifications
feat(stepper): Add support for linear stepper (#6116)
* Add form controls and custom error state matcher
* Modify form controls for stepper-demo and add custom validator
* Move custom step validation function so that users can simply import and use
* Implement @input() stepControl for each step
* Add linear attribute to stepper
* Add enabling/disabling linear state of demo
feat(stepper): Add animation to stepper (#6361)
* Add animation
* Implement Angular animation
* Clean up unnecessary code
* Generalize animation so that vertical and horizontal steppers can use the same function
Rebase onto upstream/master
feat(stepper): Add unit tests for stepper (#6428)
* Add unit tests for stepper
* Changes made based on review
* More changes based on review
feat(stepper): Add support for linear stepper #2 - each step as its own form. (#6117)
* Add form control - consider each step as its own form group
* Comment edits
* Add 'valid' to MdStep for form validation
* Add [stepControl] to each step based on merging
* Changes based on review
Fix focus logic and CSS changes (#6507)
feat(stepper): Add documentation for stepper (#6533)
* Documentation for stepper
* Revision based on review + add accessibility section
feat(stepper): Support additional properties for step (#6509)
* Additional properties for step
* Unit tests
* Code changes based on review + test name changes
* Refactor code for shared functionality between vertical and horizontal stepper
* Refactor md-step-header and md-step-content + optional step change
* Simplify code based on review
* Changes to step-header based on review
* Minor changes
Fix host style and demo page (#6592)
Revert package.json and package-lock.json
Changes made along with BUILD changes in google3
Add typography mixin
Changes to address aot compiler failures
fix rtl bugs
g1shin pushed a commit to g1shin/material2 that referenced this pull request Aug 31, 2017
@jwshinjwshin
feat(stepper): Merge initial prototype of stepper into the upstream s…
cb5b690
…tepper branch. (angular#5742)
* Prototyping
* Further work
* Further prototyping
* Further prototyping
* Further work
* Adding event emitters
* Adding "selectedIndex" attribute to stepper and working on TemplateOulet.
* Prototyping
* Further work
* Further prototyping
* Further prototyping
* Further work
* Adding event emitters
* Template rendering and selectIndex control done.
* Work in progress for accessibility
* Added functionalities based on the tentative API doc.
* Refactor code for cdk-stepper and cdk-step
* Add support for templated label
* Added support for keyboard events and focus changes for accessibility.
* Updated vertical stepper + added comments
* Fix package-lock.json
* Fix indention
* Changes made based on the review
* Changes based on review - event properties, selectors, SPACE support, etc. + demo
* Add select() for step component + refactor to avoid circular dependency + support cycling using arrow keys
* API change based on review
* Minor code clean up based on review.
* Several name changes, etc based on review
* Add to compatibility mode list and refactor to avoid circular dependency
feat(stepper): Create stepper button directives to enable adding buttons to stepper (angular#5951)
* Create stepper button directives to enable adding buttons to stepper
* Changes made based on review
* Minor changes with click handlers
Build changes
feat(stepper): Add initial styles to stepper based on Material guidelines (angular#6242)
* Add initial styles to stepper based on Material guidelines
* Fix flex-shrink and min-width
* Changes made based on review
* Fix alignment
* Margin modifications
feat(stepper): Add support for linear stepper (angular#6116)
* Add form controls and custom error state matcher
* Modify form controls for stepper-demo and add custom validator
* Move custom step validation function so that users can simply import and use
* Implement @input() stepControl for each step
* Add linear attribute to stepper
* Add enabling/disabling linear state of demo
feat(stepper): Add animation to stepper (angular#6361)
* Add animation
* Implement Angular animation
* Clean up unnecessary code
* Generalize animation so that vertical and horizontal steppers can use the same function
Rebase onto upstream/master
feat(stepper): Add unit tests for stepper (angular#6428)
* Add unit tests for stepper
* Changes made based on review
* More changes based on review
feat(stepper): Add support for linear stepper angular#2 - each step as its own form. (angular#6117)
* Add form control - consider each step as its own form group
* Comment edits
* Add 'valid' to MdStep for form validation
* Add [stepControl] to each step based on merging
* Changes based on review
Fix focus logic and CSS changes (angular#6507)
feat(stepper): Add documentation for stepper (angular#6533)
* Documentation for stepper
* Revision based on review + add accessibility section
feat(stepper): Support additional properties for step (angular#6509)
* Additional properties for step
* Unit tests
* Code changes based on review + test name changes
* Refactor code for shared functionality between vertical and horizontal stepper
* Refactor md-step-header and md-step-content + optional step change
* Simplify code based on review
* Changes to step-header based on review
* Minor changes
Fix host style and demo page (angular#6592)
Revert package.json and package-lock.json
Changes made along with BUILD changes in google3
Add typography mixin
Changes to address aot compiler failures
fix rtl bugs
g1shin pushed a commit to g1shin/material2 that referenced this pull request Aug 31, 2017
@jwshinjwshin
feat(stepper): Merge initial prototype of stepper into the upstream s…
ad63c0c
…tepper branch. (angular#5742)
* Prototyping
* Further work
* Further prototyping
* Further prototyping
* Further work
* Adding event emitters
* Adding "selectedIndex" attribute to stepper and working on TemplateOulet.
* Prototyping
* Further work
* Further prototyping
* Further prototyping
* Further work
* Adding event emitters
* Template rendering and selectIndex control done.
* Work in progress for accessibility
* Added functionalities based on the tentative API doc.
* Refactor code for cdk-stepper and cdk-step
* Add support for templated label
* Added support for keyboard events and focus changes for accessibility.
* Updated vertical stepper + added comments
* Fix package-lock.json
* Fix indention
* Changes made based on the review
* Changes based on review - event properties, selectors, SPACE support, etc. + demo
* Add select() for step component + refactor to avoid circular dependency + support cycling using arrow keys
* API change based on review
* Minor code clean up based on review.
* Several name changes, etc based on review
* Add to compatibility mode list and refactor to avoid circular dependency
feat(stepper): Create stepper button directives to enable adding buttons to stepper (angular#5951)
* Create stepper button directives to enable adding buttons to stepper
* Changes made based on review
* Minor changes with click handlers
Build changes
feat(stepper): Add initial styles to stepper based on Material guidelines (angular#6242)
* Add initial styles to stepper based on Material guidelines
* Fix flex-shrink and min-width
* Changes made based on review
* Fix alignment
* Margin modifications
feat(stepper): Add support for linear stepper (angular#6116)
* Add form controls and custom error state matcher
* Modify form controls for stepper-demo and add custom validator
* Move custom step validation function so that users can simply import and use
* Implement @input() stepControl for each step
* Add linear attribute to stepper
* Add enabling/disabling linear state of demo
feat(stepper): Add animation to stepper (angular#6361)
* Add animation
* Implement Angular animation
* Clean up unnecessary code
* Generalize animation so that vertical and horizontal steppers can use the same function
Rebase onto upstream/master
feat(stepper): Add unit tests for stepper (angular#6428)
* Add unit tests for stepper
* Changes made based on review
* More changes based on review
feat(stepper): Add support for linear stepper angular#2 - each step as its own form. (angular#6117)
* Add form control - consider each step as its own form group
* Comment edits
* Add 'valid' to MdStep for form validation
* Add [stepControl] to each step based on merging
* Changes based on review
Fix focus logic and CSS changes (angular#6507)
feat(stepper): Add documentation for stepper (angular#6533)
* Documentation for stepper
* Revision based on review + add accessibility section
feat(stepper): Support additional properties for step (angular#6509)
* Additional properties for step
* Unit tests
* Code changes based on review + test name changes
* Refactor code for shared functionality between vertical and horizontal stepper
* Refactor md-step-header and md-step-content + optional step change
* Simplify code based on review
* Changes to step-header based on review
* Minor changes
Fix host style and demo page (angular#6592)
Revert package.json and package-lock.json
Changes made along with BUILD changes in google3
Add typography mixin
Changes to address aot compiler failures
fix rtl bugs
@NicosoftNicosoft mentioned this pull request Nov 2, 2017
Closed
@rshelnuttrshelnutt mentioned this pull request Jul 30, 2018
Open
@marc-wilsonmarc-wilson mentioned this pull request Aug 31, 2018
Closed
@hannaseithehannaseithe mentioned this pull request Dec 14, 2018
Open
FirstVertex referenced this pull request in FirstVertex/material2 Feb 8, 2019
@relair
Merge pull request#2from angular/master
d1dae40
Merging changes from material
@lramondevlramondev mentioned this pull request Mar 25, 2019
Open
@andreElricoandreElrico mentioned this pull request Apr 25, 2019
Closed
@edjm1971edjm1971 mentioned this pull request Aug 16, 2019
Closed
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 5, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 5, 2019
zarend added a commit to zarend/components that referenced this pull request Feb 2, 2022
@zarend
fix(material/datepicker) debugging VoiceOver not reading date on Page…
5728dfb
…Down
Do not merge this pls. Debugging issue angular#2430.
There seems to be two issues
1. The screenreader focus doesn't not match the browser focus
2. the aria-live region is interfering with reading the focused element
Adds a timeout to fix#1, and removes the aria-live region to fixangular#2. This is not the final solution, requires more investigation...
Relates to angular#24330
zarend added a commit to zarend/components that referenced this pull request Feb 10, 2022
@zarend
fix(material/datepicker) debugging VoiceOver not reading date on Page…
fabafac
…Down
Do not merge this pls. Debugging issue angular#2430.
There seems to be two issues
1. The screenreader focus doesn't not match the browser focus
2. the aria-live region is interfering with reading the focused element
Adds a timeout to fix#1, and removes the aria-live region to fixangular#2. This is not the final solution, requires more investigation...
Relates to angular#24330
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yesPR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jelbourn@googlebot