Uh oh!
There was an error while loading. Please reload this page.
fix(overlay): proper backdrop stacking with multiple overlays - #2276
Merged
jelbourn merged 2 commits intoDec 20, 2016
Conversation
jelbourn
commented
Dec 19, 2016
Contributor
LGTM, I'm going to try to get that renaming PR in first |
Currently backdrops get inserted after their corresponding overlays in the DOM. This can lead to situations where another overlay that is technically lower in the stacking order could go above a backdrop (e.g. opening a `select` inside a `dialog`). These changes switch to doing the stacking by having the overlay and backdrop have the same `z-index` and determining the stacking order by the order of the elements in the DOM. Fixesangular#2272.
crisbetoforce-pushed
the
2272/overlay-backdrop-stacking
branch
from
December 20, 2016 08:46
7114888 to
c5de24fComparecrisbeto
commented
Dec 20, 2016
MemberAuthor
Seems like some of the tests started failing after I rebased from master. Investigating. |
crisbeto
commented
Dec 20, 2016
MemberAuthor
Alright, it's sorted out. I had to rename the selector to use the |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently backdrops get inserted after their corresponding overlays in the DOM. This can lead to situations where another overlay that is technically lower in the stacking order could go above a backdrop (e.g. opening a
selectinside adialog). These changes switch to doing the stacking by having the overlay and backdrop have the samez-indexand determining the stacking order by the order of the elements in the DOM.Fixes#2272.
Note: I'm expecting this to have some merge conflicts with #2258.