Skip to content

perf(cdk/overlay): add event listeners for overlay dispatchers outside of zone - #23962

Merged
zarend merged 1 commit into
angular:masterfrom
arturovt:perf/overlay-keyboard-dispatcher
Feb 3, 2022
Merged

perf(cdk/overlay): add event listeners for overlay dispatchers outside of zone#23962
zarend merged 1 commit into
angular:masterfrom
arturovt:perf/overlay-keyboard-dispatcher

Conversation

@arturovt

@arturovtarturovt commented Nov 14, 2021

Copy link
Copy Markdown
Contributor

The OverlayKeyboardDispatcher adds a keydown event listener, which causes Angular to run change detections on any keydown event, tho its listener may behave as a "noop" (e.g. if there're no keydownEvents observers).

With these changes, the Angular zone will be re-entered only if there're any keydownEvents listeners.

@google-clagoogle-claBot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 14, 2021
crisbeto
crisbeto reviewed Nov 14, 2021
View reviewed changes

@crisbetocrisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the CI appears to be failing.

Comment threadsrc/cdk/overlay/dispatchers/overlay-keyboard-dispatcher.spec.ts
Comment threadsrc/cdk/overlay/dispatchers/overlay-keyboard-dispatcher.ts Outdated
@arturovt
arturovt requested review from a team and crisbeto and removed request for a teamNovember 14, 2021 12:06
crisbeto
crisbeto reviewed Nov 14, 2021
View reviewed changes
Comment threadsrc/cdk/overlay/dispatchers/overlay-keyboard-dispatcher.spec.ts
Comment threadsrc/cdk/overlay/dispatchers/overlay-keyboard-dispatcher.spec.ts
Comment threadsrc/cdk/overlay/dispatchers/overlay-keyboard-dispatcher.ts Outdated
crisbeto
crisbeto reviewed Nov 14, 2021
View reviewed changes
Comment threadsrc/cdk/overlay/dispatchers/overlay-keyboard-dispatcher.spec.ts
Comment threadsrc/cdk/overlay/dispatchers/overlay-keyboard-dispatcher.spec.ts
Comment threadsrc/cdk/overlay/dispatchers/overlay-keyboard-dispatcher.ts Outdated
if (!this._isAttached) {
this._document.body.addEventListener('keydown', this._keydownListener);
this._ngZone
? this._ngZone.runOutsideAngular(() =>

@crisbetocrisbetoNov 14, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use an if/else statement here, rather than the ternary? Also can you leave an @breaking-change note here as well? That way our tooling will pick it up when we're doing the breaking changes.

@arturovtarturovtNov 15, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, done.

@arturovtarturovt changed the title perf(cdk/overlay): add keydown listener outside of zoneperf(cdk/overlay): add event listeners for overlay dispatchers outside of zoneNov 15, 2021
crisbeto
crisbeto approved these changes Nov 15, 2021
View reviewed changes

@crisbetocrisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbetocrisbeto added action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 15, 2021
@andrewseguinandrewseguin added needs rebase and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Dec 28, 2021
@zarend
zarend merged commit e761455 into angular:masterFeb 3, 2022
zarend pushed a commit that referenced this pull request Feb 3, 2022
@arturovt@zarend
perf(cdk/overlay): add event listeners for overlay dispatchers outsid…
d232f6b
…e of zone (#23962)
(cherry picked from commit e761455)
@arturovt
arturovt deleted the perf/overlay-keyboard-dispatcher branch February 3, 2022 19:14
zarend added a commit that referenced this pull request Feb 3, 2022
@zarend
Revert "perf(cdk/overlay): add event listeners for overlay dispatcher…
2a986c5
…s outside of zone (#23962)"
This reverts commit e761455.
@zarendzarend mentioned this pull request Feb 3, 2022
Merged
zarend added a commit that referenced this pull request Feb 3, 2022
@zarend
Revert "perf(cdk/overlay): add event listeners for overlay dispatcher…
e6b9679
…s outside of zone (#23962)" (#24353)
This reverts commit e761455.
zarend added a commit that referenced this pull request Feb 3, 2022
@zarend
Revert "perf(cdk/overlay): add event listeners for overlay dispatcher…
0181623
…s outside of zone (#23962)" (#24353)
This reverts commit e761455.
(cherry picked from commit e6b9679)
@zarend

zarend commented Feb 9, 2022

Copy link
Copy Markdown
Contributor

Hello @arturovt, this PR was reverted because it caused an issue internally. Could you please make a new PR with this change? That we can run a fresh presubmit check, then assess how best to proceed with this.

@arturovt

arturovt commented Feb 9, 2022

Copy link
Copy Markdown
ContributorAuthor

Hey @zarend , alright.

@arturovtarturovt mentioned this pull request Feb 14, 2022
Merged
amysorto pushed a commit to amysorto/components that referenced this pull request Feb 15, 2022
@arturovt@amysorto
perf(cdk/overlay): add event listeners for overlay dispatchers outsid…
564c592
…e of zone (angular#23962)
amysorto pushed a commit to amysorto/components that referenced this pull request Feb 15, 2022
@zarend@amysorto
Revert "perf(cdk/overlay): add event listeners for overlay dispatcher…
d820345
…s outside of zone (angular#23962)" (angular#24353)
This reverts commit e761455.
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Mar 12, 2022

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Mar 12, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbournjelbournAwaiting requested review from jelbourn
@crisbetocrisbetoAwaiting requested review from crisbeto

Assignees

No one assigned

Labels

action: mergeThe PR is ready for merge by the caretakerP3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenttarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arturovt@zarend@crisbeto@andrewseguin