Skip to content

fix(cdk/drag-drop): only block dragstart event on event targets - #24581

Merged
crisbeto merged 1 commit into
angular:masterfrom
crisbeto:24533/drag-drop-dragstart-handle
Mar 12, 2022
Merged

fix(cdk/drag-drop): only block dragstart event on event targets#24581
crisbeto merged 1 commit into
angular:masterfrom
crisbeto:24533/drag-drop-dragstart-handle

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Currently we block the dragstart event on the entire drag element which doesn't account for its disabled state and for any existing handles.

Fixes#24533.

Currently we block the `dragstart` event on the entire drag element which doesn't account for its disabled state and for any existing handles.
Fixesangular#24533.
@crisbetocrisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Mar 12, 2022
@crisbetocrisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 12, 2022
@crisbeto
crisbeto merged commit 45fae71 into angular:masterMar 12, 2022
crisbeto added a commit that referenced this pull request Mar 12, 2022
Currently we block the `dragstart` event on the entire drag element which doesn't account for its disabled state and for any existing handles.
Fixes#24533.
(cherry picked from commit 45fae71)
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 23, 2022
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.2.6/13.3.0) |
| [@angular/material](https://github.com/angular/components) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.2.6/13.3.0) |
---
### Release Notes
<details>
<summary>angular/components</summary>
### [`v13.3.0`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1330-aluminum-armadillo-2022-03-16)
[Compare Source](angular/components@13.2.6...13.3.0)
##### cdk
| Commit | Type | Description |
| -- | -- | -- |
| [e4c64dd56](angular/components@e4c64dd) | fix | **drag-drop:** only block dragstart event on event targets ([#&#8203;24581](angular/components#24581)) |
##### material
| Commit | Type | Description |
| -- | -- | -- |
| [33d07df95](angular/components@33d07df) | fix | **badge:** ensure overflow visible ([#&#8203;24602](angular/components#24602)) |
| [dfef17351](angular/components@dfef173) | fix | **datepicker:** fix Voiceover losing focus on PageDown ([#&#8203;24399](angular/components#24399)) |
| [1703b83ae](angular/components@1703b83) | fix | **datepicker:** use cdk-visually-hidden on calendar header ([#&#8203;24523](angular/components#24523)) |
| [41320d07e](angular/components@41320d0) | fix | **tabs:** avoid timeouts in background tabs ([#&#8203;24000](angular/components#24000)) |
##### material-experimental
| Commit | Type | Description |
| -- | -- | -- |
| [097ec0d11](angular/components@097ec0d) | fix | **mdc-core:** add app background color ([#&#8203;22992](angular/components#22992)) |
| [15a0676d5](angular/components@15a0676) | fix | **mdc-radio:** add hover indication ([#&#8203;24595](angular/components#24595)) |
#### Special Thanks
Andrew Seguin, Kristiyan Kostadinov, Paul Gschwendtner and Zach Arend
<!-- CHANGELOG SPLIT MARKER -->
</details>
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1229
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
…lar#24581)
Currently we block the `dragstart` event on the entire drag element which doesn't account for its disabled state and for any existing handles.
Fixesangular#24533.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Apr 12, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakerP3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenttarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(@angular/cdk): dragStart event completely blocked within cdkDrag element

2 participants

@crisbeto@devversion