Skip to content

fix(material/datepicker): announce the "to" when reading year range - #24958

Merged
zarend merged 1 commit into
angular:mainfrom
zarend:datepicker-to
Sep 19, 2022
Merged

fix(material/datepicker): announce the "to" when reading year range#24958
zarend merged 1 commit into
angular:mainfrom
zarend:datepicker-to

Conversation

@zarend

@zarendzarend commented May 23, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor
fix(material/datepicker): announce the "to" when reading year range
Create period button's `aria-description` using `formatYearRangeLabel`
method. Format year range in a TTS friendly way (e.g. "2019 to 2020").
Previously, some screen readers would announce the range as "2019 2020".
Fixes #23467.

@zarendzarend added Accessibility This issue is related to accessibility (a11y) target: minor This PR is targeted for the next minor release area: material/datepicker dev-app preview When applied, previews of the dev-app are deployed to Firebase labels May 23, 2022
@github-actions

github-actionsBot commented May 23, 2022•
edited
Loading

Copy link
Copy Markdown

Deployed dev-app to: https://ng-comp-dev--pr-24958-63c304508e133feea032935c14ad9429-lsqxjkw0.web.app

mmalerba
mmalerba reviewed May 24, 2022
View reviewed changes
Comment threadsrc/material/datepicker/calendar-header.html Outdated
@zarend
zarend requested a review from mmalerbaMay 25, 2022 20:11
@zarend
zarendforce-pushed the datepicker-to branch 2 times, most recently from 2bd390e to 2bba0e1CompareJune 7, 2022 20:39
@zarendzarend added the action: merge The PR is ready for merge by the caretaker label Jun 8, 2022
@zarend
zarendforce-pushed the datepicker-to branch 2 times, most recently from e5f67ca to d7114adCompareSeptember 17, 2022 00:24
@zarend
fix(material/datepicker): announce the "to" when reading year range
354a490
Create period button's `aria-description` using `formatYearRangeLabel`
method. Format year range in a TTS friendly way (e.g. "2019 to 2020").
Previously, some screen readers would announce the range as "2019 2020".
Fixesangular#23467.
@zarend
zarend merged commit 2704c31 into angular:mainSep 19, 2022
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Oct 20, 2022

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Oct 20, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbetocrisbetoAwaiting requested review from crisbeto
1 more reviewer
@mmalerbammalerbammalerba approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@zarendzarend

Labels

AccessibilityThis issue is related to accessibility (a11y)action: mergeThe PR is ready for merge by the caretakerarea: material/datepickerdev-app previewWhen applied, previews of the dev-app are deployed to Firebasetarget: minorThis PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zarend@mmalerba