Skip to content

fix(autocomplete): placeholder should float while panel is open - #2730

Merged
kara merged 1 commit into
angular:autocompletefrom
kara:autocomplete-placeholder
Feb 3, 2017
Merged

fix(autocomplete): placeholder should float while panel is open#2730
kara merged 1 commit into
angular:autocompletefrom
kara:autocomplete-placeholder

Conversation

@kara

@karakara commented Jan 20, 2017

Copy link
Copy Markdown
Contributor

Ready for review

r: @jelbourn

@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 20, 2017
@kara
karaforce-pushed the autocomplete-placeholder branch from 1939a7e to ebe2fedCompareJanuary 25, 2017 01:58

@andrewseguinandrewseguin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@andrewseguinandrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 30, 2017
@karakara removed the action: merge The PR is ready for merge by the caretaker label Jan 30, 2017
@kara
karaforce-pushed the autocomplete-placeholder branch from ebe2fed to cfc7c55CompareFebruary 3, 2017 02:30
@karakara added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Feb 3, 2017
@kara
kara merged commit 1eebca9 into angular:autocompleteFeb 3, 2017
@gedclack

Copy link
Copy Markdown

Hi, I am new in github and also new to angular,
I met this situation where Input's placeholder still floats even after I set floatPlaceholder="never" in the <md-input-container>, is this intentional according to this commit ?

@dahaupt

Copy link
Copy Markdown

@gedclack If you have a question you can ask it in https://gitter.im/angular/material2 and in case you think it's an issue in the library, you can open an issue.

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 6, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@kara@gedclack@dahaupt@andrewseguin@jelbourn@googlebot