Skip to content

fix(select): view not updating when using OnPush detection strategy - #2894

Merged
tinayuangao merged 1 commit into
angular:masterfrom
crisbeto:select-on-push
Feb 9, 2017
Merged

fix(select): view not updating when using OnPush detection strategy#2894
tinayuangao merged 1 commit into
angular:masterfrom
crisbeto:select-on-push

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Fixes the select's view not being updated when the value is set through a component that has its change detection set to OnPush.

Fixes#2663.
Fixes#2269.

Fixes the select's view not being updated when the value is set through a component that has its change detection set to `OnPush`.
Fixesangular#2663.
Fixesangular#2269.
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 1, 2017
kara
kara approved these changes Feb 7, 2017

@karakara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karakara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 7, 2017
@karakara removed their assignment Feb 7, 2017
@tinayuangao
tinayuangao merged commit 3bcb7c3 into angular:masterFeb 9, 2017
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 6, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ChangeDetectionStrategy.OnPush problem Bug: Select doesn't have initial value when change detection set to onPush

4 participants

@crisbeto@kara@googlebot@tinayuangao