Uh oh!
There was an error while loading. Please reload this page.
Preview popover fixes - #28976
Conversation
7b2b8bb to
fd11606CompareAfter angular#28945 the preview is inserted into a `popover` element which has a user agent styling of `color: canvastext`. These changes reset it to `inherit` to match the old behavior. Fixesangular#28974.
fd11606 to
d99f9f9CompareDeployed dev-app for c356f65 to: https://ng-dev-previews-comp--pr-angular-components-28976-dev-t3fgnong.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
| 'position': 'fixed', | ||
| 'top': '0', | ||
| 'left': '0', | ||
| 'z-index': this._zIndex + '', |
There was a problem hiding this comment.
do we need z-index if its in a popover?
There was a problem hiding this comment.
We still have it, because there's a public API to set it and in case we're running on a browser that doesn't support popovers.
There was a problem hiding this comment.
I think all the browsers we support also support popover, but I guess we can leave it until we deprecate the zindex API
Uh oh!
There was an error while loading. Please reload this page.
d99f9f9 to
c356f65CompareSwitches back to positioning the preview directly instead of using a wrapper which can be breaking for existing apps. Instead we load a stylesheet dynamically with the necessary resets.
c356f65 to
53fd236CompareThis issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Includes the following fixes related the preview popovers:
fix(cdk/drag-drop): reset user agent color on preview popover
After #28945 the preview is inserted into a
popoverelement which has a user agent styling ofcolor: canvastext. These changes reset it toinheritto match the old behavior.fix(cdk/drag-drop): remove preview wrapper
Switches back to positioning the preview directly instead of using a wrapper which can be breaking for existing apps. Instead we load a stylesheet dynamically with the necessary resets.
Fixes#28974.