Uh oh!
There was an error while loading. Please reload this page.
feat(dialog): support open with TemplateRef - #2910
Conversation
| /** | ||
| * Moves the focus inside the focus trap. | ||
| * @private |
There was a problem hiding this comment.
Can remove the @private part of the jsdoc since its in the function signature
andrewseguin
commented
Feb 3, 2017
Can you add a test for using template. LGTM otherwise, add merge ready when you are good with it |
fxck
commented
Feb 4, 2017
Is this replacement for #2853 then? Should I make a PR with stuff discussed here #2853 (comment) after this PR and this PR gets merged(it needs rebase again btw @crisbeto)? How does merging workflow in this repository work anyway? Do you merge PRs labelled merge ready once per two weeks? |
mmalerba
commented
Feb 5, 2017
@fxck Ah my bad, I didn't realize there was already a PR in progress for this. Let me take a look at yours. I'm hoping to get this feature in soon so I can use it for datepicker. Removed merge-ready until I have a chance to compare |
@mmalerba the main difference is that I created a new method |
mmalerba
commented
Feb 6, 2017
@fxck Ok, lets merge this one and then do another PR to add the observables you want. |
Splaktar
commented
May 4, 2017
It would have been really nice to include an update to the docs for this feature. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.