Skip to content

fix(cdk/testing): TestbedHarnessEnvironment should work when Zone is … - #29176

Merged
amysorto merged 1 commit into
angular:mainfrom
atscott:testbedharnessenv
Jun 4, 2024
Merged

fix(cdk/testing): TestbedHarnessEnvironment should work when Zone is …#29176
amysorto merged 1 commit into
angular:mainfrom
atscott:testbedharnessenv

Conversation

@atscott

@atscottatscott commented Jun 3, 2024

Copy link
Copy Markdown
Contributor

…not present

This commit fixes the harness environment which assumes Zone is always defined on the page.

@atscott
atscottforce-pushed the testbedharnessenv branch from c539194 to 19322dfCompareJune 3, 2024 18:02
@atscott
fix(cdk/testing): TestbedHarnessEnvironment should work when Zone is …
1cf4e29
…not present
This commit fixes the harness environment which assumes Zone is always
defined on the page.
@atscott
atscottforce-pushed the testbedharnessenv branch from 19322df to 1cf4e29CompareJune 3, 2024 18:09
mmalerba
mmalerba approved these changes Jun 3, 2024
View reviewed changes

@mmalerbammalerba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerbammalerba added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 3, 2024
@amysorto
amysorto removed the request for review from devversionJune 4, 2024 18:05
@amysorto
amysorto merged commit f4387fd into angular:mainJun 4, 2024
amysorto pushed a commit that referenced this pull request Jun 4, 2024
@atscott@amysorto
fix(cdk/testing): TestbedHarnessEnvironment should work when Zone is …
5ef11b1
…not present (#29176)
This commit fixes the harness environment which assumes Zone is always
defined on the page.
(cherry picked from commit f4387fd)
@ambrose40ambrose40 mentioned this pull request Jun 27, 2024
Open
@AddinAddin mentioned this pull request Jul 1, 2024
Closed
@hantsyhantsy mentioned this pull request Jul 4, 2024
Closed
@ambrose40ambrose40 mentioned this pull request Jul 4, 2024
Open
@sanjayrajeshsanjayrajesh mentioned this pull request Jul 4, 2024
Open
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Jul 5, 2024

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Jul 5, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@mmalerbammalerbammalerba approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: mergeThe PR is ready for merge by the caretakertarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atscott@mmalerba@amysorto