Skip to content

fixed show scrollbar in preview of the last element - #29450

Merged
crisbeto merged 1 commit into
angular:mainfrom
josuVazquez:fix/docs-bug-drag-drop-scrollbar
Jul 18, 2024
Merged

fixed show scrollbar in preview of the last element#29450
crisbeto merged 1 commit into
angular:mainfrom
josuVazquez:fix/docs-bug-drag-drop-scrollbar

Conversation

@josuVazquez

Copy link
Copy Markdown
Contributor

The style border-bottom: solid 1px #ccc; was initially applied to all elements with the class example-box, except for the last child which had its border removed with border: none. However, when the last element was dragged, it lost the border: none style and regained the border-bottom: 1px solid #ccc, causing the scrollbar to appear.

To fix this issue, I applied border: none to the class cdk-drag-preview. This ensures that all dragged elements lose their border-bottom, preventing the scrollbar from appearing during the drag operation.

Fixes#29419

@josuVazquez
josuVazquez requested a review from a team as a code ownerJuly 17, 2024 18:32
@josuVazquez
josuVazquez requested review from amysorto and mmalerba and removed request for a teamJuly 17, 2024 18:32
@mmalerba
mmalerba requested review from crisbeto and removed request for mmalerbaJuly 17, 2024 21:21
@josuVazquez
josuVazquezforce-pushed the fix/docs-bug-drag-drop-scrollbar branch from ce52102 to b6b0b5dCompareJuly 17, 2024 21:45
@crisbeto
crisbeto removed the request for review from amysortoJuly 18, 2024 07:52
@crisbetocrisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Jul 18, 2024
@crisbeto
crisbeto merged commit e517789 into angular:mainJul 18, 2024
crisbeto pushed a commit that referenced this pull request Jul 18, 2024
@josuVazquez
josuVazquez deleted the fix/docs-bug-drag-drop-scrollbar branch July 18, 2024 11:12
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Aug 18, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: mergeThe PR is ready for merge by the caretakermerge: fix commit messageWhen the PR is merged, rewrites/fixups of the commit messages are neededtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs-bug(drag-drop): Dragging last element in a list shows scrollbar in the preview.

2 participants

@josuVazquez@crisbeto