Skip to content

fix(cdk/drag-drop): positioning thrown off with align-self - #29813

Merged
crisbeto merged 1 commit into
angular:mainfrom
crisbeto:29809/drag-drop-inset
Oct 2, 2024
Merged

fix(cdk/drag-drop): positioning thrown off with align-self#29813
crisbeto merged 1 commit into
angular:mainfrom
crisbeto:29809/drag-drop-inset

Conversation

@crisbeto

@crisbetocrisbeto commented Oct 2, 2024

Copy link
Copy Markdown
Member

Fixes that the combination of setting align-self: center and the user agent styling of inset: 0 on popovers was breaking the positioning of the preview.

Fixes#29809.

@crisbeto
fix(cdk/drag-drop): positioning thrown off with align-self
c4541b0
Fixes that the combination of setting `align-self: center` and the user agent styling of `inset: 0` on popovers was breaking the positioning of the preview.
Fixesangular#29809.
@crisbetocrisbeto added the target: patch This PR is targeted for the next patch release label Oct 2, 2024
@crisbeto
crisbeto requested a review from a team as a code ownerOctober 2, 2024 09:13
@crisbeto
crisbeto requested review from mmalerba and wagnermaciel and removed request for a teamOctober 2, 2024 09:13
@crisbetocrisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 2, 2024
@crisbeto
crisbeto merged commit 5be8905 into angular:mainOct 2, 2024
crisbeto added a commit that referenced this pull request Oct 2, 2024
@crisbeto
fix(cdk/drag-drop): positioning thrown off with align-self (#29813)
3e1faec
Fixes that the combination of setting `align-self: center` and the user agent styling of `inset: 0` on popovers was breaking the positioning of the preview.
Fixes#29809.
(cherry picked from commit 5be8905)
This was referenced Oct 25, 2024
Open
Open
This was referenced Oct 25, 2024
Closed
Closed
This was referenced Nov 1, 2024
Open
Open
This was referenced Nov 1, 2024
Closed
Closed
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Nov 2, 2024

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Nov 2, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewseguinandrewseguinandrewseguin approved these changes

Assignees

No one assigned

Labels

action: mergeThe PR is ready for merge by the caretakertarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(cdk/drag-drop): Improper positioning of drag preview since it uses native popover (v17.3.6 and above)

2 participants

@crisbeto@andrewseguin