Uh oh!
There was an error while loading. Please reload this page.
fix(material/sort): simplify animations - #30057
Merged
Merged
Conversation
crisbeto
requested review from
amysorto and mmalerba
and removed request for
a teamNovember 21, 2024 10:33
For a long time the sort header's animation was set up by rendering out 4 `div` elements and then arranging them to look like an arrow. This is somewhat complicated to maintain, difficult to customize, in some cases it leads to weird visual bugs and ends up triggering excessive change detections. On top of that, because it depends on `@angular/animations`, it is prone to memory leaks (see angular/angular#54149). These changes aim to simplify the component and make it more robust by using an `svg` icon and dealing with the animations. Fixesangular#9758. Fixesangular#9844. Fixesangular#10088. Fixesangular#15451. Fixesangular#19441. Fixesangular#10242.
crisbetoforce-pushed
the
sort-animation-rework
branch
from
November 21, 2024 12:11
6fad88d to
775c7ceComparecrisbeto added a commit
that referenced
this pull request
Nov 27, 2024
For a long time the sort header's animation was set up by rendering out 4 `div` elements and then arranging them to look like an arrow. This is somewhat complicated to maintain, difficult to customize, in some cases it leads to weird visual bugs and ends up triggering excessive change detections. On top of that, because it depends on `@angular/animations`, it is prone to memory leaks (see angular/angular#54149). These changes aim to simplify the component and make it more robust by using an `svg` icon and dealing with the animations. Fixes#9758. Fixes#9844. Fixes#10088. Fixes#15451. Fixes#19441. Fixes#10242. (cherry picked from commit a08eeeb)
This was referenced Nov 28, 2024
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a long time the sort header's animation was set up by rendering out 4
divelements and then arranging them to look like an arrow. This is somewhat complicated to maintain, difficult to customize, in some cases it leads to weird visual bugs and ends up triggering excessive change detections. On top of that, because it depends on@angular/animations, it is prone to memory leaks (see angular/angular#54149).These changes aim to simplify the component and make it more robust by using an
svgicon and dealing with the animations using CSS.Fixes#7291.
Fixes#9758.
Fixes#9844.
Fixes#10088.
Fixes#15451.
Fixes#19441.
Fixes#10242.