Uh oh!
There was an error while loading. Please reload this page.
fix(material/expansion): switch away from animations module - #30119
Merged
Conversation
crisbetoforce-pushed
the
expansion-no-animations
branch
from
December 2, 2024 16:54
0c11393 to
1b0a288CompareDeployed dev-app for 99c87e8 to: https://ng-dev-previews-comp--pr-angular-components-30119-dev-wmtwncsw.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
crisbetoforce-pushed
the
expansion-no-animations
branch
4 times, most recently
from
December 3, 2024 10:26
f1deed4 to
01750c7Compareeneajaho
reviewed
Dec 4, 2024
Uh oh!
There was an error while loading. Please reload this page.
crisbetoforce-pushed
the
expansion-no-animations
branch
from
December 4, 2024 13:37
01750c7 to
99c87e8Comparecrisbeto
marked this pull request as ready for review
December 4, 2024 21:51
crisbeto
requested review from
amysorto and andrewseguin
and removed request for
a teamDecember 4, 2024 21:51
crisbetoforce-pushed
the
expansion-no-animations
branch
from
December 5, 2024 08:27
99c87e8 to
3e2306cComparecrisbetoforce-pushed
the
expansion-no-animations
branch
from
December 5, 2024 11:49
3e2306c to
bcfd6c3CompareReworks the expansion panel to animate purely with CSS, rather than going through the `@angular/animations` module. This simplifies the setup and allows us to resolve several long-standing bug reports. Fixesangular#27946. Fixesangular#22715. Fixesangular#21434. Fixesangular#20517. Fixesangular#17177. Fixesangular#16534. Fixesangular#16503. Fixesangular#14952. Fixesangular#14759. Fixesangular#14075. Fixesangular#11765.
crisbetoforce-pushed
the
expansion-no-animations
branch
from
December 5, 2024 12:02
bcfd6c3 to
b35c757Compareandrewseguin
approved these changes
Dec 5, 2024
crisbeto added a commit
that referenced
this pull request
Dec 5, 2024
Reworks the expansion panel to animate purely with CSS, rather than going through the `@angular/animations` module. This simplifies the setup and allows us to resolve several long-standing bug reports. Fixes#27946. Fixes#22715. Fixes#21434. Fixes#20517. Fixes#17177. Fixes#16534. Fixes#16503. Fixes#14952. Fixes#14759. Fixes#14075. Fixes#11765. (cherry picked from commit aafa151)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks the expansion panel to animate purely with CSS, rather than going through the
@angular/animationsmodule. This simplifies the setup and allows us to resolve several long-standing bug reports.Fixes#27946.
Fixes#22715.
Fixes#21434.
Fixes#20517.
Fixes#17177.
Fixes#16534.
Fixes#16503.
Fixes#14952.
Fixes#14759.
Fixes#14075.
Fixes#11765.