Uh oh!
There was an error while loading. Please reload this page.
feat(e2e): Take screenshots for grid-list, list, icon, menu, radio, tabs, slide-toggle - #3098
Conversation
tinayuangao
commented
Feb 15, 2017
- Updated button and checkbox e2e test so the screenshot wait for ripple animation to finish
- Added screenshots for grid-list, list, icon, menu, radio, tabs, slide-toggle
- Skipped some tests which UI is already tested. Also skipped e2e tests with animation.
6104026 to
25a168dCompare
mmalerba
left a comment
There was a problem hiding this comment.
It looks like there's a minor lint issue, otherwise good. Is there a way we can see the screenshots generated by this?
| it('should render a grid list container', () => { | ||
| expectToExist('md-grid-list'); | ||
| screenshot(''); |
There was a problem hiding this comment.
This could be improved by either having the id be an optional param, or making it default to ''.
tinayuangao
commented
Feb 15, 2017
Made Currently there's no way to see the screenshots. Once #2774 get in we can view the screenshots from https://material2-screenshots.firebaseapp.com/PR# |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |