Uh oh!
There was an error while loading. Please reload this page.
fix(docs): Automatic scrolling fails on screens smaller than 721px - #31037
Merged
crisbeto merged 1 commit intoMay 6, 2025
Merged
Conversation
…e to flexbox behavior Fixes a flexbox issue where if a flex item has `flex-basis: auto` and `min-height: auto`, it exceeds the height of its flex parent. Consequently, when `scrollBy` is called by `scrollDetector` in `drop-list-ref.ts`, the container is not scrollable because its height is determined by its content. Removing `min-height: auto` forces the flex item to match the height of its flex parent, allowing `scrollBy` to function correctly. Fixesangular#26476
yousafravian
requested review from
andrewseguin and crisbeto
and removed request for
a teamMay 6, 2025 07:10
crisbeto
approved these changes
May 6, 2025
crisbeto
commented
May 6, 2025
Member
The changes were merged into the following branches: main, 19.2.x, 20.0.x |
crisbeto pushed a commit
that referenced
this pull request
May 6, 2025
…e to flexbox behavior (#31037) Fixes a flexbox issue where if a flex item has `flex-basis: auto` and `min-height: auto`, it exceeds the height of its flex parent. Consequently, when `scrollBy` is called by `scrollDetector` in `drop-list-ref.ts`, the container is not scrollable because its height is determined by its content. Removing `min-height: auto` forces the flex item to match the height of its flex parent, allowing `scrollBy` to function correctly. Fixes#26476 (cherry picked from commit 8cf7615)
crisbeto pushed a commit
that referenced
this pull request
May 6, 2025
…e to flexbox behavior (#31037) Fixes a flexbox issue where if a flex item has `flex-basis: auto` and `min-height: auto`, it exceeds the height of its flex parent. Consequently, when `scrollBy` is called by `scrollDetector` in `drop-list-ref.ts`, the container is not scrollable because its height is determined by its content. Removing `min-height: auto` forces the flex item to match the height of its flex parent, allowing `scrollBy` to function correctly. Fixes#26476 (cherry picked from commit 8cf7615)
wildcardalice pushed a commit
to wildcardalice/components
that referenced
this pull request
May 12, 2025
…e to flexbox behavior (angular#31037) Fixes a flexbox issue where if a flex item has `flex-basis: auto` and `min-height: auto`, it exceeds the height of its flex parent. Consequently, when `scrollBy` is called by `scrollDetector` in `drop-list-ref.ts`, the container is not scrollable because its height is determined by its content. Removing `min-height: auto` forces the flex item to match the height of its flex parent, allowing `scrollBy` to function correctly. Fixesangular#26476
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a flexbox issue where if a flex item has
flex-basis: autoandmin-height: auto, it exceeds the height of its flex parent. Consequently, whenscrollByis called byscrollDetectorindrop-list-ref.ts, the container is not scrollable because its height is determined by its content. Removingmin-height: autoforces the flex item to match the height of its flex parent, allowingscrollByto function correctly.Fixes#26476