Skip to content

bug(md-select): change the arrow position to absolute - #3242

Closed
jefersonestevo wants to merge 5 commits into
angular:masterfrom
jefersonestevo:issue-3112
Closed

bug(md-select): change the arrow position to absolute#3242
jefersonestevo wants to merge 5 commits into
angular:masterfrom
jefersonestevo:issue-3112

Conversation

@jefersonestevo

Copy link
Copy Markdown
Contributor

Fixes#3112

@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 22, 2017
@jefersonestevojefersonestevo changed the title md-select: change the arrow position to absolutebug(md-select): change the arrow position to absoluteFeb 22, 2017

@crisbetocrisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS changes LGTM, but a couple of notes:

  1. We don't need the extra demo.
  2. Can you please rebase and squash your commits?

Comment threadsrc/demo-app/select/select-demo.html Outdated
</div>
<div style="height: 500px">This div is for testing scrolled selects.</div>

<md-card>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this example. The examples in the demo app are there to be able to click around the main use cases, they're not for actual testing.

@crisbetocrisbeto added in progress This issue is currently in progress pr: needs rebase labels Mar 9, 2017
@jefersonestevo

Copy link
Copy Markdown
ContributorAuthor

@crisbeto conflicts resolved and I've removed the demo for flex layout from the demo page. Anything else that needs to change here?

@crisbeto

Copy link
Copy Markdown
Member

Not code-wise, but you have a few merge conflicts which can cause issues with our scripts. Can you squash all your commits into one?

@jefersonestevo

Copy link
Copy Markdown
ContributorAuthor

@crisbeto As these changes are really small and there are some merges with lots of commits here, I've created a new pull request with just the changes based on the current master. I'm closing this one and we can continue at #3580

@crisbeto

Copy link
Copy Markdown
Member

Well, it's already done, but FYI you can still squash commits after the PR has been opened.

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 6, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesPR author has agreed to Google's Contributor License Agreementin progressThis issue is currently in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(md-select) - not rendering correctly inside a flex layout (pure css) when having ngModel

4 participants

@jefersonestevo@crisbeto@kara@googlebot