Uh oh!
There was an error while loading. Please reload this page.
feat(aria/combobox): migrate simple-combobox directly into primary entrypoints - #33206
Conversation
Deployed dev-app for 480ab11 to: https://ng-dev-previews-comp--pr-angular-components-33206-dev-fropu17d.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
| @@ -1,4 +1,4 @@ | |||
| ## API Report File for "@angular/aria_combobox" | |||
| ## API Report File for "@angular/aria_deprecated_combobox" | |||
There was a problem hiding this comment.
Given that Aria isn't stable yet, we can delete this code rather than going through a deprecation process.
There was a problem hiding this comment.
We plan to migrate the internal usages later so we need a temporary place for the old combobox. It also provides a fallback if the migrations cause regression.
There was a problem hiding this comment.
In that case maybe we should delete it externally and only leave it inside g3? The problem is that once we stabilize Aria, it'll take much longer to remove this code.
There was a problem hiding this comment.
okay - I removed the old combobox and replaced it with the new combobox. Thanks @crisbeto for the tips!
…points Relocate the public `src/aria/combobox` entrypoint to `src/aria/deprecated/combobox` and the private implementation patterns to `src/aria/private/deprecated/combobox`. This frees up the primary `combobox` namespace for the upcoming standalone combobox widget migration. - Add JSDoc `@deprecated` and `@breaking-change 22.0.0` markers to legacy classes and primitives. - Adjust relative imports outwards to accommodate the deeper directory nesting levels. - Re-wire build dependencies and entrypoint configurations across the framework package graph. - Bulk update consumer example module targets and prune unused dependencies.
…ementations Deletes the deprecated legacy combobox and autocomplete codebases, including their core entrypoints, integration layers within listbox and tree components, examples, dev-app pages, and associated API goldens. BREAKING CHANGE: The legacy combobox and autocomplete implementations have been removed. Use the new standalone combobox instead.
…mbobox - Relocates public, private, and example directories to clean `combobox` entry points. - Renames internal layout symbols, selectors, and uppercase tokens (`SIMPLE_COMBOBOX_POPUP` -> `COMBOBOX_POPUP`). - Establishes full documentation extraction parity with the `json_api` Bazel rule target. - Standardizes the accompanying toolbar component showcase into the clean `aria-toolbar` path. - Re-routes dev-app navigation links and migrates public API golden records. BREAKING CHANGE: `SimpleCombobox` has been promoted to `Combobox`. All `simple-combobox` prefixed symbols, selectors, and tokens have been renamed to use the `combobox` prefix.
…olbar examples Relocate the autocomplete examples to `src/components-examples/aria/autocomplete` and toolbar examples to `src/components-examples/aria/toolbar`. - Restore naming continuity with the historical codebase by stripping redundant prefixes from example filenames and component selectors. - Sync dev-app preview routing layout paths and strict Bazel target dependency links.
Uh oh!
There was an error while loading. Please reload this page.
tjshiu
commented
May 6, 2026
This PR was merged into the repository. The changes were merged into the following branches:
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Migrate the public
src/aria/simple-comboboxentrypoint tosrc/aria/comboboxand the private implementation patterns tosrc/aria/private/comboboxto complete the standalone widget migration.simple-prefix from all public/private component files, classes, selectors, and uppercase injection tokens.json_apiBazel rule extraction target.aria-toolbarentrypoint.