Skip to content

docs(sidenav): update responsive example to use current APIs - #33318

Open
EduardF1 wants to merge 1 commit into
angular:mainfrom
EduardF1:docs/update-responsive-sidenav-example
Open

docs(sidenav): update responsive example to use current APIs#33318
EduardF1 wants to merge 1 commit into
angular:mainfrom
EduardF1:docs/update-responsive-sidenav-example

Conversation

@EduardF1

Copy link
Copy Markdown

Summary

Updates the responsive sidenav documentation example to use the current CDK APIs instead of deprecated MediaMatcher/MediaQueryList event listener methods.

Root Cause

The example was using MediaMatcher with addEventListener/removeEventListener, which requires manual lifecycle management via OnDestroy. An Angular team member noted the preferred approach is to use the CDK's BreakpointObserver.observe() directly.

Changes

  • Replaced MediaMatcher with BreakpointObserver.observe()
  • Used takeUntilDestroyed() for automatic subscription cleanup
  • Removed OnDestroy implementation and manual event listener management
  • Removed private _mobileQuery and _mobileQueryListener fields

Result

The component is now simpler, idiomatic Angular, and no longer uses the raw MediaQueryList API.

Fixes#29266

@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@angular-robotangular-robotBot added the area: docs Related to the documentation label May 29, 2026
@EduardF1
EduardF1force-pushed the docs/update-responsive-sidenav-example branch from fc2eb8f to ff0fc7dCompareMay 31, 2026 11:02
@EduardF1

Copy link
Copy Markdown
Author

Update: I have already signed the Google CLA with fischerszavarduard@gmail.com, and I have now rewritten this PR commit so the author/committer email matches that signed address. The cla/google check is still failing. Could a maintainer please re-run or investigate?

@EduardF1
EduardF1force-pushed the docs/update-responsive-sidenav-example branch from ff0fc7d to bde711dCompareJune 4, 2026 00:12
@EduardF1

Copy link
Copy Markdown
Author

Just following up on this PR. The checks look good (apart from the CLA which I believe needs separate handling). Let me know if I need to make any changes!

@EduardF1

Copy link
Copy Markdown
Author

Hi! Just checking in on this PR. The CI is green. Is there anything else needed from my side to help get this reviewed and merged?

@EduardF1
EduardF1force-pushed the docs/update-responsive-sidenav-example branch from bde711d to 4c9546eCompareJune 10, 2026 07:25
@EduardF1

Copy link
Copy Markdown
Author

@googlebot I signed it!

@EduardF1
EduardF1force-pushed the docs/update-responsive-sidenav-example branch from 4c9546e to 8342202CompareJune 30, 2026 12:46
Replace the manual MediaMatcher/MediaQueryList setup with the CDK's
BreakpointObserver.observe(), which is the idiomatic Angular approach.
Use takeUntilDestroyed() for automatic subscription cleanup, removing
the need to implement OnDestroy and manually manage event listeners.
Fixesangular#29266
@pullapprove
pullapproveBot requested a review from tjshiuJune 30, 2026 12:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: docsRelated to the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs-bug(Sidenav): deprecated methods used in the responsive sidenav example

2 participants

@EduardF1@EduardF97