Skip to content

fix(aria/combobox): allow setting readonly - #33364

Merged
ok7sai merged 1 commit into
angular:mainfrom
ok7sai:fix/combobox-readonly
Jun 15, 2026
Merged

fix(aria/combobox): allow setting readonly#33364
ok7sai merged 1 commit into
angular:mainfrom
ok7sai:fix/combobox-readonly

Conversation

@ok7sai

@ok7saiok7sai commented Jun 8, 2026•
edited
Loading

Copy link
Copy Markdown
Member
  • Added readonly input and attribute bindings
  • Added readonly and hard disabled examples

Fixes#33352

@ok7sai
ok7saiforce-pushed the fix/combobox-readonly branch 2 times, most recently from fae8734 to 67b092dCompareJune 8, 2026 08:30
@ok7saiok7sai added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Jun 8, 2026
@github-actions

github-actionsBot commented Jun 8, 2026•
edited
Loading

Copy link
Copy Markdown

Deployed dev-app for b01ffb8 to: https://ng-dev-previews-comp--pr-angular-components-33364-dev-vufoprht.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@rudzikdawid

rudzikdawid commented Jun 8, 2026•
edited
Loading

Copy link
Copy Markdown

Thanks for restoring readonly! However, it looks like the disabled state is still not behaving correctly.

I tested the dev-app preview, and in the "Combobox with disabled" section, I was still able to click the input, focus it, and type text ("i can write here").

Zrzut ekranu z 2026-06-08 21-31-36

Current behavior: A disabled combobox accepts focus and allows text editing.

Expected behavior: A disabled element should be completely inactive — it should be uneditable and unfocusable (skipped during tab navigation). For comparison, in the standard Angular Material Input examples, the disabled control is correctly excluded from the tab order and cannot be interacted with.

@ok7sai

ok7sai commented Jun 8, 2026

Copy link
Copy Markdown
MemberAuthor

Thanks for reviewing! This PR is an early draft that needs to be polished.

@ok7sai
ok7saiforce-pushed the fix/combobox-readonly branch 2 times, most recently from 213728a to 53e1be3CompareJune 10, 2026 09:31
@ok7sai
ok7saiforce-pushed the fix/combobox-readonly branch from 53e1be3 to b01ffb8CompareJune 10, 2026 09:44
@ok7sai
ok7sai marked this pull request as ready for review June 10, 2026 17:01
@ok7saiok7sai added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 12, 2026
@ok7sai
ok7sai merged commit 31781a0 into angular:mainJun 15, 2026
36 of 38 checks passed
@ok7sai

ok7sai commented Jun 15, 2026

Copy link
Copy Markdown
MemberAuthor

This PR was merged into the repository. The changes were merged into the following branches:

@ok7sai
ok7sai deleted the fix/combobox-readonly branch June 15, 2026 17:08
rudzikdawid added a commit to rudzikdawid/angular that referenced this pull request Jun 17, 2026
@rudzikdawid
docs(docs-infra): add missing readonly property to combobox guide
c2d4c23
PR angular/components#33364 restored the `readonly` property for the
combobox, but the documentation was not updated to reflect this change.
This commit adds the missing `readonly` input and its description to
the Inputs / Model table in the combobox guide.
@rudzikdawidrudzikdawid mentioned this pull request Jun 17, 2026
Merged
14 tasks
kirjs pushed a commit to angular/angular that referenced this pull request Jun 18, 2026
@rudzikdawid@kirjs
docs(docs-infra): add missing readonly property to combobox guide
69a0004
PR angular/components#33364 restored the `readonly` property for the
combobox, but the documentation was not updated to reflect this change.
This commit adds the missing `readonly` input and its description to
the Inputs / Model table in the combobox guide.
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Jul 16, 2026

Copy link
Copy Markdown

This pull request has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Jul 16, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adolgachevadolgachevAwaiting requested review from adolgachev
@crisbetocrisbetoAwaiting requested review from crisbeto

Assignees

No one assigned

Labels

action: mergeThe PR is ready for merge by the caretakerarea: aria/comboboxdev-app previewWhen applied, previews of the dev-app are deployed to Firebasetarget: minorThis PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(aria/combobox): Focus management and a11y regressions: Combobox missing readonly, Select disabled is focusable

3 participants

@ok7sai@rudzikdawid@crisbeto