Skip to content

fix(material/schematics): resolve issues in navigation schematic - #33590

Merged
crisbeto merged 1 commit into
angular:mainfrom
crisbeto:33381/navigation-schematic
Jul 28, 2026
Merged

fix(material/schematics): resolve issues in navigation schematic#33590
crisbeto merged 1 commit into
angular:mainfrom
crisbeto:33381/navigation-schematic

Conversation

@crisbeto

@crisbetocrisbeto commented Jul 28, 2026

Copy link
Copy Markdown
Member

Resolves the following issues in the navigation schematic:

  1. We were using observables instead of signals for isHandset.
  2. We were using color on the toolbar.
  3. One of the standalone checks in the generated test was flipped.

Fixes#33381.

@crisbetocrisbeto added the target: patch This PR is targeted for the next patch release label Jul 28, 2026
@crisbeto
fix(material/schematics): resolve issues in navigation schematic
fe2fc3d
Resolves the following issues in the navigation schematic:
1. We were using observables instead of signals for `isHandset`.
2. We were using `color` on the toolbar.
3. One of the `standalone` checks in the generated test was flipped.
Fixesangular#33381.
@crisbeto
crisbetoforce-pushed the 33381/navigation-schematic branch from 4a3b1db to fe2fc3dCompareJuly 28, 2026 07:59
@crisbetocrisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 28, 2026
@crisbeto
crisbeto merged commit 7f8a729 into angular:mainJul 28, 2026
30 of 32 checks passed
@crisbeto

crisbeto commented Jul 28, 2026

Copy link
Copy Markdown
MemberAuthor

This PR was merged into the repository. The changes were merged into the following branches:

crisbeto added a commit that referenced this pull request Jul 28, 2026
@crisbeto
fix(material/schematics): resolve issues in navigation schematic (#33590
223c515
)
Resolves the following issues in the navigation schematic:
1. We were using observables instead of signals for `isHandset`.
2. We were using `color` on the toolbar.
3. One of the `standalone` checks in the generated test was flipped.
Fixes#33381.
(cherry picked from commit 7f8a729)
crisbeto added a commit that referenced this pull request Jul 28, 2026
@crisbeto
fix(material/schematics): resolve issues in navigation schematic (#33590
0d70daa
)
Resolves the following issues in the navigation schematic:
1. We were using observables instead of signals for `isHandset`.
2. We were using `color` on the toolbar.
3. One of the `standalone` checks in the generated test was flipped.
Fixes#33381.
(cherry picked from commit 7f8a729)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ok7saiok7saiok7sai approved these changes
@andrewseguinandrewseguinAwaiting requested review from andrewseguin
@tjshiutjshiuAwaiting requested review from tjshiu

Assignees

No one assigned

Labels

action: mergeThe PR is ready for merge by the caretakertarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(Navigation schematic): Several issues in the code generated by the navigation schematic

2 participants

@crisbeto@ok7sai