Skip to content

fix(material/dialog): do not expose CDK dialog ref to users - #33603

Merged
crisbeto merged 1 commit into
angular:mainfrom
crisbeto:33601/dialog-ref
Jul 30, 2026
Merged

fix(material/dialog): do not expose CDK dialog ref to users#33603
crisbeto merged 1 commit into
angular:mainfrom
crisbeto:33601/dialog-ref

Conversation

@crisbeto

@crisbetocrisbeto commented Jul 30, 2026

Copy link
Copy Markdown
Member

Fixes that we were exposing both the CDK and Material dialog refs to users which can be confusing.

Fixes#33601.

@crisbeto
fix(material/dialog): do not expose CDK dialog ref to users
2493156
Fixes that we were exposing both the CDK and Material dialog refs to users which can be confusing.
Fixesangular#33601.
@crisbetocrisbeto added the target: patch This PR is targeted for the next patch release label Jul 30, 2026
@crisbetocrisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 30, 2026
@crisbeto
crisbeto merged commit d61a26d into angular:mainJul 30, 2026
33 of 36 checks passed
@crisbeto

crisbeto commented Jul 30, 2026

Copy link
Copy Markdown
MemberAuthor

This PR was merged into the repository. The changes were merged into the following branches:

crisbeto added a commit that referenced this pull request Jul 30, 2026
@crisbeto
fix(material/dialog): do not expose CDK dialog ref to users (#33603)
f9ad736
Fixes that we were exposing both the CDK and Material dialog refs to users which can be confusing.
Fixes#33601.
(cherry picked from commit d61a26d)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewseguinandrewseguinandrewseguin approved these changes
@tjshiutjshiuAwaiting requested review from tjshiu

Assignees

No one assigned

Labels

action: mergeThe PR is ready for merge by the caretakerarea: material/dialogtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(dialog): Throw an error if MatDialog with CDK DialogRef are mixed by mistake

2 participants

@crisbeto@andrewseguin