Uh oh!
There was an error while loading. Please reload this page.
chore: remove leftover expression - #3693
Closed
crisbeto wants to merge 1 commit into
Closed
Conversation
This is a follow-up to #2849. It looks like I was a little too quick to switch the statement and forgot to remove the `typeof`.
| constructor(@Optional() @Inject(DOCUMENT) document: any) { | ||
| if (isDevMode() && typeof document && !document.doctype) { | ||
| if (isDevMode() && document && !document.doctype) { |
Contributor
There was a problem hiding this comment.
Won't just document by itself potentially be an issue for Universal? typeof document == 'object'?
MemberAuthor
There was a problem hiding this comment.
It won't, because it'll hit the parameter, before it tries to look for it globally.
crisbeto
commented
Mar 25, 2017
MemberAuthor
I've rolled these changes into #3693. Closing to avoid potential merge conflicts. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2849. It looks like I was a little too quick to switch the statement and forgot to remove the
typeof.