Uh oh!
There was an error while loading. Please reload this page.
build: restructure release output - #3695
Conversation
809c2f5 to
ebf4aa9Comparegooglebot
commented
Mar 22, 2017
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
809c2f5 to
f8ec65dCompare* Bumps the required Angular version to 4 and TypeScript to 2.1.6. * Fixes deprecation warnings for `<template>` usages. * Fixes any unit and e2e test failures. * Includes the new animations module and switches any components that use animations to it. * Fixes issues with the various test apps. Fixesangular#3357. Fixesangular#3336. FIxesangular#3301.
| export const UGLIFYJS_OPTIONS = { | ||
| preserveComments: 'license' | ||
| }; |
There was a problem hiding this comment.
I think we should just define these where we call uglify if we're only doing it in one place.
| // As a workaround for https://github.com/angular/angular/issues/12249, we need to | ||
| // copy the Material ESM output inside of the demo-app output. | ||
| task('aot:copy-release', () => { | ||
| copySync(DIST_RELEASE, join(DIST_DEMOAPP, 'material')); |
There was a problem hiding this comment.
Any reason not to do
task('aot:copy-release',()=>src(DIST_RELEASE).pipe(dest(join(DIST_DEMOAPP,'material'))));?
(I thought this was the most "gulp-y" way to do it, but I could be wrong)
There was a problem hiding this comment.
I tried, but it really felt weird because I would need to specify a glob to match all files. (Just specifying the directory didn't work)
task('aot:copy-release',()=>src(DIST_RELEASE+'**/*').pipe(dest(join(DIST_DEMOAPP,'material'))));It is definitely a gulp-y way, but I think it's just not very clear and also we would need to have a glob.
| /** Task that combines intermediate build artifacts into the release package structure. */ | ||
| task(':package:release', [ | ||
| ':package:fix-metadata', | ||
| ':package:metadata', |
There was a problem hiding this comment.
Should only call :packagae:metadata, which then depends on :package:fix-metadata?
(to make sure the order of operations is correct since this isn't a runSequence)
devversion
commented
Mar 24, 2017
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Work in Progress PR (for review)
Note: AOT Travis check will likely fail at the moment. Not updated yet.
cc. @jelbourn