Skip to content

guide(theming): update custom theme section - #4009

Closed
fxck wants to merge 2 commits into
angular:masterfrom
fxck:theming-docs-change
Closed

guide(theming): update custom theme section#4009
fxck wants to merge 2 commits into
angular:masterfrom
fxck:theming-docs-change

Conversation

@fxck

@fxckfxck commented Apr 10, 2017

Copy link
Copy Markdown
Contributor

reasoning in this issue #1786

@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 10, 2017
@willshowell

Copy link
Copy Markdown
Contributor

@fxck@jelbourn I strongly agree with this change. I lost more time than I'd like to admit tracking down why my bundles kept increasing in size, only to realize the theming guide was a slightly misleading.

@jelbourn

Copy link
Copy Markdown
Contributor

I've opened #4021 to try to address both this and a couple of other common issues. Let me know what you think.

@fxckfxck closed this Apr 11, 2017
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 6, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesPR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@fxck@willshowell@jelbourn@googlebot