Uh oh!
There was an error while loading. Please reload this page.
build: dedupe theming scss bundle - #4174
Conversation
| // Glob that matches all files that might be imported multiple times. | ||
| // Necessary for deduping inside of scss-bundle. | ||
| const themingBundleDedupeGlob = join(COMPONENTS_DIR, '**/*.scss'); |
There was a problem hiding this comment.
Should be named for what is it rather than how it's used, e.g., allScssGlob
There was a problem hiding this comment.
I named it themingBundleDedupeGlob because I wanted to make it clear that this will be the array that holds the files that might need deduping. Changed it because the comment below explains it then.
| ], {silentStdout: true} | ||
| )); | ||
| task(':bundle:theming-scss', () => { | ||
| new Bundler().Bundle(themingEntryPointPath, [themingBundleDedupeGlob]).then(result => { |
There was a problem hiding this comment.
Could you comment on what the arguments are here since it's not really clear from the call site?
* Updates to a more recent version of SCSS-bundle that has support for deduping. The dedupe process is very naive and only disallows importing a file multiple times. * Switches to the programmatic API of `scss-bundle` * Removes unused functions and imports / leftovers. Fixesangular#3931
1fc9a3a to
d364b6eCompareThis issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
scss-bundleFixes#3931