Skip to content

fix(dialog): restoring focus too early - #4329

Merged
andrewseguin merged 1 commit into
angular:masterfrom
crisbeto:4287/dialog-restore-focus-early
May 2, 2017
Merged

fix(dialog): restoring focus too early#4329
andrewseguin merged 1 commit into
angular:masterfrom
crisbeto:4287/dialog-restore-focus-early

Conversation

@crisbeto

@crisbetocrisbeto commented Apr 29, 2017

Copy link
Copy Markdown
Member

Fixes the dialog restoring focus before the close animation is done.

Fixes#4287.

@crisbeto
fix(dialog): restoring focus too early
0055c76
Fixes the dialog restoring focus before the close animation is done.
Fixesangular#4287.
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 29, 2017
@crisbetocrisbeto mentioned this pull request Apr 29, 2017
Closed
jelbourn
jelbourn approved these changes May 1, 2017
View reviewed changes

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 1, 2017
@andrewseguin
andrewseguin merged commit afaa2dc into angular:masterMay 2, 2017
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 6, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 6, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@jelbournjelbournjelbourn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jelbournjelbourn

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dialog close() from <input> event no longer works.

4 participants

@crisbeto@jelbourn@googlebot@andrewseguin