Skip to content

fix(menu): close menu panel on escape - #4666

Merged
tinayuangao merged 1 commit into
angular:masterfrom
jelbourn:menu-escape
May 22, 2017
Merged

fix(menu): close menu panel on escape#4666
tinayuangao merged 1 commit into
angular:masterfrom
jelbourn:menu-escape

Conversation

@jelbourn

@jelbournjelbourn commented May 19, 2017

Copy link
Copy Markdown
Contributor

Fixes to #3601

@jelbourn
jelbourn requested a review from crisbetoMay 19, 2017 01:22
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 19, 2017
@jelbournjelbourn added Accessibility This issue is related to accessibility (a11y) and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels May 19, 2017
crisbeto
crisbeto approved these changes May 19, 2017
View reviewed changes

@crisbetocrisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbetocrisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 19, 2017
@tinayuangao
tinayuangao merged commit 210e57c into angular:masterMay 22, 2017
@willshowellwillshowell mentioned this pull request May 30, 2017
Closed
@jelbourn
jelbourn deleted the menu-escape branch September 13, 2017 04:38
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 7, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 7, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbetocrisbetocrisbeto approved these changes

Assignees

No one assigned

Labels

AccessibilityThis issue is related to accessibility (a11y)action: mergeThe PR is ready for merge by the caretaker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jelbourn@crisbeto@googlebot@tinayuangao