Skip to content

fix(input): set aria-invalid on mdInput element - #4757

Merged
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:input-aria-invalid
May 31, 2017
Merged

fix(input): set aria-invalid on mdInput element#4757
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:input-aria-invalid

Conversation

@crisbeto

Copy link
Copy Markdown
Member
  • Sets the aria-invalid attribute on the mdInput node, depending on whether it is invalid.
  • Moves the _isErrorState logic to the input child to avoid a circular dependency.

* Sets the `aria-invalid` attribute on the `mdInput` node, depending on whether it is invalid.
* Moves the `_isErrorState` logic to the input child to avoid a circular dependency.
@crisbetocrisbeto added Accessibility This issue is related to accessibility (a11y) pr: needs review labels May 23, 2017
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 23, 2017
@mmalerbammalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 23, 2017
@mmalerba
mmalerba merged commit 0c03946 into angular:masterMay 31, 2017
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 6, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

AccessibilityThis issue is related to accessibility (a11y)action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto@mmalerba@googlebot