Skip to content

fix(autocomplete,datepicker,menu): closing parent dialog by pressing escape - #6226

Merged
tinayuangao merged 1 commit into
angular:masterfrom
crisbeto:6223/stop-propagation
Aug 2, 2017
Merged

fix(autocomplete,datepicker,menu): closing parent dialog by pressing escape#6226
tinayuangao merged 1 commit into
angular:masterfrom
crisbeto:6223/stop-propagation

Conversation

@crisbeto

@crisbetocrisbeto commented Aug 2, 2017

Copy link
Copy Markdown
Member

Prevents the autocomplete, datepicker and menu components from closing their parent dialog when the user presses escape.

Fixes#6223.

@crisbeto
fix(autocomplete,datepicker,menu): closing parent dialog by pressing …
6ae7507
…escape
Prevents the autocomplete, datepicker and menu components from closing their parent dialog when the user presses escape.
Fixesangular#6223.
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 2, 2017
@crisbeto

crisbeto commented Aug 2, 2017•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@jelbourn some food for thought: considering that interactions should be scoped to a particular overlay, perhaps we should stopPropagation on keyboard and mouse events for all overlays by default?

kara
kara approved these changes Aug 2, 2017
View reviewed changes

@karakara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karakara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Aug 2, 2017
@jelbourn

jelbourn commented Aug 2, 2017

Copy link
Copy Markdown
Contributor

@crisbeto my instinct is that always doing stopPropagation is overly broad, but don't have any concrete reasons why right now

@tinayuangao
tinayuangao merged commit 916d1f3 into angular:masterAug 2, 2017
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 6, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 6, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmalerbammalerbaAwaiting requested review from mmalerba
1 more reviewer
@karakarakara approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jelbournjelbourn

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Escaping out of menu/autocomplete within a dialog causes the dialog to close

5 participants

@crisbeto@jelbourn@kara@googlebot@tinayuangao