Skip to content

fix: remove duplicated typing. TS stdlib provides enough for e2e tests - #637

Merged
jelbourn merged 1 commit into
angular:masterfrom
hansl:fix-e2e
Jun 6, 2016
Merged

fix: remove duplicated typing. TS stdlib provides enough for e2e tests#637
jelbourn merged 1 commit into
angular:masterfrom
hansl:fix-e2e

Conversation

@hansl

@hanslhansl commented Jun 5, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 5, 2016
@devversion

Copy link
Copy Markdown
Member

@hansl As seen in #631, can we not use the typings manager here and remove the static typings?

@hansl

hansl commented Jun 6, 2016

Copy link
Copy Markdown
ContributorAuthor

We'll just skip typings and go directly to @types when TS 2.0 is released.

@hansl

hansl commented Jun 6, 2016

Copy link
Copy Markdown
ContributorAuthor

R: @jelbourn

@jelbourn

Copy link
Copy Markdown
Contributor

LGTM

@jelbourn
jelbourn merged commit a68597e into angular:masterJun 6, 2016
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 6, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesPR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@hansl@devversion@jelbourn@googlebot