refactor(overlay): use component to render backdrop by crisbeto · Pull Request #6627 · angular/components

crisbeto · 2017-08-24T20:08:07Z

Uses an Angular component to render the backdrop, instead of managing a DOM element manually. This has the advantage of being able to leverage the animations API to transition in/out, as well as not having to worry about the cases where the backdrop animation is disabled.

These changes also enable the backdrop transition for the dialog (previously it would be removed immediately on close).

jelbourn

LGTM, just a couple nits

jelbourn · 2017-08-30T20:53:30Z

+
+ constructor(private _element: ElementRef, private _renderer: Renderer2) {}
+
+ _setClass(cls: string) {


I'd rename cls to either cssClass or just c
(cls has a different meaning for me)

jelbourn · 2017-08-30T21:08:04Z

 backdropClick(): Observable<void> {
- return this._backdropClick.asObservable();
+ return this._backdropInstance ? this._backdropInstance._clickStream.asObservable() :
+ empty<void>();


Since the function return type is Observable<void>, you don't really need the asObservable call

kara · 2017-10-04T18:35:08Z

@crisbeto Linter strikes again

crisbeto · 2017-10-04T18:39:25Z

Fixed.

kara · 2017-10-05T01:33:06Z

@crisbeto CI looks unhappy again

crisbeto · 2017-10-05T17:16:38Z

Alright, now the CI should be happy.

crisbeto · 2017-11-09T09:30:31Z

Rebased again.

jelbourn · 2017-11-21T00:18:08Z

Some Google teams are using detachBackdrop; we'll need to add it back as a deprecated alias.

crisbeto · 2017-11-21T18:29:45Z

Rebased and re-added the detachOverlay@jelbourn.

josephperrott · 2018-03-30T18:02:05Z

@crisbeto Did you want to rebase and work on getting this one in?

crisbeto · 2018-03-31T09:07:42Z

Rebased and fixed a few issues @josephperrott.

Uses an Angular component to render the backdrop, instead of managing a DOM element manually. This has the advantage of being able to leverage the animations API to transition in/out, as well as not having to worry about the cases where the backdrop animation is disabled. These changes also enable the backdrop transition for the dialog (previously it would be removed immediately on close).

jelbourn · 2018-04-26T17:11:10Z

Going to close this since it's not a big priority and would need further investigation into presubmit failures

jrood · 2018-06-21T18:00:39Z

Requesting for this issue to be reopened in light of issues highlighted in #11806

jelbourn · 2018-06-21T21:24:34Z

We ended up abandoning this because it caused many test failures for various google apps, meaning it would probably cause many more test failures for the community at large.

angular-automatic-lock-bot · 2019-09-09T03:02:23Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

crisbeto added the pr: needs review label Aug 24, 2017

crisbeto assigned jelbourn Aug 24, 2017

crisbeto requested review from devversion and jelbourn as code owners August 24, 2017 20:08

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 24, 2017

jelbourn approved these changes Aug 30, 2017
View reviewed changes

jelbourn added pr: lgtm and removed pr: needs review labels Aug 30, 2017

crisbeto force-pushed the backdrop-component branch from bd6f9c4 to 9a114f5Compare August 30, 2017 21:18

crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 30, 2017

crisbeto force-pushed the backdrop-component branch from 9a114f5 to 93a64b5Compare September 2, 2017 16:38

crisbeto force-pushed the backdrop-component branch from 93a64b5 to f2c1fa0Compare September 21, 2017 20:33

crisbeto force-pushed the backdrop-component branch 3 times, most recently from 4cb861c to 2dcf30eCompare October 4, 2017 17:27

kara removed the action: merge The PR is ready for merge by the caretaker label Oct 4, 2017

kara assigned crisbeto and unassigned jelbourn Oct 4, 2017

crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 4, 2017

kara removed the action: merge The PR is ready for merge by the caretaker label Oct 5, 2017

crisbeto force-pushed the backdrop-component branch 2 times, most recently from dbdc289 to 0a87d53Compare October 5, 2017 17:07

crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 5, 2017

crisbeto force-pushed the backdrop-component branch 3 times, most recently from 8214290 to d1eb5dbCompare October 11, 2017 16:52

crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Nov 9, 2017

crisbeto force-pushed the backdrop-component branch from bc9f71c to 254e770Compare November 20, 2017 20:26

jelbourn added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Nov 21, 2017

crisbeto mentioned this pull request Nov 21, 2017
Overlay backdrop animation not triggered when detaching #8570
Closed

crisbeto force-pushed the backdrop-component branch from 254e770 to 5a42a9dCompare November 21, 2017 18:27

jelbourn removed the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Nov 28, 2017

crisbeto force-pushed the backdrop-component branch from 5a42a9d to 9373ff8Compare December 3, 2017 16:04

crisbeto added the target: minor This PR is targeted for the next minor release label Dec 6, 2017

andrewseguin added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Dec 13, 2017

crisbeto mentioned this pull request Jan 25, 2018
bug: cdk-overlay-dark-backdrop is removed before overlay is able to transition out #6071
Closed

crisbeto force-pushed the backdrop-component branch 3 times, most recently from bc9a464 to a4e7e80Compare March 31, 2018 09:06

crisbeto force-pushed the backdrop-component branch from a4e7e80 to fe28d4bCompare April 14, 2018 13:15

andrewseguin assigned jelbourn and unassigned crisbeto Apr 26, 2018

jelbourn closed this Apr 26, 2018

crisbeto mentioned this pull request Jun 21, 2018
fix(select): Improve the a11y of select component by making overlay #11806
Closed

angular-automatic-lock-botBot locked and limited conversation to collaborators Sep 9, 2019


		constructor(private _element: ElementRef, private _renderer: Renderer2) {}

		_setClass(cls: string) {

Uh oh!

Conversation

crisbeto commented Aug 24, 2017

Uh oh!

jelbourn left a comment

Choose a reason for hiding this comment

Uh oh!

jelbournAug 30, 2017

Choose a reason for hiding this comment

Uh oh!

jelbournAug 30, 2017

Choose a reason for hiding this comment

Uh oh!

kara commented Oct 4, 2017

Uh oh!

crisbeto commented Oct 4, 2017

Uh oh!

kara commented Oct 5, 2017

Uh oh!

crisbeto commented Oct 5, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crisbeto commented Nov 9, 2017

Uh oh!

jelbourn commented Nov 21, 2017

Uh oh!

crisbeto commented Nov 21, 2017

Uh oh!

josephperrott commented Mar 30, 2018

Uh oh!

crisbeto commented Mar 31, 2018

Uh oh!

jelbourn commented Apr 26, 2018

Uh oh!

jrood commented Jun 21, 2018

Uh oh!

jelbourn commented Jun 21, 2018

Uh oh!

angular-automatic-lock-botBot commented Sep 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

crisbeto commented Oct 5, 2017•
edited
Loading