Uh oh!
There was an error while loading. Please reload this page.
demo(list): Add accessibility demo page for list - #7020
Conversation
| @Directive({ | ||
| selector: 'md-nav-list, mat-nav-list', | ||
| host: {'class': 'mat-nav-list'} | ||
| template: '<ng-content></ng-content>', |
There was a problem hiding this comment.
I think that in general we still keep the templates in a separate HTML file, even if it's a one-liner.
| <h2> Seasoning </h2> | ||
| <p>Showing a non-interactive list of seasonings.</p> | ||
| <md-list role="list"> | ||
| <md-list-item *ngFor="let item of items"> {{item}} </md-list-item> |
There was a problem hiding this comment.
Shouldn't all of these list items have a role="listitem"?
There was a problem hiding this comment.
role="listitem" is added in list.ts so we don't need to add it here.
There was a problem hiding this comment.
Weren't we going to remove that from the list-item?
89e44b2 to
b2329cfComparekara
commented
Oct 3, 2017
@tinayuangao Rebase? |
* demo(list): Add accessibility demo page for list * fix test * set default role for md-list * fix test * Add template file for list
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR #6363 is accidentally changed to change of changelog.md