Skip to content

fix(sort): throw error on invalid direction - #7378

Merged
andrewseguin merged 1 commit into
angular:masterfrom
andrewseguin:sort-init-funny
Sep 29, 2017
Merged

fix(sort): throw error on invalid direction#7378
andrewseguin merged 1 commit into
angular:masterfrom
andrewseguin:sort-init-funny

Conversation

@andrewseguin

@andrewseguinandrewseguin commented Sep 27, 2017

Copy link
Copy Markdown
Contributor

Fixes#7291

@googlebotgooglebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Sep 27, 2017
@andrewseguinandrewseguin mentioned this pull request Sep 27, 2017
Closed
@googlebotgooglebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Sep 27, 2017
@angularangular deleted a comment from googlebotSep 27, 2017
@angularangular deleted a comment from andrewseguinSep 27, 2017
@angularangular deleted a comment from googlebotSep 27, 2017
jelbourn
jelbourn approved these changes Sep 27, 2017
View reviewed changes

@jelbournjelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbournjelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Sep 27, 2017
@andrewseguin
andrewseguin merged commit cc6f39e into angular:masterSep 29, 2017
@andrewseguin
andrewseguin deleted the sort-init-funny branch November 28, 2017 20:40
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 7, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 7, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@jelbournjelbournjelbourn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Table] Sort arrows are not rendered properly in tabs

3 participants

@andrewseguin@jelbourn@googlebot