Uh oh!
There was an error while loading. Please reload this page.
feat(select): add support for custom error state matcher - #7443
Merged
Conversation
crisbetoforce-pushed
the
select-error-state-matcher-resubmit
branch
from
September 30, 2017 12:48
dfeaa7f to
ee63ccdCompare| const parent = this._parentFormGroup || this._parentForm; | ||
| const newState = ngControl && this.errorStateMatcher(ngControl.control as FormControl, parent); | ||
| const matcher = this.errorStateMatcher || this._defaultErrorStateMatcher; | ||
| const newState = ngControl && matcher.isErrorState(ngControl, parent); |
Contributor
There was a problem hiding this comment.
isErrorState accepts null ngControl, so no need to check here
| const matcher = this.errorStateMatcher || this._defaultErrorStateMatcher; | ||
| return !!(isInvalid && (isTouched || isSubmitted)); | ||
| return ngControl && matcher.isErrorState(ngControl, parent); |
Contributor
There was a problem hiding this comment.
same, no need to check that ngControl is non-null
crisbetoforce-pushed
the
select-error-state-matcher-resubmit
branch
from
September 30, 2017 17:23
ee63ccd to
21ec8eeCompare| @Injectable() | ||
| export class ShowOnDirtyErrorStateMatcher implements ErrorStateMatcher { | ||
| isErrorState(control: NgControl | null, form: FormGroupDirective | NgForm | null): boolean { | ||
| return control ? !!(control.invalid && (control.dirty || (form && form.submitted))) : false; |
Contributor
There was a problem hiding this comment.
would this work? return !!(control && control.invalid && (control.dirty || form && form.submitted))
MemberAuthor
There was a problem hiding this comment.
It should, I don't remember why we went with the ternary initially.
| @Injectable() | ||
| export class ErrorStateMatcher { | ||
| isErrorState(control: NgControl | null, form: FormGroupDirective | NgForm | null): boolean { | ||
| return control ? !!(control.invalid && (control.touched || (form && form.submitted))) : false; |
Contributor
There was a problem hiding this comment.
return !!(control && control.invalid && (control.touched || form && form.submitted))
mmalerba
commented
Sep 30, 2017
Contributor
fixes #7419 |
crisbetoforce-pushed
the
select-error-state-matcher-resubmit
branch
from
September 30, 2017 18:04
21ec8ee to
de279dcComparecrisbeto
commented
Sep 30, 2017
MemberAuthor
Addressed the feedback @mmalerba. |
mmalerba
approved these changes
Oct 1, 2017
willshowell
commented
Oct 2, 2017
Contributor
Breaking changes comment for switching from function to ErrorStateMatcher class? |
kara
commented
Oct 3, 2017
Contributor
@crisbeto Rebase? |
crisbetoforce-pushed
the
select-error-state-matcher-resubmit
branch
from
October 3, 2017 19:33
de279dc to
ad38bb9Comparecrisbeto
commented
Oct 3, 2017
MemberAuthor
Rebased. |
* Allows for the select's error state matcher to be overwritten through an `@Input`. * Switches `MatSelect` over to use the same global provider for its error state as `MatInput`. **Note:** This is a resubmit of angular#6147 that works with our latest setup and excludes a few changes. Fixesangular#7419.
crisbetoforce-pushed
the
select-error-state-matcher-resubmit
branch
from
October 4, 2017 17:33
ad38bb9 to
a3c364cCompareThis issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Input.MatSelectover to use the same global provider for its error state asMatInput.Note: This is a resubmit of #6147 that works with our latest setup and excludes a few changes.
Fixes#7419